Bug 1229639 - build: fix gitclean target
Summary: build: fix gitclean target
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Prasanna Kumar Kalever
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-09 10:18 UTC by Prasanna Kumar Kalever
Modified: 2016-06-16 13:10 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-16 13:10:07 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Prasanna Kumar Kalever 2015-06-09 10:18:02 UTC 
Description of problem:
'make gitclean' deleting unexpected Makefiles

say:
        deleted:    extras/FreeBSD/Makefile
        deleted:    extras/command-completion/Makefile
        deleted:    extras/test/ld-preload-test/Makefile

Version-Release number of selected component (if applicable):
mainline

How reproducible:



Steps to Reproduce:
1. generate makefile ./autogen.sh && ./configure
2. $ make gitclean
3. $ git status

Actual results:
deleting builtin Makefile

Expected results:
only delete generated Makefiles by running ./configure

Additional info:
Comment 1 Anand Avati 2015-06-09 10:28:45 UTC 
REVIEW: http://review.gluster.org/11136 (build: fix gitclean target) posted (#1) for review on master by Prasanna Kumar Kalever
Comment 2 Anand Avati 2015-07-12 17:17:33 UTC 
COMMIT: http://review.gluster.org/11136 committed in master by Niels de Vos (ndevos) 
------
commit bfbd710b675d61fb3e8eaecd70eca92f806c6d8d
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Tue Jun 9 15:25:20 2015 +0530

    build: fix gitclean target
    
    $ make gitclean   # deleting unexpected 'Makefile' files
    ...
    
    $ git status
    ...
    
      deleted:    extras/FreeBSD/Makefile
      deleted:    extras/command-completion/Makefile
      deleted:    extras/test/ld-preload-test/Makefile
    
    ...
    
    This change fix to ignore above built-in makefiles while executing
    'gitclean' target
    
    Change-Id: I5365f5a1fe5b36141a6fe7ba27c38a2158f9f3a3
    BUG: 1229639
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/11136
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
Comment 3 Mike McCune 2016-03-28 23:22:56 UTC 
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions
Comment 4 Niels de Vos 2016-06-16 13:10:07 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Note You need to log in before you can comment on or make changes to this bug.