Bug 1230872 - Review Request: python-trollius-redis - Redis client for the Python event loop PEP3156 for Trollius.
Summary: Review Request: python-trollius-redis - Redis client for the Python event loo...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Haïkel Guémar
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2015-06-11 16:33 UTC by Pierre-YvesChibon
Modified: 2015-08-26 17:50 UTC (History)
2 users (show)

Fixed In Version: 0.1.4-2.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2015-08-26 15:04:20 UTC
karlthered: fedora-review+

Attachments (Terms of Use)

Description Pierre-YvesChibon 2015-06-11 16:33:55 UTC
Spec URL: http://pingou.fedorapeople.org/RPMs//python-trollius-redis.spec
SRPM URL: http://pingou.fedorapeople.org/RPMs//python-trollius-redis-0.1.4-1.fc21.src.rpm

Redis client for Python trollius

This Redis library is a completely asynchronous, non-blocking client for a
Redis server. It depends on trollius (asyncio compatible for PEP 3156). It
supports Python 2 Trollius-using developers.

If you're new to asyncio, it can be helpful to check out the asyncio
documentation first.

Comment 1 Pierre-YvesChibon 2015-06-11 16:39:26 UTC
Scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=10020863

Comment 2 Haïkel Guémar 2015-06-12 17:08:44 UTC
That wasn't even fun!

I hereby approve this package into Fedora Packages Collection as it complies with our guidelines. Please proceed with SCM request.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 10 files have unknown license. Detailed output of
     licensecheck in /home/haikel/1230872-python-trollius-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: python-trollius-redis-0.1.4-1.fc23.noarch.rpm
python-trollius-redis.noarch: W: summary-ended-with-dot C Redis client for the Python event loop PEP3156 for Trollius.
python-trollius-redis.noarch: W: spelling-error %description -l en_US asyncio -> Asuncion
python-trollius-redis.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/trollius_redis/protocol.py 0644L /usr/bin/env
python-trollius-redis.src: W: summary-ended-with-dot C Redis client for the Python event loop PEP3156 for Trollius.
python-trollius-redis.src: W: spelling-error %description -l en_US asyncio -> Asuncion
python-trollius-redis.src:96: W: macro-in-comment %check
python-trollius-redis.src:97: W: macro-in-comment %{__python2}
python-trollius-redis.src:100: W: macro-in-comment %{py3dir}
python-trollius-redis.src:101: W: macro-in-comment %{__python3}
python-trollius-redis.src:103: W: macro-in-comment %endif
python-trollius-redis.src:109: W: macro-in-comment %license
2 packages and 0 specfiles checked; 1 errors, 10 warnings.

Rpmlint (installed packages)
Cannot parse rpmlint output:

python-trollius-redis (rpmlib, GLIBC filtered):


Source checksums
https://pypi.python.org/packages/source/t/trollius_redis/trollius_redis-0.1.4.tar.gz :
  CHECKSUM(SHA256) this package     : dea58cd72ccfd0aecb6d0f4566ae695fc074eadb4cf7c4df8daabefaf5f57b4c
  CHECKSUM(SHA256) upstream package : dea58cd72ccfd0aecb6d0f4566ae695fc074eadb4cf7c4df8daabefaf5f57b4c

Comment 3 Fedora Update System 2015-06-15 07:48:43 UTC
python-trollius-redis-0.1.4-2.fc22 has been submitted as an update for Fedora 22.

Comment 4 Fedora Update System 2015-06-15 07:48:50 UTC
python-trollius-redis-0.1.4-2.fc21 has been submitted as an update for Fedora 21.

Comment 5 Fedora Update System 2015-06-15 07:48:58 UTC
python-trollius-redis-0.1.4-2.el7 has been submitted as an update for Fedora EPEL 7.

Comment 6 Fedora Update System 2015-06-18 13:18:34 UTC
python-trollius-redis-0.1.4-2.fc22 has been pushed to the Fedora 22 testing repository.

Comment 7 Fedora Update System 2015-08-26 15:04:19 UTC
python-trollius-redis-0.1.4-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2015-08-26 16:49:43 UTC
python-trollius-redis-0.1.4-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2015-08-26 17:50:05 UTC
python-trollius-redis-0.1.4-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.