Bug 1231133 - Labels on 'New Sync Plan' page have empty 'for' attribute
Summary: Labels on 'New Sync Plan' page have empty 'for' attribute
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Sync Plans
Version: 6.1.0
Hardware: x86_64
OS: Linux
low
low
Target Milestone: Unspecified
Assignee: satellite6-bugs
QA Contact: Katello QA List
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-12 08:42 UTC by Andrii Balakhtar
Modified: 2018-08-31 15:20 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-14 19:34:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 17752 0 None None None 2016-12-19 20:00:59 UTC

Description Andrii Balakhtar 2015-06-12 08:42:19 UTC
Description of problem:
Labels on 'New Sync Plan' page (e.g. 'Name', 'Description') have empty 'for' attribute, like this:
<label class="control-label col-sm-2 ng-binding" for="">Name</label>
Other pages have this attribute set to label name ("name", "description", etc). For example, here's label from 'New Host' page:
<label class="col-md-2 control-label" for="name">Name *</label>
That 'for' attribute is commonly used by our automation to determine the label so it would be great to make 'New Sync Plan' page consistent with the rest of pages.

Version-Release number of selected component (if applicable):
Sat 6.1 GA snap 8

How reproducible:
Always

Steps to Reproduce:
1. Go to Content -> Sync Plans -> New Sync Plan.
2. Open page source, check the attributes of labels present on the page ('Name', 'Description', 'Interval' etc.)

Actual results:
'for' attribute is empty:
<label class="control-label col-sm-2 ng-binding" for="">Name</label>
<label class="control-label col-sm-2 ng-binding" for="">Description</label>

Expected results:
<label class="control-label col-sm-2 ng-binding" for="name">Name</label>
<label class="control-label col-sm-2 ng-binding" for="description">Description</label>

Additional info:

Comment 1 RHEL Program Management 2015-06-12 08:42:33 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Bryan Kearney 2016-07-08 20:45:37 UTC
Per 6.3 planning, moving out non acked bugs to the backlog

Comment 5 Brad Buckingham 2016-09-01 12:41:10 UTC
Walden, would this be a valid bug?

It looks it may be coming from code like:
 <div bst-form-group label="{{ 'Name' | translate }}">

Comment 6 Walden Raines 2016-09-08 14:46:55 UTC
(In reply to Brad Buckingham from comment #5)
> Walden, would this be a valid bug?
> 
> It looks it may be coming from code like:
>  <div bst-form-group label="{{ 'Name' | translate }}">

This is a bug.  The "field" attribute should be set from the input ID here [1] and referenced in the label here [2].  The fact that this isn't working makes this a bug.

[1] https://github.com/Katello/bastion/blob/master/app/assets/javascripts/bastion/components/bst-form-group.directive.js#L53
[2] https://github.com/Katello/bastion/blob/master/app/assets/javascripts/bastion/components/views/bst-form-group.html#L2

Comment 7 Chris Roberts 2016-12-19 19:02:45 UTC
Created Red Mine issue for this:

http://projects.theforeman.org/issues/17752

Comment 8 Og Maciel 2017-02-14 19:34:22 UTC
This is an older bug which I do not envision being addressed in the near term. I am closing this out. If you believe doing so is an issue, please feel free to re-open and provide additional business information. Thank you.


Note You need to log in before you can comment on or make changes to this bug.