Bug 1231435 - Review Request: perl-Test-Deep-JSON - Compare JSON with Test::Deep
Summary: Review Request: perl-Test-Deep-JSON - Compare JSON with Test::Deep
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1228040
TreeView+ depends on / blocked
 
Reported: 2015-06-13 10:39 UTC by Emmanuel Seyman
Modified: 2015-06-21 08:21 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-21 08:21:58 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2015-06-13 10:39:17 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Deep-JSON/perl-Test-Deep-JSON.spec<main package name here> - <short summary here> 
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Deep-JSON/perl-Test-Deep-JSON-0.03-1.fc22.src.rpm
Description:
Test::Deep::JSON provides json($expected) function to expect that target
can be parsed as a JSON string and matches (by cmp_deeply) with $expected.

Fedora Account System Username: eseyman
Rpmlint output:
perl-Test-Deep-JSON.src: W: spelling-error %description -l en_US cmp -> cm, mp, camp
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 1 Petr Šabata 2015-06-15 08:13:59 UTC
Missing BRs:
 - CPAN::Meta, ./Build.PL:15
 - CPAN::Meta::Prereqs, ./Build.PL:16
 - utf8, ./Build.PL:10

You may lower the EU::MM version constraint to 6.59; that's what's required by the metadata.

Since you're running the release tests, consider BR'ing Test::Pod::Coverage as well (./xt/04_pod_coverage.t:3).

Comment 2 Emmanuel Seyman 2015-06-15 21:48:46 UTC
(In reply to Petr Šabata from comment #1)
> Missing BRs:
>  - CPAN::Meta, ./Build.PL:15
>  - CPAN::Meta::Prereqs, ./Build.PL:16
>  - utf8, ./Build.PL:10
> 
> You may lower the EU::MM version constraint to 6.59; that's what's required
> by the metadata.

Yeah, using 6.76 is pretty much muscle memory at this point. Fixed.

> Since you're running the release tests, consider BR'ing Test::Pod::Coverage
> as well (./xt/04_pod_coverage.t:3).

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-Deep-JSON/perl-Test-Deep-JSON.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-Deep-JSON/perl-Test-Deep-JSON-0.03-2.fc22.src.rpm

Comment 3 Petr Šabata 2015-06-16 08:23:19 UTC
(In reply to Emmanuel Seyman from comment #2)
> Yeah, using 6.76 is pretty much muscle memory at this point. Fixed.

I know :)

> Done.

Great, all good.  Approving.

Comment 4 Emmanuel Seyman 2015-06-16 08:35:59 UTC
Thanks, Petr. Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-Test-Deep-JSON
Short Description: Compare JSON with Test::Deep
Upstream URL: http://search.cpan.org/dist/Test-Deep-JSON-0.03/
Owners: eseyman
Branches: f22
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-06-16 13:56:44 UTC
Git done (by process-git-requests).

Comment 6 Emmanuel Seyman 2015-06-21 08:21:58 UTC
Mashed in rawhide a few days ago


Note You need to log in before you can comment on or make changes to this bug.