RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1231858 - resource/fence agent options form needs an overhaul
Summary: resource/fence agent options form needs an overhaul
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs
Version: 7.1
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: rc
: ---
Assignee: Ondrej Mular
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
: 1281414 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-15 13:53 UTC by Tomas Jelinek
Modified: 2016-11-03 20:54 UTC (History)
8 users (show)

Fixed In Version: pcs-0.9.152-9.el7
Doc Type: Bug Fix
Doc Text:
this bz doesn't need doc text
Clone Of:
Environment:
Last Closed: 2016-11-03 20:54:42 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1188361 1 None None None 2021-01-20 06:05:38 UTC
Red Hat Product Errata RHSA-2016:2596 0 normal SHIPPED_LIVE Moderate: pcs security, bug fix, and enhancement update 2016-11-03 12:11:34 UTC

Internal Links: 1188361

Description Tomas Jelinek 2015-06-15 13:53:06 UTC 
Fence agent form in pcsd web UI can be improved in several points:
- some options should have a checkbox or a combobox instead of a textfield
- options should be divided into three groups: basic, advanced, expert
- some options should not be displayed at all (action, version, help)
Fence agents should provide all information needed for this in their metadata.
Comment 1 Tomas Jelinek 2015-07-24 14:35:56 UTC 
Maybe once reading of metadata through pacemaker (bz1188361) is implemented the options, which should not be displayed, will be filtered automatically by pacemaker.

We need to find out which options should not be displayed and editable, e.g. values of action and port may conflict with values provided by pacemaker when a fence agent is actually called from pacemaker.
Comment 4 Tomas Jelinek 2015-11-12 14:02:47 UTC 
Currently the form is downloaded from a remote cluster node as a piece of HTML code and included into a resource page using AJAX. This causes issues when a gui host and a cluster node run different versions of pcs. There is also a rendering issue, as downloading the form takes some time.
The preferred solution is to get structured data via AJAX from a cluster node and render the form on the gui node in the same way as rest of the page.
Comment 5 Tomas Jelinek 2015-11-12 14:03:21 UTC 
*** Bug 1281414 has been marked as a duplicate of this bug. ***
Comment 7 Ondrej Mular 2016-04-26 12:28:06 UTC 
proposed changes:
https://github.com/feist/pcs/commit/381c526cdfc0e503172146c48ddcb10bf5f24b6f
https://github.com/feist/pcs/commit/f6982429b814556e9231625371df3c85b7c49413
https://github.com/feist/pcs/commit/b71274e573a80c5298a4ad11fd076ec0115c1d0e
https://github.com/feist/pcs/commit/0459ef8397ce266abd2973822bcba6c7c11cc94b

Test:
All changes in GUI are applicable on resource instance attributes (updating existing and creating new resource) and fence device instance attributes (updating existing and creating new fence device).
In GUI when managing cluster with older pcsd there is no visible change except that description is no more as a placeholder of instance attribute but description is displayed after mouse-over on info icon next to attribute name.
When managing cluster with new pcsd from GUI, there is same change as with older pcsd, and also these:
 * default value of attribute is displayed as placeholder of attribute value
 * fence device instance attributes "pcmk_host_map", "pcmk_host_list", "pcmk_host_check", "pcmk_delay_max" and "priority" were moved from advanced arguments to optional arguments
 * fence device instance attributes "debug", "action", "verbose", "version" and "help" are no more present, as there is no point of setting them

CLI commands affected by these changes:
 * pcs resource list
 * pcs resource describe
 * pcs resource create
 * pcs resource update
 * pcs stonith list
 * pcs stonith describe
 * pcs stonith create
 * pcs stonith update
Command 'pcs stonith describe <agent-name>' can show more specific information about some options. All other commands should work as before.
Comment 8 Ivan Devat 2016-05-31 12:11:48 UTC 
Works as described in comment 7
Comment 10 Ondrej Mular 2016-06-13 12:01:27 UTC 
additional fixes:
https://github.com/ClusterLabs/pcs/commit/c7e0acbeeb1472b75250094ea54
https://github.com/ClusterLabs/pcs/commit/359e8f5c71fd6d3e3563df63efa
Comment 11 Ivan Devat 2016-06-22 12:23:19 UTC 
Before fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.151-1.el7.x86_64
[vm-rhel72-3 ~] $ pcs stonith
NO stonith devices configured
[vm-rhel72-3 ~] $ pcs stonith create xvm-fencing fence_xvm pcmk_host_map="vm-rhel72-1:vm.rhel72.1;vm-rhel72-3:vm.rhel72.3" action=monitor
Error: resource option(s): 'action', are not recognized for resource type: 'stonith:fence_xvm' (use --force to override)


After Fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.152-1.el7.x86_64

[vm-rhel72-3 ~] $ pcs stonith
NO stonith devices configured
[vm-rhel72-3 ~] $ pcs stonith create xvm-fencing fence_xvm pcmk_host_map="vm-rhel72-1:vm.rhel72.1;vm-rhel72-3:vm.rhel72.3" action=monitor
[vm-rhel72-3 ~] $ pcs stonith
 xvm-fencing    (stonith:fence_xvm):    Started vm-rhel72-3
Comment 12 Ivan Devat 2016-06-22 12:27:59 UTC 
Before fix:
There is no optional argument "action" in web UI under tab FENCE DEVICES.

After fix:
There is optional argument "action" in web UI under tab FENCE DEVICES.
Comment 15 Ondrej Mular 2016-07-25 12:38:03 UTC 
additional fix:
https://github.com/ClusterLabs/pcs/commit/5db2a3d4568eac54d53837bf160b4395334
Comment 16 Ondrej Mular 2016-07-27 08:05:37 UTC 
additional fix 3:
https://github.com/ClusterLabs/pcs/commit/06318c27024c1c702eaa38d82f434b1c8111
Comment 21 Tomas Jelinek 2016-09-13 11:48:26 UTC 
additional fixes for compatibility with older pcsd versions:

- display resources as managed when pcsd does not provide managed/unmanaged status
https://github.com/ClusterLabs/pcs/commit/6007fba70212a184934c0c9e8763a300bcda0d45

- fix node standby/unstandby
https://github.com/ClusterLabs/pcs/commit/f1b60c3a2bace5d6a38a1b5e58f5b98aafbe5f70
Comment 22 Tomas Jelinek 2016-09-14 11:58:28 UTC 
additional fixes for compatibility with older pcsd versions, fixing clone/master/unclone group/ungroup buttons for resources

https://github.com/ClusterLabs/pcs/commit/73adbedf268ec1578040598b1539e5275c02473b
https://github.com/ClusterLabs/pcs/commit/1302b4e62e1956ffbc27d32f4ae761486c329ea9
https://github.com/ClusterLabs/pcs/commit/f639c0dded1223f3dd52e431614be0b3621406da
https://github.com/ClusterLabs/pcs/commit/584092ce7d045eae29aeca5a1f1ced5c069e5eb8
Comment 27 errata-xmlrpc 2016-11-03 20:54:42 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2596.html
Note You need to log in before you can comment on or make changes to this bug.