Spec URL: http://puiterwijk.fedorapeople.org//python-jwcrypto.spec SRPM URL: http://puiterwijk.fedorapeople.org//python-jwcrypto-0.2.0-1.fc21.src.rpm Description: Implements JWK,JWS,JWE specifications using python-cryptography
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10071031
Now also building python3 on Fedora: Spec URL: http://puiterwijk.fedorapeople.org//python-jwcrypto.spec SRPM URL: http://puiterwijk.fedorapeople.org//python-jwcrypto-0.2.0-2.fc21.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10071468 Note: sitelib removed because I'm only interrested in F22/rawhide.
Summary for the py3 subpackage: - Implements JWK,JWS,JWE specifications using python*3*-cryptography ? (same for the description?) * Spec is clean * License is valid ! Tests seem to be part of the sources but not run in the spec ! Tests are installed as part of the module, is this expected? * Sha256 used: srpm: 229fabdaa687cd4bdd77d8d1dba97995b62fa2801f847945210bff7ed1a054a1 upstream: 229fabdaa687cd4bdd77d8d1dba97995b62fa2801f847945210bff7ed1a054a1 ! Does not build on F21-x86_64: ImportError: No module named setuptools ! All the files are ending up in python-jwcrypto including the py3 ones
Spec URL: http://puiterwijk.fedorapeople.org//python-jwcrypto.spec SRPM URL: http://puiterwijk.fedorapeople.org//python-jwcrypto-0.2.0-3.fc21.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10103696 changelog: - Fix F21 build error by adding buildrequire python-setuptools - Move files into python3-jwcrypto subpackage - Run test suite - Do not install test suite - Fix summary and description of python3-jwcrypto
rpmlint python-jwcrypto-0.2.0-3.fc21.noarch.rpm python3-jwcrypto-0.2.0-3.fc21.noarch.rpm python-jwcrypto-0.2.0-3.fc21.src.rpm python3-jwcrypto.noarch: W: no-documentation python-jwcrypto.src: W: invalid-url Source1: https://github.com/simo5/jwcrypto/releases/download/v0.2.0/jwcrypto-0.2.0.tar.gz.sha512sum.txt HTTP Error 403: Forbidden python-jwcrypto.src: W: invalid-url Source0: https://github.com/simo5/jwcrypto/releases/download/v0.2.0/jwcrypto-0.2.0.tar.gz HTTP Error 403: Forbidden The two 403 are odd, but I could download them manually just fine, so let's ignore these for now. * sha256 did not change from previous revision ! the py3 subpackage should ship the doc and license as well ! The tests would better be ran in %check (this way they can also be skipped) The tests are not a requirement anyway, so I won't block the review on this. Please fix the license and doc for the py3 subpackage and I will approve this package.
Spec URL: http://puiterwijk.fedorapeople.org//python-jwcrypto.spec SRPM URL: http://puiterwijk.fedorapeople.org//python-jwcrypto-0.2.0-4.fc21.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10103696 changelog: - Ship readme and license with python3 subpackage - Move tests to %check The 403s are caused by github's CDN not working well with curl, but they work with wget.
Sorry, wrong scratch build link. Correct one: http://koji.fedoraproject.org/koji/taskinfo?taskID=10109413
Still some errors: $ rpmlint python-jwcrypto-0.2.0-4.fc21.src.rpm python-jwcrypto-0.2.0-4.fc21.noarch.rpm python3-jwcrypto-0.2.0-4.fc21.noarch.rpm python-jwcrypto.src:85: W: macro-in-%changelog %check python-jwcrypto.src: W: invalid-url Source1: https://github.com/simo5/jwcrypto/releases/download/v0.2.0/jwcrypto-0.2.0.tar.gz.sha512sum.txt HTTP Error 403: Forbidden python-jwcrypto.src: W: invalid-url Source0: https://github.com/simo5/jwcrypto/releases/download/v0.2.0/jwcrypto-0.2.0.tar.gz HTTP Error 403: Forbidden python3-jwcrypto.noarch: W: python-bytecode-without-source /usr/lib/python3.4/site-packages/jwcrypto/__pycache__/tests.cpython-34.pyo python3-jwcrypto.noarch: W: python-bytecode-without-source /usr/lib/python3.4/site-packages/jwcrypto/__pycache__/tests.cpython-34.pyc python3-jwcrypto.noarch: W: python-bytecode-without-source /usr/lib/python3.4/site-packages/jwcrypto/__pycache__/tests-cookbook.cpython-34.pyc python3-jwcrypto.noarch: W: python-bytecode-without-source /usr/lib/python3.4/site-packages/jwcrypto/__pycache__/tests-cookbook.cpython-34.pyo The macro in the changelog is an easyfix (replace %check by %%check). The other needs a little more tweaking I guess.
Spec URL: http://puiterwijk.fedorapeople.org//python-jwcrypto.spec SRPM URL: http://puiterwijk.fedorapeople.org//python-jwcrypto-0.2.0-5.fc21.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10181632 changelog: - Fix macro in changelog - Remove the last remnants of the test suite
$ rpmlint python-jwcrypto-0.2.0-5.fc21.noarch.rpm python3-jwcrypto-0.2.0-5.fc21.noarch.rpm python-jwcrypto-0.2.0-5.fc21.src.rpm python-jwcrypto.src: W: invalid-url Source1: https://github.com/simo5/jwcrypto/releases/download/v0.2.0/jwcrypto-0.2.0.tar.gz.sha512sum.txt HTTP Error 403: Forbidden python-jwcrypto.src: W: invalid-url Source0: https://github.com/simo5/jwcrypto/releases/download/v0.2.0/jwcrypto-0.2.0.tar.gz HTTP Error 403: Forbidden 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Thanks for fixing the package. This package is APPROVED!