Bug 1232580 - Review Request: purple-line - libpurple (Pidgin, Finch) protocol plugin for LINE
Summary: Review Request: purple-line - libpurple (Pidgin, Finch) protocol plugin for LINE
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-17 05:48 UTC by fujiwara
Modified: 2015-07-23 08:57 UTC (History)
3 users (show)

Fixed In Version: purple-line-20150426git9b7b019-1.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-23 08:57:57 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description fujiwara 2015-06-17 05:48:58 UTC
Spec URL: https://fujiwara.fedorapeople.org/purple-line/purple-line.spec
SRPM URL: https://fujiwara.fedorapeople.org/purple-line/purple-line-20150426git9b7b019-1.fc22.src.rpm
Description: 
This provides the interface of LINE messenger for pidgin.
Fedora Account System Username: fujiwara

Comment 1 Parag AN(पराग) 2015-07-02 15:29:00 UTC
Issues:
1) rpmlint on all generated rpms gave output as
purple-line.src: W: spelling-error Summary(en_US) libpurple -> lib purple, lib-purple, purple
purple-line.src: W: summary-not-capitalized C libpurple (Pidgin, Finch) protocol plugin for LINE
purple-line.src: W: invalid-url Source0: purple-line-20150426git9b7b019.tar.gz
purple-line.x86_64: W: spelling-error Summary(en_US) libpurple -> lib purple, lib-purple, purple
purple-line.x86_64: W: summary-not-capitalized C libpurple (Pidgin, Finch) protocol plugin for LINE
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

==> Fix summary capitalization

2) Group tag is not mandatory now so can be removed

3) License is MIT and not BSD as per LICENSE text

4) CFLAGS are not honored when compilation happens. See https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

5) Maybe you want to use %license macro as
%license LICENSE
%doc README.md

Comment 3 Parag AN(पराग) 2015-07-06 14:01:56 UTC
Looks good.

APPROVED.

Comment 4 fujiwara 2015-07-07 02:19:36 UTC
New Package SCM Request
=======================
Package Name: purple-line
Short Description: libpurple (Pidgin, Finch) protocol plugin for LINE
Upstream URL: http://altrepo.eu/git/purple-line
Owners: fujiwara
Branches: f22 f23
InitialCC: i18n-team

Comment 5 Gwyn Ciesla 2015-07-08 12:01:41 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2015-07-09 04:18:49 UTC
purple-line-20150426git9b7b019-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/purple-line-20150426git9b7b019-1.fc22

Comment 7 Fedora Update System 2015-07-13 19:16:17 UTC
purple-line-20150426git9b7b019-1.fc22 has been pushed to the Fedora 22 testing repository.

Comment 8 Fedora Update System 2015-07-23 08:57:57 UTC
purple-line-20150426git9b7b019-1.fc22 has been pushed to the Fedora 22 stable repository.


Note You need to log in before you can comment on or make changes to this bug.