Bug 1232921 - No error reported when app-create environment variables cannot be parsed
Summary: No error reported when app-create environment variables cannot be parsed
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: oc
Version: 2.2.0
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
: ---
Assignee: Timothy Williams
QA Contact: libra bugs
URL:
Whiteboard:
: 1229815 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-17 20:05 UTC by Timothy Williams
Modified: 2019-08-15 04:43 UTC (History)
6 users (show)

Fixed In Version: rhc-1.37.1.2-1.el6op
Doc Type: Bug Fix
Doc Text:
If environment variables are specified with rhc, but no environment variables were able to be parsed, the environment variables were previously ignored and errors were not reported when syntactically incorrect environment variables were provided. This led users to believe their environment variables were added when the application was created. This bug fixes updates rhc so that when the environment variable flag is specified, but no environment variables can be parsed, an error is reported.
Clone Of:
Environment:
Last Closed: 2015-09-30 16:38:03 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:1844 0 normal SHIPPED_LIVE Important: Red Hat OpenShift Enterprise 2.2.7 security, bug fix and enhancement update 2015-09-30 20:35:28 UTC

Description Timothy Williams 2015-06-17 20:05:41 UTC 
Description of problem:
When creating an application and providing environment variables, the environment variables are ignored if they are not provided in the correct syntax.

Version-Release number of selected component (if applicable):
2.2.5

How reproducible:
Always

Steps to Reproduce:
1. Create an application with rhc and provide an incorrectly formatted environment variable:

  # rhc app-create breaktest ruby-1.9 -e varvalue

Actual results:
Application is created

Expected results:
Failure to create, explaining that the environment variable is not provided with the correct syntax (var=value).

Additional info:
https://bugzilla.redhat.com/show_bug.cgi?id=1229815 is related
Comment 2 openshift-github-bot 2015-07-01 15:13:27 UTC 
Commit pushed to master at https://github.com/openshift/rhc

https://github.com/openshift/rhc/commit/f17006e1d95b158cec267736ddddc3822b00f134
Report error when a syntatically incorrect env var is provided on app-create

Bug 1232921
https://bugzilla.redhat.com/show_bug.cgi?id=1232921
When creating an application with an environment variable, report an error if the environment variable is not provided with the proper syntax. Previously, incorrect environment variables were ignored and the application creation continued.
Comment 3 Timothy Williams 2015-07-17 15:19:13 UTC 
*** Bug 1229815 has been marked as a duplicate of this bug. ***
Comment 6 Yanping Zhang 2015-08-20 08:11:47 UTC 
Timothy, we need a new ose 2.2 puddle containing the fix to verify this bug, pls move it to ON_QA again when the puddle is available, thx!
Comment 8 Yanping Zhang 2015-09-22 02:08:15 UTC 
Verified on rhc-1.37.1.2-1.el6op.noarch
Steps to verify:
[root@dhcp-129-219 ~]# rhc app create pltest perl-5.10 -e testll
Environment variable(s) not provided.
Please provide at least one environment variable using the syntax VARIABLE=VALUE. VARIABLE can only contain letters, digits and underscore
('_') and can't begin with a digit.

There is error info reported when -e is with invalid format, so move the bug to Verified.
Comment 11 errata-xmlrpc 2015-09-30 16:38:03 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1844.html
Note You need to log in before you can comment on or make changes to this bug.