Bug 1233018 - tests: Add the command being 'TEST'ed in all gluster logs
Summary: tests: Add the command being 'TEST'ed in all gluster logs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tests
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-18 04:58 UTC by Ravishankar N
Modified: 2016-06-16 13:13 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-16 13:13:39 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2015-06-18 04:58:24 UTC
Description of problem:
It is difficult to analyse the logs of a failed regression/test case run when multiple test cases are run. It would be helpful to add the test case number and the line number of the test case currently being executed in all the logs.

Comment 1 Anand Avati 2015-06-18 05:00:43 UTC
REVIEW: http://review.gluster.org/10667 (tests: Add the command being 'TEST'ed in all gluster logs) posted (#7) for review on master by Ravishankar N (ravishankar)

Comment 2 Ravishankar N 2015-06-18 05:04:17 UTC
Running tests with this patch is also helping cover bugs due to races, BZ 1222748 being one of them.

Comment 3 Anand Avati 2015-06-26 07:18:29 UTC
REVIEW: http://review.gluster.org/10667 (tests: Add the command being 'TEST'ed in all gluster logs) posted (#8) for review on master by Ravishankar N (ravishankar)

Comment 4 Anand Avati 2015-06-26 15:41:00 UTC
REVIEW: http://review.gluster.org/10667 (tests: Add the command being 'TEST'ed in all gluster logs) posted (#9) for review on master by Ravishankar N (ravishankar)

Comment 5 Anand Avati 2015-06-29 12:18:16 UTC
COMMIT: http://review.gluster.org/10667 committed in master by Raghavendra Talur (rtalur) 
------
commit b343155815716094a70c5428c26ddcb0980a031e
Author: Ravishankar N <ravishankar>
Date:   Sat May 9 07:23:09 2015 +0530

    tests: Add the command being 'TEST'ed in all gluster logs
    
    Appends all commands being run under the test framework into the logs
    with time stamps. Its a hack but I find it very useful to see what
    sections of the logs (across all logs) need to be analysed between
    execution of 2 commands.
    
    Here's a sample output:
    [2015-06-26 13:25:15.866764479]:++++++++++ G_LOG:tests/basic/afr/quorum.t: TEST: 46 ! test_write ++++++++++
    [2015-06-26 13:25:15.872002] I [afr-common.c:1682:afr_local_discovery_cbk] 0-patchy-replicate-0: selecting local read_child patchy-client-1
    [2015-06-26 13:25:15.874559] W [fuse-bridge.c:723:fuse_truncate_cbk] 0-glusterfs-fuse: 81: TRUNCATE() /a => -1 (Read-only file system)
    [2015-06-26 13:25:15.880554623]:++++++++++ G_LOG:tests/basic/afr/quorum.t: TEST: 47 abc cat /mnt/glusterfs/0/b ++++++++++
    [2015-06-26 13:25:15.897767878]:++++++++++ G_LOG:tests/basic/afr/quorum.t: TEST: 48 gluster --mode=script --wignore volume set patchy cluster.quorum-reads on ++++++++++[2015-06-26 13:25:15.994410] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
    [2015-06-26 13:25:17.098519] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
    [2015-06-26 13:25:17.099241] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
    [2015-06-26 13:25:17.099685] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
    [2015-06-26 13:25:17.100055] I [glusterfsd-mgmt.c:51:mgmt_cbk_spec] 0-mgmt: Volume file changed
    [2015-06-26 13:25:17.105896] W [MSGID: 108003] [afr.c:94:fix_quorum_options] 0-patchy-replicate-0: quorum-type auto overriding quorum-count 2
    [2015-06-26 13:25:17.105936] W [MSGID: 108001] [afr.c:189:reconfigure] 0-patchy-replicate-0: Client-quorum is not met
    [2015-06-26 13:25:17.107438] I [glusterfsd-mgmt.c:1507:mgmt_getspec_cbk] 0-glusterfs: No change in volfile, continuing
    [2015-06-26 13:25:17.108724] I [glusterfsd-mgmt.c:1507:mgmt_getspec_cbk] 0-glusterfs: No change in volfile, continuing
    [2015-06-26 13:25:17.110082] I [glusterfsd-mgmt.c:1507:mgmt_getspec_cbk] 0-glusterfs: No change in volfile, continuing
    [2015-06-26 13:25:17.110599] I [glusterfsd-mgmt.c:1507:mgmt_getspec_cbk] 0-glusterfs: No change in volfile, continuing
    [2015-06-26 13:25:17.109678070]:++++++++++ G_LOG:tests/basic/afr/quorum.t: TEST: 49 1 mount_get_option_value /mnt/glusterfs/0 patchy-replicate-0 quorum-reads ++++++++++
    [2015-06-26 13:25:17.117801] I [afr-common.c:1682:afr_local_discovery_cbk] 0-patchy-replicate-0: selecting local read_child patchy-client-1
    
    Change-Id: Ib51284a0384508350579babaf1ae69cb372e0baa
    BUG: 1233018
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/10667
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 6 Niels de Vos 2016-06-16 13:13:39 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.