Bug 1233202 - Non-breaking spaces are lost in translatable strings
Summary: Non-breaking spaces are lost in translatable strings
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Publican
Classification: Community
Component: publican
Version: 4.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 4.3
Assignee: Lee Newson
QA Contact: Ruediger Landmann
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-18 12:24 UTC by Raphaël Hertzog
Modified: 2015-07-28 06:54 UTC (History)
4 users (show)

Fixed In Version: 4.3.2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-28 06:54:58 UTC
Embargoed:


Attachments (Terms of Use)
Patch to preserve non breaking spaces (1.36 KB, patch)
2015-06-25 20:37 UTC, Raphaël Hertzog
no flags Details | Diff

Description Raphaël Hertzog 2015-06-18 12:24:00 UTC
This is the return of https://bugzilla.redhat.com/show_bug.cgi?id=582649
Please fix it again and add a non-regression test case so that I won't have to report it again in 5 years. :-)

The problem is that my original document contains an UTF-8 non-breaking space between some words and they are replaced by normal spaces in the strings appearing as "msgid" in the POT files.

And my old translations are no longer used since Publican is now again looking for a string with a normal space instead of non-breaking space.

The problem has probably been reintroduced with c59173f096fcdf8b3e2646244bbf10936e900f14 while fixing #1143792 in 4.2.3.

Comment 1 Raphaël Hertzog 2015-06-25 20:37:38 UTC
Created attachment 1043276 [details]
Patch to preserve non breaking spaces

Please find a patch that fixes this issue. Just like you did last time, I used [ \t] instead of \s.

I did not add any non-regression test though.

Comment 2 Lee Newson 2015-07-16 09:50:16 UTC
Hi Raphaël,

I've applied your patch thanks and also added a basic regression test that should catch this issue in the future.

To ssh://git.fedorahosted.org/git/publican.git
   7471e8c..27e957e  devel -> devel


Note You need to log in before you can comment on or make changes to this bug.