Bug 1233279 - Review Request: perl-Log-Agent - Logging agent
Summary: Review Request: perl-Log-Agent - Logging agent
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-18 15:13 UTC by Petr Pisar
Modified: 2015-06-22 14:54 UTC (History)
2 users (show)

Fixed In Version: perl-Log-Agent-1.000-1.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-22 14:54:11 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2015-06-18 15:13:47 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Log-Agent/perl-Log-Agent.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Log-Agent/perl-Log-Agent-1.000-1.fc23.src.rpm
Description:
The Log::Agent Perl module provides an abstract layer for logging and tracing,
which is independent from the actual method used to physically perform those
activities. It acts as an agent (hence the name) that collects the requests
and delegates processing to a logging driver.

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2015-06-19 11:43:51 UTC
Package the README file as %doc rather then %license.  The %license macro is reserved for license texts so they get installed even if documentation is disabled.  This README file doesn't provide, from the licensing point of view,  anything what the RPM License tag or the modules themselves don't.

Consider packaging Log-Agent-Rotate for the optional log rotating features.

The following build-time deps aren't needed since the files requiring them aren't tested:
 - Mail::Mailer
 - Sys::Syslog

The patch is fine.

So is the license.

Comment 2 Petr Pisar 2015-06-19 12:03:31 UTC
Updated spec file is on the same address.

Comment 3 Petr Pisar 2015-06-19 12:08:01 UTC
I cannot package the Log-Agent-Rotate because it's Artistic 1 only code.

Comment 4 Petr Šabata 2015-06-19 12:27:42 UTC
(In reply to Petr Pisar from comment #2)
> Updated spec file is on the same address.

Ack, all good.

(In reply to Petr Pisar from comment #3)
> I cannot package the Log-Agent-Rotate because it's Artistic 1 only code.

Fair enough.

Comment 5 Petr Pisar 2015-06-19 13:44:12 UTC
New Package SCM Request
=======================
Package Name: perl-Log-Agent
Short Description: Logging agent
Upstream URL: http://search.cpan.org/dist/Log-Agent/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 6 Gwyn Ciesla 2015-06-22 14:07:08 UTC
Git done (by process-git-requests).

Comment 7 Petr Pisar 2015-06-22 14:54:11 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.