Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1233503

Summary: Template parameters should be able to be validated
Product: OpenShift Container Platform Reporter: Tomas Schlosser <tschloss>
Component: RFEAssignee: Ben Parees <bparees>
Status: CLOSED DEFERRED QA Contact: Johnny Liu <jialiu>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.0.0CC: akostadi, dmcphers, ederevea, jliggitt, jokerman, libra-bugs, libra-onpremise-devel, mbarrett, misalunk, mmccomas, tschloss, wsun
Target Milestone: ---Keywords: NeedsTestCase
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-12 13:54:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tomas Schlosser 2015-06-19 04:40:41 UTC
When creating resources from template, if I do so mistake, the resource cration is attempted and errors are shown only on overview page after submitting.

For example - when creating EAP application, if I put application name longer than 10 characters and submit, I'm told, I can't create services with name longer than  24 characters after I tried to create it, but I can't return to the template, fix the issues and try to create it again.

Another issue is that other resources that are not broken are created, so I end up with half an application created.

Comment 2 Wei Sun 2015-06-19 05:54:57 UTC
I could reproduce this bug.I create a template which the application name is more than 24 characters using `oc create -f $templatefile`,and try to create the application from the template on web console.After clicking the create button,on the overview page,the failed info is shown.But my other resources have been created.

$ openshift version
openshift v3.0.0.0-25-g235b0e7
kubernetes v0.17.1-804-g496be63

Comment 3 Jordan Liggitt 2015-06-19 15:19:44 UTC
Template parameters don't currently contain validation rules.

Adding them would allow clients (like the CLI and UI) to validate input prior to processing the template (or get validation errors back from the processing step, prior to submitting the result for creation).

Comment 4 Yanping Zhang 2015-07-14 02:06:10 UTC
*** Bug 1241557 has been marked as a duplicate of this bug. ***

Comment 5 Aleksandar Kostadinov 2015-07-29 05:07:33 UTC
Probably cli can keep track of what is created and delete it on unsuccessful operation. Even better the server could do it. Who would want to have a half completed operation and be unable to easily recover from it without tracking all leftover pods/services/whatever?

Maybe a separate flag can be provided to ask server to not clean-up partial deployments for the cases somebody wants that?

Comment 8 Eric Rich 2018-03-12 13:54:36 UTC
This bug has been identified as a dated (created more than 3 months ago) bug. 
This bug has been triaged (has a trello card linked to it), or reviewed by Engineering/PM and has been put into the product backlog, 
however this bug has not been slated for a currently planned release (3.9, 3.10 or 3.11), which cover our releases for the rest of the calendar year. 

As a result of this bugs age, state on the current roadmap and PM Score (being below 70), this bug is being Closed - Differed, 
as it is currently not part of the products immediate priorities.

Please see: https://docs.google.com/document/d/1zdqF4rB3ea8GmVIZ7qWCVYUaQ7-EexUrQEF0MTwdDkw/edit for more details.