+++ This bug was initially created as a clone of Bug #1208482 +++ Description of problem: At present stage the initialization and destroy of conditional and mutex variables of fs struct happen in different scenarios and there is no uniformal way of destroying these variables incase there is a failure when initializing the same. The fs mutex and conditional variables( cond and child_down_count) are getting destroyed from glfs_free_from_ctx(). However this destroy is not done by a conditional check inside destroy function. This has to be corrected. Version-Release number of selected component (if applicable): GlusterFS 3.6.2 How reproducible: N/A Steps to Reproduce: N/A Actual results: The destroy of variables done in an unconditional way in glfs_fini(). Expected results: It has to follow a single path to destroy in clean up function glfs_fini(). Additional info: By introducing bit flags in glfs fs object we can make use of the same ( if there is a failure in initialization ) in glfs_fini() which is evolving as a one and only function to free fs and ctx resources. The init functions can set the flags according to the initialization flow of the mutex and conditional variables of struct fs members. Without this patch we are compelled to use the goto lables and other hacks in init functions to make sure the resources are freed if there is an error path. --- Additional comment from Anand Avati on 2015-04-02 07:40:09 EDT --- REVIEW: http://review.gluster.org/10120 (libgfapi: introduce bit flags for pthread mutex or cond variables) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy) --- Additional comment from Anand Avati on 2015-04-06 08:41:30 EDT --- REVIEW: http://review.gluster.org/10120 (libgfapi: introduce bit flags for pthread mutex or cond variables) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy) --- Additional comment from Anand Avati on 2015-04-06 08:54:24 EDT --- REVIEW: http://review.gluster.org/10120 (libgfapi: introduce bit flags for pthread mutex or cond variables) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy) --- Additional comment from Anand Avati on 2015-04-06 12:46:28 EDT --- REVIEW: http://review.gluster.org/10120 (libgfapi: introduce bit flags for pthread mutex or cond variables) posted (#4) for review on master by Niels de Vos (ndevos) --- Additional comment from Anand Avati on 2015-04-08 05:17:52 EDT --- REVIEW: http://review.gluster.org/10120 (libgfapi: introduce bit flags for pthread mutex and cond variables) posted (#5) for review on master by Humble Devassy Chirammal (humble.devassy) --- Additional comment from Anand Avati on 2015-04-08 09:47:10 EDT --- REVIEW: http://review.gluster.org/10120 (libgfapi: introduce bit flags for pthread mutex and cond variables) posted (#6) for review on master by Humble Devassy Chirammal (humble.devassy) --- Additional comment from Anand Avati on 2015-04-13 03:57:10 EDT --- REVIEW: http://review.gluster.org/10120 (libgfapi: introduce bit flags for pthread mutex and cond variables) posted (#7) for review on master by Humble Devassy Chirammal (humble.devassy) --- Additional comment from Anand Avati on 2015-05-19 03:40:19 EDT --- REVIEW: http://review.gluster.org/10120 (libgfapi: introduce bit flags for pthread mutex and cond variables) posted (#8) for review on master by Poornima G (pgurusid) --- Additional comment from Anand Avati on 2015-05-21 02:34:47 EDT --- REVIEW: http://review.gluster.org/10120 (libgfapi: introduce bit flags for pthread mutex and cond variables) posted (#9) for review on master by Poornima G (pgurusid) --- Additional comment from Anand Avati on 2015-05-28 06:53:55 EDT --- REVIEW: http://review.gluster.org/10971 (libgfapi: introduce bit flags for pthread mutex and cond variables) posted (#1) for review on release-3.7 by Humble Devassy Chirammal (humble.devassy)
COMMIT: http://review.gluster.org/10971 committed in release-3.7 by Niels de Vos (ndevos) ------ commit 5afaa6e64f46a32f2b86512236677066adc36510 Author: Humble Devassy Chirammal <hchiramm> Date: Mon May 18 17:37:14 2015 +0530 libgfapi: introduce bit flags for pthread mutex and cond variables At present stage, the initialization and destroy of conditional and mutex variables of glfs struct happen in different places and there is no uniform way of destroying these variables incase there is a failure when initializing these. The fs mutex and conditional variables are getting destroyed from glfs_free_from_ctx(). However this destroy is not done by a conditional check inside destroy function. By introducing bit flags in glfs object, we can make use of the same (if there is a failure in initialization) in glfs_fini() which is evolving as one and only function to free fs and ctx resources. This patch introduce the flags field and set the flags according to the initialization flow of the mutex and conditional variables of struct glfs members. Without this patch we are compelled to use the goto lables and other hacks in init functions to make sure the resources are freed if there is an error path. Change-Id: I86e2719fb7ce437419a05699b4f06c14b02d0e69 BUG: 1233651 Signed-off-by: Humble Devassy Chirammal <hchiramm> Signed-off-by: Poornima G <pgurusid> Reviewed-on: http://review.gluster.org/10120 Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> Tested-by: NetBSD Build System Reviewed-by: Shyamsundar Ranganathan <srangana> (cherry picked from commit bc858473db1e1091b15d3f3d69ac6ba5d20b58e7) Reviewed-on: http://review.gluster.org/10971 Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report. glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user