Bug 1234432 - Review Request: perl-Config-Model-Tester - Test framework for Config::Model
Summary: Review Request: perl-Config-Model-Tester - Test framework for Config::Model
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1230173
TreeView+ depends on / blocked
 
Reported: 2015-06-22 14:11 UTC by Jitka Plesnikova
Modified: 2015-06-24 06:48 UTC (History)
2 users (show)

Fixed In Version: perl-Config-Model-Tester-2.051-1.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-24 06:48:06 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jitka Plesnikova 2015-06-22 14:11:41 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Config-Model-Tester/perl-Config-Model-Tester.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Config-Model-Tester/perl-Config-Model-Tester-2.051-1.fc23.src.rpm
Description:
This class provides a way to test configuration models with tests files.
This class was designed to tests several models and several tests cases
per model.

Fedora Account System Username: jplesnik

Comment 1 Petr Šabata 2015-06-22 14:41:17 UTC
Line 59 isn't necessary these days.  If you remove it, you can also drop the dependency on coreutils and findutils.

The explicit version constraint for Log::Log4perl isn't necessary.  perl-generators pick this up from the code.

I think the License tag should be changed to `LGPLv2', omitting the plus sign.  Upstream explicitly declares the version in the module file.

Comment 2 Jitka Plesnikova 2015-06-22 14:54:02 UTC
Updated files are available on the same links.

Comment 3 Petr Šabata 2015-06-22 18:26:05 UTC
Ack, approving.

Comment 4 Jitka Plesnikova 2015-06-23 06:27:17 UTC
New Package SCM Request
=======================
Package Name: perl-Config-Model-Tester
Short Description: Test framework for Config::Model
Upstream URL: http://search.cpan.org/dist/Config-Model-Tester/
Owners: jplesnik ppisar psabata
Branches:
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-06-23 12:19:32 UTC
Git done (by process-git-requests).

Comment 6 Jitka Plesnikova 2015-06-24 06:48:06 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.