Bug 1234651 - Remove unsupported alert-scripts/README.txt and alert-scripts/example.rb files from product distribution
Summary: Remove unsupported alert-scripts/README.txt and alert-scripts/example.rb file...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Build System
Version: JON 3.3.1
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: CR01
: JON 3.3.4
Assignee: Simeon Pinder
QA Contact: Sunil Kondkar
URL:
Whiteboard:
Depends On: 696658
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-22 23:12 UTC by Larry O'Leary
Modified: 2019-07-11 09:27 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 696658
Environment:
Last Closed: 2015-10-28 14:36:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 1492153 0 None None None Never
Red Hat Product Errata RHSA-2015:1947 0 normal SHIPPED_LIVE Important: Red Hat JBoss Operations Network 3.3.4 update 2015-10-28 18:36:15 UTC

Description Larry O'Leary 2015-06-22 23:12:38 UTC
The existence of these files is in error. JBoss ON does not support any JRuby wrapper or CLI implementation.

These files appear to be artifacts from the upstream alert-scriptlang server plug-in which was never complete and not even built as part of the upstream RHQ project. 

Please remove the contents of alert-scripts from the product distribution and future updates. 

Please be aware that because of the existence of this directory, it is possible users are using it to store their "real" CLI scripts. This means that the removal should be limited to the offending README.txt and example.rb files and the directory itself (alert-scripts) should only be removed if it is empty after the remove of those two files.

Based on Bug 696658 comment 1, we should probably proceed with caution in regards to the alert-scripts directory. It is unclear if this directory is actually being scanned for server plug-ins or not.

+++ This bug was initially created as a clone of Bug #696658 +++

We should keep the top level install directory relatively clean and not make it 
a dumping ground. There is a alert-scripts top level location that is related to the server-side scriptlang plugin. Is that even supported or working? I never used it and never tried it.

I don't think it warrants a top level directory for an example script and a readme. We should move that down into the etc/ directory.

--- Additional comment from John Mazzitelli on 2011-04-14 11:18:53 EDT ---

turns out this is more than just the location of samples/examples of alert scripts. This is the actual directory where the server side script looks for its scripts to run.

will leave this as is, but would like QA to test this feature. If the server side script doesn't work we should scrub this.

--- Additional comment from Mike Foley on 2011-09-09 14:23:00 EDT ---

i think that directory is associated with this experimental ruby plugin.

http://pilhuhn.blogspot.com/2009/12/new-experimental-ruby-script-plugin-for.html

--- Additional comment from Mike Foley on 2011-09-09 14:40:26 EDT ---

recommendation is to delete this directory, at least in the JON distribution.

--- Additional comment from Mike Foley on 2011-09-09 15:01:54 EDT ---

email sent to RHQ-Devel list to inquire about the original purpose and current usefulness of this directory...as follows:

Hi,

I am inquiring about the purpose of a top-level directory named "alert-scripts".    I am curious about its original purpose, and whether the directory is useful to anyone at this time.

There are two files in this directory, as follows:

    * README.txt  ... with the contents "This directory contains scripts for the scriptlang alert sender.
      Currently JRuby and JavaScript are supported."
    * example.rb .... which contains a Ruby script.

I think this directory is associated with an experimental Ruby script plugin described at this location:   http://www.rhq-project.org/display/RHQ/2009/12/08/New+experimental+%28Ruby%29+script+plugin

Does anyone utilize this Ruby Script plug-in?

The reason I ask is that there is some discussion around the removal of this directory.

Thanks,

Michael Foley


_______________________________________________
rhq-devel mailing list
rhq-devel.org
https://fedorahosted.org/mailman/listinfo/rhq-devel

Comment 2 Simeon Pinder 2015-10-09 04:40:12 UTC
Moving to ON_QA as available to test with the following build:
https://brewweb.devel.redhat.com/buildinfo?buildID=460382

 *Note: jon-server-patch-3.3.0.GA.zip maps to ER01 build of
 jon-server-3.3.0.GA-update-04.zip.

Comment 3 Sunil Kondkar 2015-10-12 10:47:42 UTC
Verified on Version :3.3.0.GA Update 04 Build Number :821a526:fa7b1a1

The files 'README.txt' and 'example.rb' are removed from jon-server-3.3.0.GA/alert-scripts folder and the entries are included in the file - jon-server-3.3.0.GA-update-04/.patched/removed-list.txt

Verified that the backup of the removed file exists in jon-server-3.3.0.GA/.patched/3.3.0.GA-update-04_10-09-15_06-56-21/.old/alert-scripts

Comment 5 errata-xmlrpc 2015-10-28 14:36:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1947.html


Note You need to log in before you can comment on or make changes to this bug.