Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/gnome-todo.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/gnome-todo-3.17.3-1.fc23.src.rpm Description: GNOME To Do is a small application to manage your personal tasks. It uses GNOME technologies, and so it has complete integration with the GNOME desktop environment. Fedora Account System Username: ignatenkobrain
Error while doing "fedora-review -b 1234829": Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.t2chBT + umask 022 + cd /builddir/build/BUILD + cd /builddir/build/BUILD + rm -rf gnome-todo-3.17.3 + /usr/bin/xz -dc /builddir/build/SOURCES/gnome-todo-3.17.3.tar.xz + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd gnome-todo-3.17.3 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + /usr/bin/git init -q /var/tmp/rpm-tmp.t2chBT: line 42: /usr/bin/git: No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.t2chBT (%prep) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.t2chBT (%prep) Child return code was: 1 EXCEPTION: Command failed. See logs for output. Do you need git as a BuildRequires if using "%autosetup -S git"? I haven't used it before, so I do not know the details.
Yes, I need BR:git. I forgot to add it. Can you add iit yourself? I will do it when iimport package.
It also seems like you are missing "BuildRequires: intltool". It is worth running the SRPM through mock to catch simple errors like these. After making that change, package review follows: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text This is a false positive, %license is being used correctly. - Mixed use of spaces and tabs (the "Requires:" line, probably best to just remove it) - INSTALL file in %doc. Not a big deal, but should be removed from the package. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/david/checkout/rpms/gnome-todo-review/review-gnome- todo/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: glib-compile-schemas is run in %postun and %posttrans if package has *.gschema.xml files. Note: gschema file(s) in gnome-todo [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gnome-todo-3.17.3-1.fc23.x86_64.rpm gnome-todo-3.17.3-1.fc23.src.rpm gnome-todo.x86_64: W: no-manual-page-for-binary gnome-todo gnome-todo.x86_64: W: install-file-in-docs /usr/share/doc/gnome-todo/INSTALL gnome-todo.x86_64: E: invalid-appdata-file /usr/share/appdata/org.gnome.Todo.appdata.xml gnome-todo.src:22: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 22) gnome-todo.src: W: invalid-url Source0: https://download.gnome.org/sources/gnome-todo/3.17/gnome-todo-3.17.3.tar.xz <urlopen error ('_ssl.c:574: The handshake operation timed out',)> 2 packages and 0 specfiles checked; 1 errors, 4 warnings. Rpmlint (debuginfo) ------------------- Checking: gnome-todo-debuginfo-3.17.3-1.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- gnome-todo-debuginfo.x86_64: W: invalid-url URL: https://git.gnome.org/browse/gnome-todo/ <urlopen error [Errno -5] No address associated with hostname> gnome-todo.x86_64: W: invalid-url URL: https://git.gnome.org/browse/gnome-todo/ <urlopen error [Errno -5] No address associated with hostname> gnome-todo.x86_64: W: no-manual-page-for-binary gnome-todo gnome-todo.x86_64: W: install-file-in-docs /usr/share/doc/gnome-todo/INSTALL 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- gnome-todo (rpmlib, GLIBC filtered): /bin/sh libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libcamel-1.2.so.53()(64bit) libdl.so.2()(64bit) libecal-1.2.so.18()(64bit) libedataserver-1.2.so.21()(64bit) libedataserverui-1.2.so.1()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgoa-1.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libical.so.1()(64bit) libicalss.so.1()(64bit) libicalvcal.so.1()(64bit) libm.so.6()(64bit) libnspr4.so()(64bit) libnss3.so()(64bit) libnssutil3.so()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpthread.so.0()(64bit) libsecret-1.so.0()(64bit) libsmime3.so()(64bit) libsoup-2.4.so.1()(64bit) libsqlite3.so.0()(64bit) libssl3.so()(64bit) libxml2.so.2()(64bit) rtld(GNU_HASH) Provides -------- gnome-todo: appdata() appdata(org.gnome.Todo.appdata.xml) application() application(org.gnome.Todo.desktop) gnome-todo gnome-todo(x86-64) Source checksums ---------------- https://download.gnome.org/sources/gnome-todo/3.17/gnome-todo-3.17.3.tar.xz : CHECKSUM(SHA256) this package : d676a549f757bc0df06ece09adac2df0810b081c68f74c47bd40aa9a6697434d CHECKSUM(SHA256) upstream package : d676a549f757bc0df06ece09adac2df0810b081c68f74c47bd40aa9a6697434d Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review --name gnome-todo Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
New Package SCM Request ======================= Package Name: gnome-todo Short Description: Personal task manager for GNOME Upstream URL: https://git.gnome.org/browse/gnome-todo/ Owners: ignatenkobrain amigadave Branches: InitialCC:
Git done (by process-git-requests).