Bug 123494 - "with" message in firstboot not marked for translation
Summary: "with" message in firstboot not marked for translation
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: firstboot
Version: 2
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brent Fox
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-05-18 21:17 UTC by Christian Rose
Modified: 2007-11-30 22:10 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-06-14 18:45:52 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Christian Rose 2004-05-18 21:17:31 UTC
Tested with Swedish.

In the firstboot "Display" screen, the're is an informative text
showing the monitor type and graphics adapter on the system. In my case:

"MAG DJ707 with Matrox Millennium G450"

The "with" is not translated. It's most likely not marked for
translation in the source.

The entire sentence should probably be marked for translation, e.g.

/* Translators: The first %s is the monitor make and model,
                the second %s is the graphics adapter make and model. */
g_printf (_("%s with %s"), monitor_name, adapter_name);

This is so that translators can alter the order of the arguments with
printf modifiers if the language requires a different order.

Comment 1 Brent Fox 2004-05-25 15:48:43 UTC
This string comes from system-config-display and the UI is just
plugged  into the firstboot parent window.  As far as I can tell, this
string is correctly marked for translation:

from xConfDialog.py:
   label.set_text(_("%s with %s")%(self.state.get_monitor_name(),
self.state.get_videocard_name()))

And it looks like the string is translated in sv.po:
msgid "%s with %s"
msgstr "%s med %s"

I don't have my test machines at the moment, so I can't try to
reproduce this myself.  I can't explain why the translation isn't
getting shown.

Comment 2 Brent Fox 2004-06-14 18:45:52 UTC
Ah, I see the problem now.  The message is translated in the po files
but I wasn't setting the text domain correctly in the python files. 
Should be fixed in cvs now.  1.0.15-2 will contain the fix once I
rebuild the package.

Comment 3 Christian Rose 2004-06-19 21:32:39 UTC
Thanks a bunch!


Note You need to log in before you can comment on or make changes to this bug.