Already existing and newly created custom buttons are not displaying after an upgrade from 5.3 to 5.4 I followed the upgrade process outlined in this knowledge base article: https://access.redhat.com/articles/1435433 I can provide access to the environment since it is internal to Red Hat (The SA Lab demo environment.)
Note from testing: Moving the slider bar in either direction will cause the custom buttons to be displayed. The same is true for any window resizing. Still working on a fix.
Resizing fixes it. Logging out/in after the window needs to be resized again. Exact same behavior you are seeing Jan.
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/b568c8eb3de924a802e9b922575f84a437db200e commit b568c8eb3de924a802e9b922575f84a437db200e Author: Laura Galis <lgalis> AuthorDate: Wed Jul 1 15:50:40 2015 -0400 Commit: Laura Galis <lgalis> CommitDate: Wed Jul 8 09:28:36 2015 -0400 VM's Custom Button Groups on the second line are not displayed When having multiple VM custom button groups that would casue them to be displayed on the next line, they are not visible until the window is resized. This change modifies the height for the cell in the layout to allow for the initial display. https://bugzilla.redhat.com/show_bug.cgi?id=1234987 app/views/layouts/_dhtmlxlayout_explorer.html.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/c50dd69394c90f2a8947c2e108dac9d077602e02 commit c50dd69394c90f2a8947c2e108dac9d077602e02 Author: Laura Galis <lgalis> AuthorDate: Mon Jul 6 11:28:03 2015 -0400 Commit: Laura Galis <lgalis> CommitDate: Wed Jul 8 09:28:37 2015 -0400 VM's Custom Button Groups on the second line are not displayed When having multiple VM custom button groups that would cause them to be displayed on the next line, they are not visible until the window is resized. Modify the function that adjusts the height of the taskbar as needed so that the custom buttons in the second row are visible . https://bugzilla.redhat.com/show_bug.cgi?id=1234987 app/assets/javascripts/miq_dhtmlxlayout.js | 2 +- app/assets/javascripts/miq_dhtmlxtoolbar.js | 1 + app/presenters/explorer_presenter.rb | 3 ++- app/views/layouts/_dhtmlxlayout_explorer.html.haml | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-)
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/f6f4282f1b110c167fd1105e0b3d58cffc008596 commit f6f4282f1b110c167fd1105e0b3d58cffc008596 Author: Laura Galis <lgalis> AuthorDate: Mon Jul 13 09:42:07 2015 -0400 Commit: Laura Galis <lgalis> CommitDate: Mon Jul 13 10:18:43 2015 -0400 Custom button fix for https://github.com/ManageIQ/manageiq/pull/3365 causes js exception in non-explorer tabs https://bugzilla.redhat.com/show_bug.cgi?id=1234987 app/assets/javascripts/miq_dhtmlxtoolbar.js | 3 +++ 1 file changed, 3 insertions(+)
New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=63a5c564dc5fccc24b728f14d9ba3c45122bd824 commit 63a5c564dc5fccc24b728f14d9ba3c45122bd824 Author: Laura Galis <lgalis> AuthorDate: Tue Jul 14 10:57:55 2015 -0400 Commit: Laura Galis <lgalis> CommitDate: Tue Jul 14 10:57:55 2015 -0400 Custom Buttons not visible in second row When having multiple VM custom button groups that would cause them to be displayed on the next line, they are not visible until the window is resized. This change modifies the height for the cell in the layout to allow for the initial display. https://bugzilla.redhat.com/show_bug.cgi?id=1234987 vmdb/app/assets/javascripts/miq_dhtmlxlayout.js | 2 +- vmdb/app/assets/javascripts/miq_dhtmlxtoolbar.js | 4 ++++ vmdb/app/presenters/explorer_presenter.rb | 3 ++- 3 files changed, 7 insertions(+), 2 deletions(-)
New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=654b51bc5aa80de47df85e549c258d43f44e594c commit 654b51bc5aa80de47df85e549c258d43f44e594c Merge: be4966e 63a5c56 Author: Dan Clarizio <dclarizi> AuthorDate: Tue Jul 14 18:03:44 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Jul 14 18:03:44 2015 -0400 Merge branch '5.4.z_custom_buttons_not_visible_in_second_row' into '5.4.z' Custom Buttons not visible in second row @dclarizio When having multiple VM custom button groups that would cause them to be displayed on the next line, they are not visible until the window is resized. This change modifies the height for the cell in the layout to allow for the initial display. https://bugzilla.redhat.com/show_bug.cgi?id=1234987 See merge request !174 vmdb/app/assets/javascripts/miq_dhtmlxlayout.js | 2 +- vmdb/app/assets/javascripts/miq_dhtmlxtoolbar.js | 4 ++++ vmdb/app/presenters/explorer_presenter.rb | 3 ++- 3 files changed, 7 insertions(+), 2 deletions(-)
There still exists conditions whens not all of the buttons are displayed. Generally speaking, as the window gets narrower, the divider custom_tb does indeed shift to the second row. However, as the screen gets even narrower, each right-most button will disappear and there is neither a way to select those buttons nor even tell if they exist, including the center_buttons_div if the narrowing is taken to the extreme. I tried https://10.8.59.195/vm_infra/explorer with both Firefox and Chrome with the same results. Perhaps the DIV should add overflow-x: scroll; or something like that. This appliance will be around for a while. Here is a youtube video if you want to see it instead. Might be easier. https://youtu.be/2mVzVmLyybA
I think I'll keep these videos on mojo for security reasons. Ignore the above youtube link as I removed it. https://mojo.redhat.com/videos/929638
Hi Jeff, We currently require a 1280 width, and currently allow only 2 rows of custom buttons. This will change going forward, as we switch to using patternfly toolbars. The problem that is addressed in this BZ is the fact that with a certain number of custom buttons, the ones that would be displayed in the second row for that window size and vertical scrollbar position, are not being displayed ( until the vertical scrollbar is moved - in any direction, or the window resized). Thanks, Laura
Thanks Laura. Verified at 1280 width.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2015:2551
Added Polarion test case