Bug 1235035

Description of problem:

Updating the cups package can break the configuration files for cups, and then when the post-install script tries to restart cups upon update the service fails to start.  A post-install scriptlet in the RPM moves a configuration setting that it should not causing the daemon to not start due to configuration error.

Version-Release number of selected component (if applicable):

cups-1.6.3-17.el7_1.1.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Configure cups to run as a network print server
2. set AccessLogLevel all in cupsd.conf (for say, some basic page accounting)
3. update cups

Actual results:
updating cups moves the AccessLogLevel paraemeter into cups-files.conf, which the daemon reads as a configuration error and fails to start.

Expected results:
cups daemon is restarted after update

Additional info:

When extracted via rpm, the first post install scriptlet contains:
-- BEGIN PASTE --
# Deal with config migration due to CVE-2012-5519 (STR #4223)
IN=/etc/cups/cupsd.conf
OUT=/etc/cups/cups-files.conf
copiedany=no
for keyword in AccessLog CacheDir ConfigFilePerm        \
    DataDir DocumentRoot ErrorLog FatalErrors           \
    FileDevice FontPath Group LogFilePerm               \
    LPDConfigFile PageLog Printcap PrintcapFormat       \
    RemoteRoot RequestRoot ServerBin ServerCertificate  \
    ServerKey ServerRoot SMBConfigFile StateDir         \
    SystemGroup SystemGroupAuthKey TempDir User; do
    if ! [ -f "$IN" ] || ! /bin/grep -iq ^$keyword "$IN"; then continue; fi
    copy=yes
    if /bin/grep -iq ^$keyword "$OUT"; then
        if [ "`/bin/grep -i ^$keyword "$IN"`" ==        \
             "`/bin/grep -i ^$keyword "$OUT"`" ]; then
            copy=no
        else
            /bin/sed -i -e "s,^$keyword,#$keyword,i" "$OUT" || :
        fi
    fi
    if [ "$copy" == "yes" ]; then
        if [ "$copiedany" == "no" ]; then
            (cat >> "$OUT" <<EOF
-- END PASTE --

the first 'keyword' in the for clause will also grab the AccessLogLevel parameter if it is set in cupsd.conf, remove it, and improperly place it in cups-files.conf .