Bug 1235662 - [host-update-manager] Checking for updates confuse with host installation and spams audit_log
Summary: [host-update-manager] Checking for updates confuse with host installation and...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-3.6.0-rc
: 3.6.0
Assignee: Moti Asayag
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-25 13:01 UTC by Jiri Belka
Modified: 2016-02-10 12:55 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-10 12:55:22 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-3.6.0+
ylavi: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)
engine.log (1019.07 KB, application/x-gzip)
2015-06-25 13:01 UTC, Jiri Belka
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 43212 0 master ABANDONED core: Reduce host check-updates noise Never
oVirt gerrit 43255 0 None None None Never

Description Jiri Belka 2015-06-25 13:01:38 UTC
Created attachment 1043099 [details]
engine.log

Description of problem:

Two things:

1. when host updates are being checked a user is confused that an installation is going on:

2015-06-25 14:48:20,227 INFO  [org.ovirt.engine.core.bll.hostdeploy.InstallerMessages] (DefaultQuartzScheduler_Worker-51) [] Installation 'dell-r210ii-04.rhev.lab.eng.brq.redhat.com': Connected to host dell-r210ii-04.rhev.lab.eng.brq.redhat.com with SSH key fingerprint: 96:91:99:db:87:23:24:8f:fb:2e:3f:96:c8:17:9c:ca
2015-06-25 14:48:20,238 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (DefaultQuartzScheduler_Worker-51) [] Correlation ID: 4e1e7d80, Call Stack: null, Custom Event ID: -1, Message: Installing Host dell-r210ii-04.rhev.lab.eng.brq.redhat.com. Connected to host dell-r210ii-04.rhev.lab.eng.brq.redhat.com with SSH key fingerprint: 96:91:99:db:87:23:24:8f:fb:2e:3f:96:c8:17:9c:ca.
2015-06-25 14:48:20,306 INFO  [org.ovirt.engine.core.bll.hostdeploy.VdsDeployBase] (DefaultQuartzScheduler_Worker-51) [] Installation of dell-r210ii-04.rhev.lab.eng.brq.redhat.com. Executing command via SSH umask 0077; MYTMP="$(TMPDIR="${OVIRT_TMPDIR}" mktemp -d -t ovirt-XXXXXXXXXX)"; trap "chmod -R u+rwX \"${MYTMP}\" > /dev/null 2>&1; rm -fr \"${MYTMP}\" > /dev/null 2>&1" 0; tar --warning=no-timestamp -C "${MYTMP}" -x &&  "${MYTMP}"/ovirt-host-mgmt DIALOG/dialect=str:machine DIALOG/customization=bool:True < /var/cache/ovirt-engine/ovirt-host-deploy.tar
2015-06-25 14:48:20,314 INFO  [org.ovirt.engine.core.uutils.ssh.SSHDialog] (DefaultQuartzScheduler_Worker-51) [] SSH execute 'root.lab.eng.brq.redhat.com' 'umask 0077; MYTMP="$(TMPDIR="${OVIRT_TMPDIR}" mktemp -d -t ovirt-XXXXXXXXXX)"; trap "chmod -R u+rwX \"${MYTMP}\" > /dev/null 2>&1; rm -fr \"${MYTMP}\" > /dev/null 2>&1" 0; tar --warning=no-timestamp -C "${MYTMP}" -x &&  "${MYTMP}"/ovirt-host-mgmt DIALOG/dialect=str:machine DIALOG/customization=bool:True'

and

2015-06-25 14:48:20,836 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (VdsDeploy) [] Correlation ID: 4e1e7d80, Call Stack: null, Custom Event ID: -1, Message: Installing Host dell-r210ii-04.rhev.lab.eng.brq.redhat.com. Stage: Initializing.

There should be clear difference between installation and just check for updates. Horror... "OMG it is installation my host now, huuuaa"

2. Spam, spam

There's _17_ events with 'Installing Host $host', that's too much and it does not have any sense in context of updates check
# grep '14:48.*Installing.*dell-r210ii-04' /var/log/ovirt-engine/engine.log | wc -l
17

I doubt anybody would care about each of such line except one with clear info that there are updates.


Version-Release number of selected component (if applicable):
ovirt-engine-backend-3.6.0-0.0.master.20150519172219.git9a2e2b3.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. have a host with updates available (vdsm etc..)
2. wait for next updates check
3. inspect engine.log and Events/audit_log db table

Actual results:
- confusion - is it (re)installing my host? Huh?
- spam spam spam

Expected results:
- be clear what's going on, it's just check (end user doesn't care about internals - host deploy)
- just show useful event messages in check updates context

Additional info:

Comment 1 Lukas Svaty 2016-01-21 11:51:21 UTC
1 INFO log on check for updates:

2016-01-21 12:42:16,876 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (DefaultQuartzScheduler_Worker-50) [] Correlation ID: null, Call Stack: null, Custom Event ID: -1, Message: Host yellow has available updates: vdsm,vdsm-cli.

tested in rhevm-3.6.2.6-0.1.el6.noarch


Note You need to log in before you can comment on or make changes to this bug.