Bug 1235668 - [host-update-manager] Host available packages list leaks defined packages dependencies
Summary: [host-update-manager] Host available packages list leaks defined packages dep...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-3.6.0-rc
: 3.6.0
Assignee: Moti Asayag
QA Contact: Jiri Belka
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-25 13:12 UTC by Jiri Belka
Modified: 2016-02-10 19:11 UTC (History)
8 users (show)

Fixed In Version: 3.6.0-4_alpha3
Clone Of:
Environment:
Last Closed: 2015-11-04 11:46:11 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-3.6.0+
ylavi: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 43378 0 master MERGED engine: Print pre-defined available packages Never

Description Jiri Belka 2015-06-25 13:12:54 UTC
Description of problem:

IMO it doesn't make sense to mention all dependent packages ready for update with vdsm, vdsm-cli. What would we do if deps would be long? Currently the list even doesn't fit (in Events) onto the screen. I see no benefit to list mom, vdsm-xmlrpc etc...

engine=# select option_name,option_value from vdc_options where option_name = 'PackageNamesForCheckUpdate';
        option_name         | option_value  
----------------------------+---------------
 PackageNamesForCheckUpdate | vdsm,vdsm-cli
(1 row)

engine=# select option_name,option_value from vdc_options where option_name = 'UserPackageNamesForCheckUpdate';
          option_name           | option_value 
--------------------------------+--------------
 UserPackageNamesForCheckUpdate | 
(1 row)

# grep 'Available packages' /var/log/ovirt-engine/engine.log | tail -n1
2015-06-25 15:06:51,078 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (VdsDeploy) [] Correlation ID: 23e39668, Call Stack: null, Custom Event ID: -1, Message: Installing Host dell-r210ii-04.rhev.lab.eng.brq.redhat.com. Available packages for update: mom-0.4.5-0.0.master.20150623182142.gitc48a880.el7,vdsm-4.17.0-1038.git438679a.el7,vdsm-cli-4.17.0-1038.git438679a.el7,vdsm-infra-4.17.0-1038.git438679a.el7,vdsm-jsonrpc-4.17.0-1038.git438679a.el7,vdsm-python-4.17.0-1038.git438679a.el7,vdsm-xmlrpc-4.17.0-1038.git438679a.el7,vdsm-yajsonrpc-4.17.0-1038.git438679a.el7.

Just honor 'PackageNamesForCheckUpdate' and 'UserPackageNamesForCheckUpdate' and do not list packages' deps.

Version-Release number of selected component (if applicable):
ovirt-engine-backend-3.6.0-0.0.master.20150519172219.git9a2e2b3.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. have rpms including vdsm/vdsm-cli available for a host (including deps)
2. check Events/audit_log db table if the packages list mentions even packages deps or just vdsm/vdsm-cli (and user defined if applicable)
3.

Actual results:
available packages for update list even packages' deps

Expected results:
do not list deps

Additional info:

Comment 1 Moti Asayag 2015-07-09 05:31:25 UTC
Would a general message of "There are available updates for host HostName." will be enough and the entire list will be printed to the engine.log ? 

This will have a unified format for both (in the event-log) for ovirt-node and plan hosts, and also will spare the noise of the predefined list of packages to repeatability be printed to the log.

Comment 2 Jiri Belka 2015-07-09 07:27:50 UTC
IMO a sentence should just mention there are available updates of $PackageNamesForCheckUpdate and $UserPackageNamesForCheckUpdate for host $hostname.

Everything else is too much in my opinion. And I doubt anybody would care for  deps in themselves, this is YUM work.

Comment 3 Jiri Belka 2015-10-16 11:11:03 UTC
ok, rhevm-backend-3.6.0-0.18.el6.noarch

tested with 'UserPackageNamesForCheckUpdate: tuned' only and only 'tuned' was listed, thus ok.
	
Oct 16, 2015 12:43:28 PM
Host dell-r210ii-13.rhev.lab.eng.brq.redhat.com has available updates: tuned.

Comment 4 Jiri Belka 2015-10-16 11:11:59 UTC
(tuned upgrade would pull python-perf as a dep and it was not correctly listed.)

Comment 5 Sandro Bonazzola 2015-11-04 11:46:11 UTC
oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue.
If problems still persist, please open a new BZ and reference this one.


Note You need to log in before you can comment on or make changes to this bug.