Bug 1235689 - Custom Service Task is losing information after round-tripping from Web Designer to JBDS
Summary: Custom Service Task is losing information after round-tripping from Web Desig...
Keywords:
Status: CLOSED EOL
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: Eclipse Tooling
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
: ---
Assignee: Kris Verlaenen
QA Contact: Jozef Marko
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-25 13:48 UTC by Anton Giertli
Modified: 2020-03-27 20:01 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-27 20:01:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
[0] kjar project for reproducing the issue (23.64 KB, application/zip)
2015-06-25 13:48 UTC, Anton Giertli
no flags Details

Description Anton Giertli 2015-06-25 13:48:44 UTC
Created attachment 1043116 [details]
[0] kjar project for reproducing the issue

Description of problem:

If you create process in business-central which includes custom Work Items then importing this process into JBDS will cause lost information in the Custom Work Item - i.e. On Entry / On Exit sections are not present anymore.


Version-Release number of selected component (if applicable):

6.1.1
How reproducible:
always

Steps to Reproduce:
1. Create Project in business-central and add process which includes custom work item - i.e.
Start -> LOG -> End and add some script into On Entry script of this work item
2. git clone the repository and import the mavenized project into the JBDS
3. Open the process  - the On Entry script is no longer accessible

OR with the attached zip file:

1) extract and import the project into the JBDS
2) Open the process - Log and Rest tasks were created in Web Designer. WS was created in JBDS. As you can see, Log and Rest does not include "Custom Task" tab after opening Properties. WS includes this.

Actual results:
On Entry / On Exit script is lost after importing process created in business-central into the JBDS

Expected results:
No information is lost after process import from business-central into JBDS

Additional info:

When the Work Items tasks created in business-central are opened in the JBDS, the task includes only two tabs:

General
I/O Parameter

However, if you put custom work item on the canvas directly from the JBDS designer, it also includes:

Custom Task tab.

I have checked the generated XML:

Web Designer:
<bpmn2:task id="_F076316B-BC8E-4264-9C02-49F4302638FA" drools:selectable="true" drools:taskName="Rest" name="REST">

JBDS Designer:
<bpmn2:task id="Task_1" drools:taskName="WebService" drools:displayName="WS" drools:icon="defaultservicenodeicon.png" name="WS">

The different attribute is drools:displayName.

If I add this attribute manually to the task generated via Web Designer, then it's correctly recognized in the JBDS and Custom Task section is visible again.

Document URL: 

Section Number and Name: 

Describe the issue: 

Suggestions for improvement: 

Additional information: 


Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Kris Verlaenen 2015-09-07 13:56:09 UTC
Bob, does the BPMN2 modeler depend on the drools:displayname attribute being there?  I guess it should rely on drools:taskName to detect custom work item nodes, drools:displayname is optional.

Comment 3 Robert (Bob) Brodt 2015-09-10 18:09:58 UTC
Actually, the editor requires drools:taskName to be defined in the WID file. In this example, all WID definitions have only "name" and "displayName". Which is correct, "taskName" or "name"?

Comment 4 Robert (Bob) Brodt 2015-09-10 18:38:55 UTC
Never mind, I found the problem :)

There was still one area where "displayName" was used (incorrectly) to select whether or not the "Custom Task" tab is rendered. This tab contains the On Entry/Exit scripts.

Comment 5 Robert (Bob) Brodt 2015-09-11 17:56:12 UTC
Fixed with build 1.1.4.201509111742 (Luna) and 1.2.1.201509111741 (Mars)

Comment 6 Jozef Marko 2015-10-07 10:15:05 UTC
Verified on:
jbds-9.0.0.CR2_jbdsis-9.0.0.Alpha2
BPMN2 Modeler 1.2.1.201509111741


Note You need to log in before you can comment on or make changes to this bug.