Spec URL: http://marcdeop.fedorapeople.org/vim-vcscommand.spec SRPM URL: http://marcdeop.fedorapeople.org/vim-vcscommand-1.99.47-1.fc21.noarch.rpm Description: VIM 7 plugin useful for manipulating files controlled by CVS, SVN, SVK, git, bzr, and hg within VIM, including committing changes and performing diffs using the vimdiff system. Keywords: bazaar bzr cvs CVS cvscommand git mercurial hg subversion SVN svk vcscommand Fedora Account System Username:marcdeop
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: vim-vcscommand-1.99.47-1.fc20.noarch.rpm vim-vcscommand-1.99.47-1.fc20.src.rpm vim-vcscommand.noarch: W: spelling-error Summary(en_US) hg -> Hg, jg, hf vim-vcscommand.noarch: W: spelling-error Summary(en_US) bzr -> bar, brr, bur vim-vcscommand.noarch: W: summary-not-capitalized C vim CVS/SVN/SVK/git/hg/bzr integration plugin vim-vcscommand.noarch: W: spelling-error %description -l en_US bzr -> bar, brr, bur vim-vcscommand.noarch: W: spelling-error %description -l en_US hg -> Hg, jg, hf vim-vcscommand.noarch: W: spelling-error %description -l en_US vimdiff -> vim diff, vim-diff, diff vim-vcscommand.noarch: W: spelling-error %description -l en_US cvs -> cs, vs, cos vim-vcscommand.noarch: W: spelling-error %description -l en_US cvscommand -> commando, command vim-vcscommand.noarch: W: spelling-error %description -l en_US svk -> Sven vim-vcscommand.noarch: E: description-line-too-long C VIM 7 plugin useful for manipulating files controlled by CVS, SVN, SVK, git, bzr, and hg within VIM, including committing changes and performing diffs using the vimdiff system. vim-vcscommand.noarch: E: description-line-too-long C Keywords: bazaar bzr cvs CVS cvscommand git mercurial hg subversion SVN svk vcscommand vim-vcscommand.noarch: W: non-standard-group Application/Editors vim-vcscommand.noarch: W: incoherent-version-in-changelog 1.99.47 ['1.99.47-1.fc20', '1.99.47-1'] vim-vcscommand.noarch: W: dangerous-command-in-%postun rm vim-vcscommand.src: W: spelling-error Summary(en_US) hg -> Hg, jg, hf vim-vcscommand.src: W: spelling-error Summary(en_US) bzr -> bar, brr, bur vim-vcscommand.src: W: summary-not-capitalized C vim CVS/SVN/SVK/git/hg/bzr integration plugin vim-vcscommand.src: W: spelling-error %description -l en_US bzr -> bar, brr, bur vim-vcscommand.src: W: spelling-error %description -l en_US hg -> Hg, jg, hf vim-vcscommand.src: W: spelling-error %description -l en_US vimdiff -> vim diff, vim-diff, diff vim-vcscommand.src: W: spelling-error %description -l en_US cvs -> cs, vs, cos vim-vcscommand.src: W: spelling-error %description -l en_US cvscommand -> commando, command vim-vcscommand.src: W: spelling-error %description -l en_US svk -> Sven vim-vcscommand.src: E: description-line-too-long C VIM 7 plugin useful for manipulating files controlled by CVS, SVN, SVK, git, bzr, and hg within VIM, including committing changes and performing diffs using the vimdiff system. vim-vcscommand.src: E: description-line-too-long C Keywords: bazaar bzr cvs CVS cvscommand git mercurial hg subversion SVN svk vcscommand vim-vcscommand.src: W: non-standard-group Application/Editors vim-vcscommand.src: W: invalid-url Source0: vcscommand-1.99.47.zip 2 packages and 0 specfiles checked; 4 errors, 23 warnings. Rpmlint (installed packages) ---------------------------- vim-vcscommand.noarch: W: spelling-error Summary(en_US) hg -> Hg, jg, hf vim-vcscommand.noarch: W: spelling-error Summary(en_US) bzr -> bar, brr, bur vim-vcscommand.noarch: W: summary-not-capitalized C vim CVS/SVN/SVK/git/hg/bzr integration plugin vim-vcscommand.noarch: W: spelling-error %description -l en_US bzr -> bar, brr, bur vim-vcscommand.noarch: W: spelling-error %description -l en_US hg -> Hg, jg, hf vim-vcscommand.noarch: W: spelling-error %description -l en_US vimdiff -> vim diff, vim-diff, diff vim-vcscommand.noarch: W: spelling-error %description -l en_US cvs -> cs, vs, cos vim-vcscommand.noarch: W: spelling-error %description -l en_US cvscommand -> commando, command vim-vcscommand.noarch: W: spelling-error %description -l en_US svk -> Sven vim-vcscommand.noarch: E: description-line-too-long C VIM 7 plugin useful for manipulating files controlled by CVS, SVN, SVK, git, bzr, and hg within VIM, including committing changes and performing diffs using the vimdiff system. vim-vcscommand.noarch: E: description-line-too-long C Keywords: bazaar bzr cvs CVS cvscommand git mercurial hg subversion SVN svk vcscommand vim-vcscommand.noarch: W: non-standard-group Application/Editors vim-vcscommand.noarch: W: incoherent-version-in-changelog 1.99.47 ['1.99.47-1.fc20', '1.99.47-1'] vim-vcscommand.noarch: W: dangerous-command-in-%postun rm 1 packages and 0 specfiles checked; 2 errors, 12 warnings. Requires -------- vim-vcscommand (rpmlib, GLIBC filtered): /bin/sh vim vim-filesystem Provides -------- vim-vcscommand: vim-vcscommand Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/bin/fedora-review --rpm-spec -n /home/makerpm/rpmbuild/SRPMS/vim-vcscommand-1.99.47-1.fc21.src.rpm Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Some informal things to mention: * Please remove Group: line, it's obsolete and not needed. * Where do you have the sources zip from? Please provide an URL or at least comment in the spec file how you create it. * Your description line is too long. Insert some line feeds to break it into several lines. * Use 'cp -p' to preserve timestamps. * Remove %doc, it is not necessary: %doc %{vimfiles_root}/doc/* * Reference the complete individual folders: remove the star ('*') at the end of the %files lines but keep the trailing slashes ('/') at the pathes. * The name of your linked SRPM file is wrong. Why is there no .srpm suffix? * Please provide a koji scratch build for rawhide. You could test also for other targets you plan a separate package for.
(In reply to Raphael Groner from comment #2) > * Please remove Group: line, it's obsolete and not needed. I plan on including this on EPEL as well, I think it is still useful on Red Hat 6. > * Where do you have the sources zip from? Please provide an URL or at least > comment in the spec file how you create it. This was a mistake, I linked to the rpm instead of the src.prm: http://marcdeop.fedorapeople.org/vim-vcscommand-1.99.47-1.fc21.src.rpm > * Your description line is too long. Insert some line feeds to break it into > several lines. Shortened to less than 80 characters per line > * Use 'cp -p' to preserve timestamps. -a stands for archive which does already preserve the timestamps > * Remove %doc, it is not necessary: %doc %{vimfiles_root}/doc/* Why is this required? > * Reference the complete individual folders: remove the star ('*') at the > end of the %files lines but keep the trailing slashes ('/') at the pathes. Fixed. > > * The name of your linked SRPM file is wrong. Why is there no .srpm suffix? Updating the links shortly
Are you interested in a review swap? Maybe bug #1225231 or bug #1224800 are for you.
(In reply to Raphael Groner from comment #2) > * Reference the complete individual folders: remove the star ('*') at the > end of the %files lines but keep the trailing slashes ('/') at the pathes. I think by doing this, you are causing the package to own the directories, which is in contradiction with FPG, because the directories are already owned by vim-filesystem package.
A few notes on the spec: License tag is wrong, it must contain license short name. The license of the project is actually MIT. See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names https://fedoraproject.org/wiki/Licensing:MIT?rd=Licensing/MIT#Modern_Style_with_sublicense No URL for Source0, you should mention it in comment or you can use something like this: http://www.vim.org/scripts/download_script.php?src_id=19809#/%{name}-%{version}.zip See: https://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs Correct group name is Applications/Editors. See: https://fedoraproject.org/wiki/RPMGroups Changelog entry should include release number. See: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs Are you interested in full review?
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.