Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1236021

Summary: Metrics summary graph is misleading
Product: [JBoss] JBoss Operations Network Reporter: bkramer <bkramer>
Component: UIAssignee: Josejulio Martínez <jmartine>
Status: CLOSED ERRATA QA Contact: Hayk Hovsepyan <hhovsepy>
Severity: medium Docs Contact:
Priority: medium    
Version: JON 3.3.0CC: fbrychta, hhovsepy, jmartine, loleary, mithomps, spinder
Target Milestone: ER02Keywords: Triaged
Target Release: JON 3.3.8   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-16 18:44:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1236022    
Bug Blocks:    
Attachments:
Description Flags
screen shots none

Description bkramer 2015-06-26 11:18:39 UTC
Created attachment 1043472 [details]
screen shots

Description of problem:
Summary graph line will drop to 0 in between two collection point although metrics value is constant and not equal to 0. 

Version-Release number of selected component (if applicable):
JBoss ON 3.3.0

How reproducible:
Always

Steps to Reproduce:
1. Add to JBoss ON inventory RHQ Server resource (if it's not added already);
2. From JBoss ON UI -> navigate to JBossAS7 Standalone Servers -> RHQ Server resource -> Subsystems -> Connector -> datasources -> DataSource(Standalone) -> Monitoring -> Schedule
3. Change Max Pool Size collection period from 4h to 20 minutes;
4. After an hour, navigate to DataSource(Standalone) resource -> Monitoring -> Metrics -> and click on Max Pool Size to open a graph


Actual results:
Summary graph line is represented with spikes at the collection points but then this line will drop to 0 although the value of this metric is constant and equal 5 by default.

Expected results:
Graph that clearly shows metric value at the collection point and maybe a dotted line in between two collection points (that would show there was no other collections in between).

The other suggestions for the graph:

a) a bar at the measurement time (JON does this on other graphs)
b) a simple dot at the measurement time, no connecting lines
c) a dot at the measurement time, dots are connected with a line but the dot is so large that is clear that the line is based on these dots and no other measurements support the line


Additional info:
See attached screen shots - 01461311.zip

Comment 6 Mike Thompson 2016-06-04 09:00:06 UTC
@Filip, the chart renders the values it gets. So some zero values must be presented to it. The best fix would be to print out the data before and verify there are zeroes and then apply a small transformation to the data.

Comment 7 Larry O'Leary 2016-06-09 20:16:47 UTC
@Mike, in this case the values are 0 but that is because nodata=true. I think the issue here is that the old graphs are being used for compatible group metric charts. See the attached screen-shot.

Specifically, the chart being displayed is of the "max pool size setting" metric for a compatible group of type DataSource. This graph shows 20 for each collected value and 0 for each data point in where there is no value. 

For the resource metric graph the "nodata" values are depicted in a way that does not show they are 0 but that they are not present. Whereas the group metric graph shows 0 for these same values.

You can see the same issue in a stock JBoss ON installation which has the RHQ Server resource imported into inventory -- assuming enough time has passed to collect 4 or more hours have passed to collect at least one data point. This can be seen by going to the auto group JBossAS7 Standalone Servers / EAP (127.0.0.1:6990) RHQ Server / Subsystems / Connector / datasources / DataSource (Standalone) > Monitoring >> Metrics and then clicking "Max Pool Size setting" and setting interval to 8+ hours.

For this group metric graph, debug data does not include data values.

Is this something that can be addressed?

Comment 12 Josejulio Martínez 2017-01-26 05:41:06 UTC
commit 5002addc6b4c9fd83a434e51811b39e563bebbf4
Merge: 7367d0d 3ce4347
Author: Ruben Vargas <ruben.vp8510>
Date:   Wed Jan 25 14:25:46 2017 -0600

    Merge pull request #289 from josejulio/bugs/1236021
    
    Bug 1236021 - Adds a circle to non NAN measurements.

commit 3ce43470c053ef090f2371dab5edb57445737edc
Author: Josejulio Martínez <jmartine>
Date:   Wed Jan 25 12:35:46 2017 -0600

    Prevents javascript errors when the measurementList is empty.

commit ea741f324349816fa4418fd8647c7013d1b972cc
Author: Josejulio Martínez <jmartine>
Date:   Wed Jan 25 12:34:35 2017 -0600

    Bug 1236021 - Adds a circle to non NAN measurements.

Comment 14 Simeon Pinder 2017-01-27 06:16:23 UTC
Moving to ON_QA as available to test with the following brew build:
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=535315

NOTE: jon-server-patch-3.3.0.GA.zip maps to jon-server-3.3.0.GA-update-08.zip whic is JON 3.3.8 ER02 build.

Comment 15 Hayk Hovsepyan 2017-02-01 14:18:51 UTC
Verified on JON 3.3.8 ER02 build.

It shows circle on not NAN measurements and is clear that line is based on that circles.

Comment 17 errata-xmlrpc 2017-02-16 18:44:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2017-0285.html