Bug 1236303 - drm/i915 - PSR flicker
Summary: drm/i915 - PSR flicker
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: xorg-x11-drv-intel
Version: 22
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Adam Jackson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-27 14:53 UTC by ivan
Modified: 2022-02-01 16:41 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-07-19 20:11:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
1/2 - unmask LPSP patch (1.99 KB, patch)
2015-07-07 16:45 UTC, Rodrigo Vivi
no flags Details | Diff
2/2 - increse idle frames (1.74 KB, application/mbox)
2015-07-07 16:48 UTC, Rodrigo Vivi
no flags Details

Description ivan 2015-06-27 14:53:49 UTC
problem: screen flickers when enabling PSR (i915.enable_psr=1)

laptop: lenovo thinkpad t450s with FHD IPS screen.

fully updated f22 (as of 2015-06-17):
kernel-4.0.5-300.fc22.x86_64
xorg-x11-drv-intel-2.99.917-12.20150615.fc22.x86_64

kernel options: pcie_aspm=force nmi_watchdog=0 i915.enable_psr=0 drm.vblankoffdelay=1 i915.enable_fbc=1 i915.lvds_downclock=1 acpi_osi=Linux acpi=force acpi_enforce_resources=lax

(flickering also happens with most of those options removed).

chipset:

00:02.0 VGA compatible controller: Intel Corporation Broadwell-U Integrated Graphics (rev 09) (prog-if 00 [VGA controller])
        Subsystem: Lenovo Device 5036
        Flags: bus master, fast devsel, latency 0, IRQ 45
        Memory at e0000000 (64-bit, non-prefetchable) [size=16M]
        Memory at d0000000 (64-bit, prefetchable) [size=256M]
        I/O ports at 3000 [size=64]
        Expansion ROM at <unassigned> [disabled]
        Capabilities: [90] MSI: Enable+ Count=1/1 Maskable- 64bit-
        Capabilities: [d0] Power Management version 2
        Capabilities: [a4] PCI Advanced Features
        Kernel driver in use: i915
        Kernel modules: i915


Flickering only happens when something is updated on the display (eg. mouse cursor, web page loading, ...). And when it does, the following drm debug message shows up:

[drm:drm_atomic_set_fb_for_plane] Set [FB:54] for plane state ffff88032a869540

I tried to enable/disable power saving features as was suggested somewhere else, tried to set drm.atomic=1 (since the debug msg had something to do with atomic), and quite a few other combinations (kernel options, ...), but still no luck.

Comment 1 ivan 2015-06-27 19:51:55 UTC
re- kernel boot options:
- i915.enable_psr=1 obviously (copy/pasted a previous grub kernel line)
- flickering is present without any of the options mentioned above. (= standard fedora kernel defaults + i915.enable_psr=1).

Comment 2 ivan 2015-06-30 05:41:34 UTC
note: flickering also happens with kernel 4.0.6-300.fc22.x86_64

Comment 3 Johannes Schaub 2015-07-06 19:47:45 UTC
Confirmed, it happens for me aswell, when enabling PSR, using T450s on FHD IPS and uname -a

Linux LAP1 4.0.7-2-ARCH #1 SMP PREEMPT Tue Jun 30 07:50:21 UTC 2015 x86_64 GNU/Linux

cat /proc/cmdline

BOOT_IMAGE=/vmlinuz-linux root=UUID=... rw quiet resume=/dev/sda3 i915.enable_ips=0 i915.enable_psr=1

Comment 4 Johannes Schaub 2015-07-06 19:48:53 UTC
(In reply to Johannes Schaub from comment #3)
> Confirmed, it happens for me aswell, when enabling PSR, using T450s on FHD
> IPS and uname -a
> 
> Linux LAP1 4.0.7-2-ARCH #1 SMP PREEMPT Tue Jun 30 07:50:21 UTC 2015 x86_64
> GNU/Linux
> 
> cat /proc/cmdline
> 
> BOOT_IMAGE=/vmlinuz-linux root=UUID=... rw quiet resume=/dev/sda3
> i915.enable_ips=0 i915.enable_psr=1

Sorry, forgot to mention that I use archlinux.

Comment 5 Rodrigo Vivi 2015-07-07 16:45:50 UTC
Created attachment 1049476 [details]
1/2 - unmask LPSP patch

Comment 6 Rodrigo Vivi 2015-07-07 16:48:19 UTC
Created attachment 1049477 [details]
2/2 - increse idle frames

Hi, 

First of all thanks for the report.

could you please test both patches attached or test the following branch:
http://cgit.freedesktop.org/~vivijim/drm-intel/?h=psr-to-ivan

Thanks,
Rodrigo.

Comment 7 ivan 2015-07-08 19:39:46 UTC
Hi Rodrigo,

I compiled/tested the following kernels with your patches, but no luck:
- 4.0.6-300.fc22.x86_64 (rebuilt src rpm with modified spec file with your patches): flickering is still present
- 4.1.0+ (git clone the psr-to-ivan branch) with fedora's 4.0.6's .config. : the screen goes blank just after modeset during boot. The system is not hard frozen (ctrl-alt-del reboots the laptop) but there's no activity and nothing in the logs. I remember having hard lockups with i915.semaphores=1, so I tried with semaphores=0, as well as enable_ips=0, but it didn't help.
- 4.2-rc1: hard freeze at early boot with "[drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE) ! " msg.

Maybe Johannes above will have more luck.

Thanks,
Ivan

Comment 8 Rodrigo Vivi 2015-07-08 19:50:56 UTC
Hi Ivan,

Thanks for the attempts.

Could you please try another branch? It is just "psr": http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=psr

Also, on psr-to-ivan, what happens if you boot with i915.enable_psr=0? is it still blank or does it work?

Please on this new "psr" branch please also boot with and without i915.enable_psr=0.

Also, on this blank screen do you still have ssh access? what does i915_edp_psr_status on debugfs tell you?

Regarding semaphores it is disabled by default on BDW anyway.

Thanks,
Rodrigo.

Comment 9 ivan 2015-07-13 07:05:20 UTC
note: Rodrigo is working on the issue but our email exchange is a bit lengthy for bugzilla so I'll follow up here when we make progress

Comment 10 Ethan Schoonover 2015-08-25 10:34:27 UTC
Ivan, is it still useful to build against that psr branch and submit reports on this flicker/screen-blank issue or is it better to wait on report from you and Rodrigo?

-Ethan

Comment 11 ivan 2015-08-25 12:16:09 UTC
Hi Ethan,

Rodrigo created a new test branch ("psr-delayed-enable") but there are still problems, so it's better to wait. You may want to check the following bug, this is where I test Rodrigo's stuff:

https://bugs.freedesktop.org/show_bug.cgi?id=91438

(I didn't put this url as an external bug since the problem is not flickering anymore)

Comment 12 Fedora End Of Life 2016-07-19 20:11:00 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 13 Ron Lockard 2022-02-01 08:59:41 UTC
This same issue is happening on Fedora 35 on my Lenovo Ideapad 7i with an i7-11370H processor with the Iris Xe graphics.  Adding i915.enable_psr=0 as stated masks the issue as before.  No other kernel options other than normal defaults are set.

Current kernel is 5.15.17-200.fc35.x86_64  (it has happened on every kernel since install)

00:02.0 VGA compatible controller: Intel Corporation TigerLake-LP GT2 [Iris Xe Graphics] (rev 01) (prog-if 00 [VGA controller])
        Subsystem: Lenovo Device 3802
        Flags: bus master, fast devsel, latency 0, IRQ 144, IOMMU group 1
        Memory at 605c000000 (64-bit, non-prefetchable) [size=16M]
        Memory at 4000000000 (64-bit, prefetchable) [size=256M]
        I/O ports at 3000 [size=64]
        Expansion ROM at 000c0000 [virtual] [disabled] [size=128K]
        Capabilities: <access denied>
        Kernel driver in use: i915
        Kernel modules: i915

I should note, I am running the KDE spin, in case that makes a difference.  Also using Wayland since it is now default.

What information or testing can I provide to help troubleshoot/fix the issue?

-Ron

Comment 14 José Roberto de Souza 2022-02-01 16:41:15 UTC
Hi Ron

Please take a look at https://gitlab.freedesktop.org/drm/intel/-/issues.
There is a couple of PSR bugs under debug, please check if your issue matches one of those.

If not please file a new bug following: https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs
In addition to the instructions above, please add i915.psr_safest_params=1 to your kernel parameters and let us know if it helps or not.


Note You need to log in before you can comment on or make changes to this bug.