Bug 1236608 - Source VM is deleted after failed cloning attempt
Summary: Source VM is deleted after failed cloning attempt
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.1
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
: 3.5.4
Assignee: Tomas Jelinek
QA Contact: Nisim Simsolo
URL:
Whiteboard: virt
Depends On: 1235179
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-29 14:22 UTC by rhev-integ
Modified: 2022-06-09 09:39 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously, when the 'Clone VM' operation failed after the clone of disks started, but before it finished, and the cleanup of disks succeeded, the subsequent cleanup of the virtual machine deleted the source virtual machine. This caused cases in which the source virtual machine disappeared, but the destination virtual machine was not created. With this update, when cloning fails as described here, the source virtual machine and the source disks stay in the environment and the destination virtual machine is properly cleaned.
Clone Of: 1235179
Environment:
Last Closed: 2015-09-03 17:27:28 UTC
oVirt Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-46383 0 None None None 2022-06-09 09:39:20 UTC
Red Hat Product Errata RHBA-2015:1725 0 normal SHIPPED_LIVE Red Hat Enterprise Virtualization Manager 3.5.4 update 2015-09-03 21:27:06 UTC
oVirt gerrit 42911 0 master MERGED core: Source VM is deleted after failed cloning attempt Never
oVirt gerrit 42967 0 ovirt-engine-3.5 MERGED core: Source VM is deleted after failed cloning attempt Never

Comment 2 Nisim Simsolo 2015-07-05 15:44:19 UTC
Trying to reproduce this bug using Insufficient storage domain space for cloning is incorrect.
Engine UI rejects the cloning action with "low disk space" message.
We need to find a way to start cloning process and then fail it somehow.

Comment 3 Tomas Jelinek 2015-07-07 06:54:37 UTC
Try having more than 1 disk and 2 storage domains. Start copy and after one of them have been successfully copied, turn the source storage server off.

(I have simulated this using debugger so not sure about exact reproduction steps)

Comment 4 Nisim Simsolo 2015-07-07 13:42:37 UTC
Fixed.
Verify version: 3.5.4-1.1.el6ev
Verification procedure: 
1. Add iSCSI storage domain.
2. Create VM with iSCSI disk and install OS on it.
3. Run VM and verify OS is running properly.
4. Power off VM.
5. Start cloning VM, wait two seconds after clone started and run the next command on the host for unregistering iscsi from host:
iscsiadm -m node -u
6. Wait for the next failure event: "Failed to complete VM "VM-clone-name" creation and verify: 
Cloned VM deleted from virtual machines tab and no disks on it.
Source VM still exist in virtual machines tab with disks on it.
7. Run the next command on the host for relogin iscsi to host: 
iscsiadm -m node -l 
Run source VM and verify OS is running properly (no data corruption occurred).

Note: running same procedure on RHEVm 3.6 is reproducing this bug (currently this bug is in modified status), which means bug reproduction procedure for this issue is valid.

Comment 5 Nisim Simsolo 2015-07-07 14:02:31 UTC
Test case created for verifying this bug: 
https://polarion.engineering.redhat.com/polarion/#/project/RHEVM3/workitem?id=RHEVM3-12336

Comment 7 errata-xmlrpc 2015-09-03 17:27:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1725.html


Note You need to log in before you can comment on or make changes to this bug.