Bug 1236635 - 389-admin TPS srpmtest failure
Summary: 389-admin TPS srpmtest failure
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Directory Server
Classification: Red Hat
Component: Admin
Version: 9.1.1
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: DS10.1
: ---
Assignee: Noriko Hosoi
QA Contact: Viktor Ashirov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-29 15:31 UTC by Viktor Ashirov
Modified: 2016-11-07 15:39 UTC (History)
3 users (show)

Fixed In Version: 389-admin-1.1.44-1.el7dsrv
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-07 15:39:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2665 0 normal SHIPPED_LIVE Red Hat Directory Server bug fix and enhancement update 2016-11-07 20:38:00 UTC

Description Viktor Ashirov 2015-06-29 15:31:36 UTC
I was observing TPS srpmtest failure with 389-admin:
FAILED to rebuild /mnt/redhat/brewroot/packages/389-admin/1.1.42/1.el6dsrv/src/389-admin-1.1.42-1.el6dsrv.src.rpm -- return code 256
 REBUILD: FAIL for 389-admin-1.1.42-1.el6dsrv.src.rpm
 BUILDLOG: 389-admin-1.1.42-1.el6dsrv.src.rpm-x86_64-rebuild.log contains full details.  Reports from make and rpmbuild, with line numbers:
 308-checking for --with-modnss-bin... no
 309-checking for nss_pcache... /usr/libexec/nss_pcache
 310-/usr/sbin/nss_pcache
 311-configure: error: Could not find the mod_nss pass phrase helper /nss_pcache
 312-configure: WARNING: cache variable ac_cv_path_nsspcache contains a newline
 313:error: Bad exit status from /var/tmp/rpm-tmp.DoSLQn (%build)
 314-
 315-
 316-RPM build errors:
 317-    Bad exit status from /var/tmp/rpm-tmp.DoSLQn (%build)
 Last 20 lines of Build Log:
 checking for --with-icu-lib... no
 checking for --with-icu-bin... no
 checking for icu with icu-config... checking for icu-config... /usr/bin/icu-config
 using system ICU
 checking for genrb... 1
 configure: checking for ADMINUTIL...
 checking for --with-adminutil... no
 checking for adminutil with pkg-config... checking for pkg-config... (cached) /usr/bin/pkg-config
 configure: checking for MOD_NSS...
 checking for --with-modnss-lib... no
 checking for --with-modnss-bin... no
 checking for nss_pcache... /usr/libexec/nss_pcache
 /usr/sbin/nss_pcache
 configure: error: Could not find the mod_nss pass phrase helper /nss_pcache
 configure: WARNING: cache variable ac_cv_path_nsspcache contains a newline
 error: Bad exit status from /var/tmp/rpm-tmp.DoSLQn (%build)
 RPM build errors:
 Bad exit status from /var/tmp/rpm-tmp.DoSLQn (%build)
 ===============

It was only reproducible on "stable" TPS system. When I build package using mock, it passed.

The issue itself is in this piece of code:
https://git.fedorahosted.org/cgit/389/admin.git/tree/m4/mod_nss.m4#n57
https://git.fedorahosted.org/cgit/389/admin.git/tree/configure#n19801

When there is *rpmnew file in /etc/httpd/conf.d/, it is parsed also. And grep returns 2 lines instead of one (hence "WARNING: cache variable ac_cv_path_nsspcache contains a newline").

Comment 1 Noriko Hosoi 2015-06-29 16:35:40 UTC
Ah, I see.  Thanks for narrowing down the issue, Viktor.  Instead of *, we should have put *.conf or something more specific...

m4/mod_nss.m4
    if test -z "$nsspcache" ; then
        nsspcache=`grep NSSPassPhraseHelper $httpd_root/conf.d/* | awk '{print $2}'`
    fi

These are twin sisters.
389-admin-1.1.42-1.el7dsrv 	nhosoi 	2015-06-08 17:13:39 	complete
389-admin-1.1.42-1.el6dsrv 	nhosoi 	2015-06-08 17:12:00 	complete

Was 389-admin-1.1.42-1.el7dsrv okay with the same code for RHDS 10?

Is this a test/release stopper?

Comment 2 Viktor Ashirov 2015-06-29 16:48:52 UTC
(In reply to Noriko Hosoi from comment #1)
> These are twin sisters.
> 389-admin-1.1.42-1.el7dsrv 	nhosoi 	2015-06-08 17:13:39 	complete
> 389-admin-1.1.42-1.el6dsrv 	nhosoi 	2015-06-08 17:12:00 	complete
> 
> Was 389-admin-1.1.42-1.el7dsrv okay with the same code for RHDS 10?
I don't remember that we had exact same issue, but only because we had other problems with TPS. And because of that we tested not on "stable" TPS systems, but on erratified beaker machines.
But the code is the same and it can be triggered in unclean environment on RHDS10.
 
> Is this a test/release stopper?
No, this srpmtest failure is not not a test/release stopper. In clean environment where we build our packages (brew or mock) it's not reproducible. Moreover, rpms that are built by customers from srpms are not supported. So customers should not encounter this issue.

Comment 3 Noriko Hosoi 2016-04-07 20:59:59 UTC
Per triage,
> ACK.  We should fix for 10.1.

Comment 9 errata-xmlrpc 2016-11-07 15:39:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2665.html


Note You need to log in before you can comment on or make changes to this bug.