Description of problem: My guest recipe is: <guestrecipe guestargs="--ram=1024 --vcpus=1 --file-size=20 --hvm --kvm --nonsparse" guestname="x86_64_kvm_1cpu" kernel_options="!ksdevice inst.zram=off" kernel_options_post="" ks_meta="method=nfs" role="None" whiteboard="3.10.0-287.el7 KVM x86_64 1 vcpu"> Guest is started with command line: Command line: inst.repo=nfs:vtap-bos-eng01.bos.redhat.com:/vol/engineering/devarchive/redhat/nightly/RHEL-7.2-20150629.n.0/compose/Server/x86_64/os/ ks=http://beaker.engineering.redhat.com/kickstart/1412499 serial console=tty0 console=ttyS0,115200 PROBLEM: "!ksdevice inst.zram=off" are not passed to guest kernel command line Version-Release number of selected component (if applicable): distribution-distribution-virt-install-4.0-88.noarch How reproducible: 100% Steps to Reproduce: 1. try to pass some kernel options to guest at installation time Actual results: kernel_options field is ignored Expected results: kernel_options field is added to guest kernel command line Additional info:
I don't think this is a regression, is it? We just need the task to grab kernel_options out of the recipe XML and append it to the end of the --extra-args option that it builds, I guess. BTW !ksdevice doesn't mean anything to the kernel (the ! prefix is a Cobbler-ism, reimplemented in Beaker) so I'm not sure why that's in there. Although it makes no difference to this bug.
(In reply to Dan Callaghan from comment #2) > I don't think this is a regression, is it? Likely not a regression. > BTW !ksdevice doesn't mean anything to the kernel (the ! prefix is a > Cobbler-ism, reimplemented in Beaker) so I'm not sure why that's in there. > Although it makes no difference to this bug. The option I cared about was "inst.zram=off", because zram has fatal bug, that breaks installation of recent RHEL7.2 nightly trees.
Tagged as: /distribution/virt/install 4.0-89 /distribution/virt/image-install 1.0-5 /distribution/virt/start 2.1-10 /distribution/virt/stop 2.0-17 /distribution/virt/start_stop 2.1-3
Suggested test case: Run a job with a guest recipe, put kernel_option_post="dummyoption" in <guestrecipe/>. Check kernel command line shown in guest console log after the recipe is finished. Expected results: "dummyoption" should appear on kernel command when the guest reboots after installation.
(In reply to Dan Callaghan from comment #8) > Suggested test case: > Run a job with a guest recipe, put kernel_option_post="dummyoption" in ^^ this BZ is about kernel_options kernel_options_post is handled via kickstart as parameter for "bootloader" option, as far as I know that always worked fine. > <guestrecipe/>. > Check kernel command line shown in guest console log after the recipe is > finished. kernel_options should be on command line only during installation.
(In reply to Jan Stancek from comment #9) Ah yes of course, I got it the wrong way around. Thanks for the correction :-)
Tasks published on beaker-project.org.