Bug 1237042 - Review Request: nodejs-validate-npm-package-name - Give me a string and I'll tell you if it's a valid npm package name
Summary: Review Request: nodejs-validate-npm-package-name - Give me a string and I'll ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1236565
Blocks: nodejs-reviews
TreeView+ depends on / blocked
 
Reported: 2015-06-30 09:18 UTC by Zuzana Svetlikova
Modified: 2015-09-24 14:19 UTC (History)
2 users (show)

Fixed In Version: 2.2.2-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-09-24 05:13:56 UTC
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Zuzana Svetlikova 2015-06-30 09:18:01 UTC
Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-validate-npm-package-name/nodejs-validate-npm-package-name.spec
SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-validate-npm-package-name/nodejs-validate-npm-package-name-2.2.2-1.fc22.src.rpm
Description: This package exports a single synchronous function that takes a string as input and returns an object
Fedora Account System Username: zvetlik

Comment 1 Parag AN(पराग) 2015-07-14 17:05:37 UTC
Review:

+ mock build is successful for F23 x86_64

+ rpmlint on all generated rpms gave output
nodejs-validate-npm-package-name.noarch: W: only-non-binary-in-usr-lib
nodejs-validate-npm-package-name.noarch: W: dangling-symlink /usr/lib/node_modules/validate-npm-package-name/node_modules/builtins /usr/lib/node_modules/builtins
2 packages and 0 specfiles checked; 0 errors, 2 warnings.


+ Source verified with upstream as (sha256sum)
upstream tarball: de89107058e7f6268c10e4cccff6513c191d3776042569196b3362b80bbcf2f8
srpm tarball: de89107058e7f6268c10e4cccff6513c191d3776042569196b3362b80bbcf2f8

+ License is "ISC" which is valid and is included in its own text file LICENSE.

+ rest looks as per packaging guidelines.

Suggestions:
1) note generally nodejs noarch packages don't need following
BuildRequires: nodejs-devel

remove it.


APPROVED.

Comment 2 Zuzana Svetlikova 2015-07-15 10:41:29 UTC
Thank you!

New Package SCM Request
=======================
Package Name: nodejs-validate-npm-package-name
Short Description: Give me a string and I'll tell you if it's a valid npm package name
Upstream URL: https://github.com/npm/validate-npm-package-name
Owners: zvetlik
Branches: f21 f22 el6 epel7

Comment 3 Gwyn Ciesla 2015-07-15 17:35:52 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2015-07-30 08:28:44 UTC
nodejs-validate-npm-package-name-2.2.2-2.fc23 has been submitted as an update for Fedora 23.
https://admin.fedoraproject.org/updates/nodejs-validate-npm-package-name-2.2.2-2.fc23

Comment 5 Fedora Update System 2015-07-30 08:29:42 UTC
nodejs-validate-npm-package-name-2.2.2-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/nodejs-validate-npm-package-name-2.2.2-2.fc22

Comment 6 Fedora Update System 2015-07-30 08:31:18 UTC
nodejs-validate-npm-package-name-2.2.2-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nodejs-validate-npm-package-name-2.2.2-2.fc21

Comment 7 Fedora Update System 2015-07-30 17:29:53 UTC
nodejs-validate-npm-package-name-2.2.2-2.fc23 has been pushed to the Fedora 23 testing repository.

Comment 8 Parag AN(पराग) 2015-09-23 06:15:59 UTC
Any reason not to push updates to stable repository?

Comment 9 Fedora Update System 2015-09-24 05:13:54 UTC
nodejs-validate-npm-package-name-2.2.2-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2015-09-24 08:27:26 UTC
nodejs-validate-npm-package-name-2.2.2-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2015-09-24 14:19:32 UTC
nodejs-validate-npm-package-name-2.2.2-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.