Red Hat Bugzilla – Bug 1238601
Flash message doesn't go away upon clicking
Last modified: 2015-12-08 08:21:38 EST
Created attachment 1045424 [details] screenshot of import tags page with flash messages Description of problem: ----------------------- Flash messages don't go away after clicking on the Import tags page. Version-Release number of selected component (if applicable): ----------------------- 5.3.5 How reproducible: ----------------- Always Steps to Reproduce: ------------------- 1.Navigate to the Configure->Configuration->Settings page.Click 'Import tags' tab. 2.Select a .csv file for uploading. Actual results: --------------- Observe that the flash messages displayed don't go away upon click the messages. (See attached screenshot) Expected results: ----------------- Flash messages should go away upon click the messages. Additional info: ---------------
Nandini, do these go away when navigating to a different page? Also, it sounds like you are saying you can click on other flash messages from other pages and they disappear, please confirm, thx.
Dave, 1)The flash messages go away when navigating to a different page. 2)When I click on flash messages from other pages,the flash messages do disappear.
It looks to me that purpose of these messages is more like instruction messages than notification, and I think it shouldn't disappear after click. I've changed contextual class so this messages appear as info classes instead "success notification" in PR: https://github.com/ManageIQ/manageiq/pull/3526
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/4d8de043af455a461aab0e6a3476f9ef06f01a18 commit 4d8de043af455a461aab0e6a3476f9ef06f01a18 Author: Roman Blanco <rblanco@redhat.com> AuthorDate: Mon Jul 20 14:49:30 2015 +0200 Commit: Roman Blanco <rblanco@redhat.com> CommitDate: Sat Jul 25 08:00:08 2015 +0200 Changed contextual class of instructions https://bugzilla.redhat.com/show_bug.cgi?id=1238601 app/controllers/ops_controller/settings/common.rb | 2 +- app/controllers/ops_controller/settings/upload.rb | 8 ++++++-- app/views/layouts/_flash_msg.html.haml | 3 +++ app/views/ops/_settings_import_tags_tab.html.haml | 7 ++++--- 4 files changed, 14 insertions(+), 6 deletions(-)
Verified in 5.5.0.2
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2015:2551