Spec URL: https://ppisar.fedorapeople.org/perl-libnet/perl-libnet.spec SRPM URL: https://ppisar.fedorapeople.org/perl-libnet/perl-libnet-3.06-1.fc23.src.rpm Description: Fedora Account System Username: ppisar This is a collection of Perl modules which provides a simple and consistent programming interface (API) to the client side of various protocols used in the internet community. This package will dual-live with perl.spec after sub-packaging it there.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-libnet-3.06-1.fc23.noarch.rpm | sort | uniq -c 1 perl >= 0:5.008001 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(Errno) 1 perl(Exporter) 1 perl(Fcntl) 1 perl(File::Basename) 1 perl(FileHandle) 1 perl(IO::Select) 1 perl(IO::Socket) >= 1.05 1 perl(IO::Socket::IP) >= 0.20 1 perl(Net::Cmd) 1 perl(Net::Config) 1 perl(Net::FTP::I) 1 perl(Net::FTP::dataconn) 1 perl(POSIX) 1 perl(Socket) >= 2.016 1 perl(Symbol) 1 perl(Time::Local) 1 perl(constant) 1 perl(strict) 1 perl(utf8) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-libnet-3.06-1.fc23.noarch.rpm | sort | uniq -c 1 perl(Net::Cmd) = 3.06 1 perl(Net::Config) = 3.06 1 perl(Net::Domain) = 3.06 1 perl(Net::FTP) = 3.06 1 perl(Net::FTP::A) = 3.06 1 perl(Net::FTP::E) = 3.06 1 perl(Net::FTP::I) = 3.06 1 perl(Net::FTP::L) = 3.06 1 perl(Net::FTP::_SSL_SingleSessionCache) 1 perl(Net::FTP::dataconn) = 3.06 1 perl(Net::NNTP) = 3.06 1 perl(Net::NNTP::_SSL) 1 perl(Net::Netrc) = 3.06 1 perl(Net::POP3) = 3.06 1 perl(Net::POP3::_SSL) 1 perl(Net::SMTP) = 3.06 1 perl(Net::SMTP::_SSL) 1 perl(Net::Time) = 3.06 1 perl-libnet = 3.06-1.fc23 Binary provides are Ok. $ rpmlint ./perl-libnet* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok FIX: Please add build-requires 'coreutils', 'findutils', 'make' FIX: perl(IO::File) is listed twice, please remove one of them. Package is not approved.
Thanks for pointing to these mistakes. Updated package is on the same address.
Build-requires are ok. Package is approved
New Package SCM Request ======================= Package Name: perl-libnet Short Description: Perl clients for various network protocols Upstream URL: http://search.cpan.org/dist/libnet/ Owners: ppisar jplesnik psabata Branches: InitialCC: perl-sig
Git done (by process-git-requests).
perl.spec patches the Net/libnet.cfg and provides libnetcfg(1) in perl-devel to set edit the file. This should be synchronized with the standalone package.
I will remove the Net/libnet.cfg because: (1) it's content equals to default configuration hard-coded in the code (2) it's kind of configuration file we do mark it as a configuration file, so it's overwritten on each update (3) it's loaded from directory based on Net::Config module location. I.e. core module will search it in core path, vendor module in vendor path and site module in site path. Summary is the file is useless as it is provided till now.
The libnetcfg(1) works even without Net::Config. So no issues here. I only think perl-devel is not the best package for it. I will move it into standalone sub-package.
Thank you for the review and the repository.