Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1238742

Summary: Wrong changed items list, when changing in edit running VM dialog, the console parameter
Product: [oVirt] ovirt-engine Reporter: Ilanit Stein <istein>
Component: GeneralAssignee: Shmuel Melamud <smelamud>
Status: CLOSED CURRENTRELEASE QA Contact: meital avital <mavital>
Severity: high Docs Contact:
Priority: urgent    
Version: ---CC: amureini, bugs, gklein, istein, lsurette, mavital, mgoldboi, michal.skrivanek, rbalakri, smelamud, srevivo, tjelinek, ykaul, ylavi
Target Milestone: ovirt-3.6.5Flags: mavital: needinfo+
mavital: needinfo+
rule-engine: ovirt-3.6.z+
ylavi: blocker+
ylavi: planning_ack+
rule-engine: devel_ack+
mavital: testing_ack+
Target Release: 3.6.5.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 3.6.5-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-21 14:41:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1313369    
Bug Blocks:    
Attachments:
Description Flags
change list screen shot
none
screenshot none

Description Ilanit Stein 2015-07-02 13:55:38 UTC 
Description of problem:

There is a wrong "changed items list" reported, in edit running VM dialog,
when changing the console parameter. 
Examples:

1. A running VM with console vnc+spice, change to spice, press OK => show in the       changed item list: 'vnc'

Then change the console from spice to vnc, press OK => show in the changed item list: spice, creation date, cpu profile

Then change vnc to vnc+spice => show in the changed item list: 'vnc'

2. A running VM with vnc console, change to spice => show in the changed item list: 'vnc', 'spice'

3. A running VM with vnc console, change to spice+vnc => show in the changed item list: spice

Version-Release number of selected component (if applicable):
ovirt 3.6.0-2

How reproducible:
Always

Expected results:
Show in changed items list the correct items that were changed.  

Additional info:
Comment 1 Shmuel Melamud 2015-07-14 14:12:52 UTC 
Do you mean that changing console type (spice/vnc/spice+vnc) should be reported as single item ('console type')? Or current behaviour, where spice and vnc are considered different devices and are reported separately, is correct?
Comment 2 Ilanit Stein 2015-07-16 08:47:13 UTC 
Following conversation with Shmuel M.: 

1. The current behavior is:

The "Spice" and "VNC" are separate devices, 
and each change within "console type" field,
for "Spice"\"VNC", Change list will show "Spice"\"VNC"

For example,
If console type is VNC -> SPICe
change list will show "VNC", "Spice"
as vnc was turned off, and spice turned on.

2. In this bug fix change list, will simply show "console Type", to indicate any change there, without specifying spice, or vnc.
and the non related fields: creation date, cpu profile, should not appear, when console type changes.
Comment 3 Shmuel Melamud 2015-07-23 12:36:44 UTC 
I already do not see 'creation date' and 'cpu profile' on the latest builds. The 'customProperties', also appearing without any changes in it, was fixed.
Comment 4 Ilanit Stein 2015-10-28 08:54:29 UTC 
Tested on rhevm 3.6.0-17:

A running VM with console vnc+spice, change to spice, press OK => show in the       changed item list: 'graphicsProtocol'
So moving change list to 'graphicsProtocol', from 'VNC'/'SPICE', when console changes, was fixed.

But , then change the console from spice to vnc, press OK => show in the changed item list: 
graphicsProtocol
cpuProfileId
creationDate

and 'cpuProfileId', 'creationDate' should not appear,
so this part still need to be fixed.
Comment 5 Red Hat Bugzilla Rules Engine 2015-10-28 08:54:34 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 6 Ilanit Stein 2015-10-28 09:27:36 UTC 
Adding screenshot of the change list mentioned in comment 4.
Comment 7 Ilanit Stein 2015-10-28 09:28:29 UTC 
Created attachment 1087176 [details]
change list screen shot
Comment 8 Sandro Bonazzola 2015-11-05 08:21:41 UTC 
oVirt 3.6.0 has been released on November 4th, re-targeting to 4.0 since this bug has been marked with severity < high
Comment 9 Red Hat Bugzilla Rules Engine 2015-11-16 14:07:51 UTC 
This bug is flagged for 3.6, yet the milestone is for 4.0 version, therefore the milestone has been reset.
Please set the correct milestone or add the flag.
Comment 10 Michal Skrivanek 2015-11-24 12:05:22 UTC 
please check comment #4 andfix within 3.6.z if relevant
Comment 11 Michal Skrivanek 2016-01-19 10:03:08 UTC 
this is supposedly fixed by one of Tomas' patches in 3.6.3. Please recheck the cpuProfileId though
Comment 12 Shmuel Melamud 2016-01-31 16:53:38 UTC 
Is not reproduced on current ovirt-engine-3.6 branch.

Steps to verify:

1. Create a VM with VNC graphics protocol.
2. Run the VM.
3. Edit the VM.
4. Press OK. No changes for the next run displayed.
5. Edit the VM.
6. Change graphics protocol to SPICE.
7. Press OK. Only graphicsProtocol is displayed in the list of changed for the next run.

Repeat the same with VM created with SPICE graphics protocol and then changed to VNC when VM is running.
Comment 13 Ilanit Stein 2016-02-17 08:02:24 UTC 
Tested on rhevm 3.6.3-1,
with comment #4 flow.
Same problem still exist.
Comment 14 Red Hat Bugzilla Rules Engine 2016-02-17 08:02:32 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 15 Tomas Jelinek 2016-02-17 11:34:32 UTC 
This is not going to make 3.6.3 - pushing to 3.6.5
Comment 16 Shmuel Melamud 2016-02-17 20:23:32 UTC 
I still cannot reproduce this on both 3.6 branch and 3.6.3 version.
Comment 18 meital avital 2016-03-20 13:42:02 UTC 
Tested on version: 3.6.4-0.1.el6

Steps:
1. Create a VM with VNC graphics protocol.
2. Run the VM.
3. Edit the VM.
6. Change graphics protocol to SPICE.
7. The only graphicsProtocol is displayed in the list of changed for the next run.
8. Restart the VM
9. Graphics protocol still VNC


It looks like Edit VM failed, the same problem as - https://bugzilla.redhat.com/show_bug.cgi?id=1313369#c16
Comment 19 meital avital 2016-03-23 21:28:11 UTC 
Tested on version: 3.6.4.1-0.1.el6

Steps:
1. Create a VM with VNC graphics protocol.
2. Run the VM.
3. Edit the VM.
6. Change graphics protocol to SPICE.
7. The only graphicsProtocol is displayed in the list of changed for the next run.
8. Open the Edit dialog of the VM.
9. Don't change anything -> click ok
10. Not only graphicsProtocol is displayed (see screenshot attachment)
11. Restart the VM
12. Graphics protocol still change to SPICE.
Comment 20 Red Hat Bugzilla Rules Engine 2016-03-23 21:28:19 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 21 meital avital 2016-03-23 21:29:21 UTC 
Created attachment 1139754 [details]
screenshot
Comment 22 Michal Skrivanek 2016-03-24 05:34:12 UTC 
(In reply to meital avital from comment #19)
> 3. Edit the VM.
> 6. Change graphics protocol to SPICE.
...
> 12. Graphics protocol still change to SPICE.

What's wrong with that?
Comment 23 meital avital 2016-03-24 07:35:26 UTC 
I mean in step 12 that the Graphics protocol change as expected, but see my attachment I reproduce the problem in comment #4
Comment 24 Tomas Jelinek 2016-03-24 08:09:55 UTC 
This one was supposed to be pushed to 3.6.5 because of https://gerrit.ovirt.org/#/c/54297/ was only in master and 3.6 branches.
This patch will fix the "creationDate".

The suspicious part is the "sound" - can you please make sure you have not changed also that one? Because I can not simulate it.
Comment 25 Eyal Edri 2016-03-31 08:35:44 UTC 
Bugs moved pre-mature to ON_QA since they didn't have target release.
Notice that only bugs with a set target release will move to ON_QA.
Comment 26 meital avital 2016-04-07 07:00:23 UTC 
Verified on rhevm-3.6.5.1-0.1.el6