Spec URL: https://delete.fedorapeople.org/thefuck/thefuck.spec SRPM URL: https://delete.fedorapeople.org/thefuck/thefuck-1.46-1.fc22.src.rpm Description: This application corrects your previous console command. Fedora Account System Username: delete The purpose of the program is to simplify tasks like these. ➜ puthon No command 'puthon' found, did you mean: Command 'python' from package 'python-minimal' (main) Command 'python' from package 'python3' (main) zsh: command not found: puthon ➜ fuck python Python 3.4.2 (default, Oct 8 2014, 13:08:17) ➜ git brnch git: 'brnch' is not a git command. See 'git --help'. Did you mean this? branch ➜ fuck git branch * master This is a successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10284857
Hm, have you considered using a copr repo for this instead? Adding a package to the distribution is a long-time commitment, and it seems likely that this project will not see any more updates.
Zbigniew, why do you think that this project wont see any more updates? their GIT repository is pretty active, I have submitted a patch myself to make it run in python 3.4 and they accepted it.
They actually just made a release, and another one 2 days ago.
If the upstream is making new releases, then OK. Please update to the latest version. Add %license LICENSE.md to %files. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages/thefuck, /usr/lib/python3.4/site-packages/tests/rules, /usr/lib/python3.4/site- packages/thefuck-1.46-py3.4.egg-info (Basically you can remove "/*" from those lines in %files.) You cannot install files into %{python3_sitelib}/tests. This is an upstream bug, but it must be fixed in some way. Either %exclude this directory from the package, or move the directory underneath %{python3_sitelib}/thefuck/. Rpmlint ------- thefuck.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/thefuck/rules/cd_correction.py 0644L /usr/bin/env This contains '/usr/bin/env python' which is misleading, even if not actually used. Probably best to do 'sed -i 1d ...'.
Updated spec and SRPM. Let me know if I have miss anything. SPEC: https://delete.fedorapeople.org/thefuck/thefuck.spec SRPM: https://delete.fedorapeople.org/thefuck/thefuck-1.48-1.fc22.noarch.rpm scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10329673
Please use %license for the license file [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text]. %{python3_sitelib}/thefuck-%{version}-py3.4.egg-info is still unowned. Would adding the aliases to .bash_profile really work? It would only be available in the login shell iiuc. Also in the %description, please add a mention that this is for bash.
I have updated the spec and srpm again. SPEC: https://delete.fedorapeople.org/thefuck/thefuck.spec SRPM: https://delete.fedorapeople.org/thefuck/thefuck-1.48-1.fc22.noarch.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10332026
+ license is OK + license file present and installed properly + upstream link OK + latest version + packaging is OK + python packaging OK + package works as advertised :) Package is APPROVED.
New Package SCM Request ======================= Package Name: thefuck Short Description: This application corrects your previous console command. Upstream URL: https://github.com/nvbn/thefuck Owners: delete Branches: f21 f22 el6 epel7 InitialCC:
New Package SCM Request ======================= Package Name: thefuck Short Description: This application corrects your previous console command Upstream URL: https://github.com/nvbn/thefuck Owners: delete Branches: f21 f22 el6 epel7 InitialCC:
Git done (by process-git-requests).
OK, changing the status so this does not clutter up my search results.
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117