Spec URL: https://piotrp.fedorapeople.org/python-flask-cache.spec SRPM URL: https://piotrp.fedorapeople.org/python-flask-cache-0.13.1-1.fc22.src.rpm Description: Adds cache support to your Flask application Fedora Account System Username: piotrp
updated %check so it doesn't try to download missing modules added missing BR no version bump, url stay the same. It now scratch-builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10286202
Review: + Package built successfully in mock F23 (x86_64) + rpmlint on all generated rpms gave output 3 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) source in srpm:90126ca9bc063854ef8ee276e95d38b2b4ec8e45fd77d5751d37971ee27c7ef4 source upstream:90126ca9bc063854ef8ee276e95d38b2b4ec8e45fd77d5751d37971ee27c7ef4 + License "BSD" is valid and included in its own text file LICENSE. + Follows python packaging guidelines Suggestions: 1) Python Guidelines now recommend versioned python usage so wherever used python, use python2 e.g. use BuildRequires: python2-devel 2) Python guidelines now changed, use in %prep as %if 0%{?with_python3} cp -a python2 python3 find python3 -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|' %endif # with_python3 find python2 -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python2}|' 3) Similarly use python2 and python3 directory names as given for other parts of spec file like %build, %install, %check from https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file 4) we don't need to install MANIFEST.in 5) You need to generate the documentation using sphinx module and not to just copy the docs directory. You now need to add 2 more subpackages (-doc and python3-flask-cache-doc) e.g. %package doc Summary: Documentation for the Flask-Cache module BuildRequires: python-sphinx %description doc Documentation for the Flask-Cache module Please reword summary and description if needed then in %build you need to build for python2 and python3. For python2 you can do as # for docs pushd docs sphinx-build -b html -d build/doctrees . build/html popd and then %files doc %doc docs/build/html %files -n python3-flask-cache-doc %doc docs/build/html I think I should wait for these changes before approving this package.
Thank you for review. implemented your comments: Spec URL: https://piotrp.fedorapeople.org/python-flask-cache.spec SRPM URL: https://piotrp.fedorapeople.org/python-flask-cache-0.13.1-2.fc22.src.rpm scratch-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10291028 I did not version all requirements as some packages don't "Provide: python2-package" yet (at least in f22). Building documents tries to download some contents, this obviously fails in koji but the resulting documents seem fine.
1) ah sorry I was only meant to say to use python2-devel instead of python-devel. There are very less python2-<module> packages available in the repository so all BR: and Requires: should use python-<module> only for now. 2) rpmlint now gives output as python3-flask-cache-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-flask-cache-doc/html/_static/jquery.js python3-flask-cache-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python3-flask-cache-doc/html/.buildinfo python-flask-cache.src:28: W: unversioned-explicit-provides python2-flask-cache python-flask-cache-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-flask-cache-doc/html/_static/jquery.js python-flask-cache-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-flask-cache-doc/html/objects.inv python-flask-cache-doc.noarch: W: file-not-utf8 /usr/share/doc/python-flask-cache-doc/html/objects.inv python-flask-cache-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-flask-cache-doc/html/.buildinfo 5 packages and 0 specfiles checked; 0 errors, 7 warnings. => From above you can remove .buildinfo file in %build section so it will not be packaged. Then others also you can fix by looking into https://fedoraproject.org/wiki/Common_Rpmlint_issues or here is ready solution rm -f build/html/.buildinfo sed -i 's/\r$//' build/html/_static/jquery.js iconv -f iso8859-1 -t utf-8 build/html/objects.inv > objects.inv.conv mv -f objects.inv.conv build/html/objects.inv 3) Only if you want to build this package on EPEL you need that preamble of defining with_python3 or python2 macro, otherwise not needed for fedora packaging. rest looks fine. APPROVED.
Thank you for review and suggestions. Will fix all issues before importing. And I do want to get it in epel. New Package SCM Request ======================= Package Name: python-flask-cache Short Description: Adds cache support to your Flask application Upstream URL: https://github.com/thadeusb/flask-cache Owners: piotrp Branches: f21 f22 el6 epel7
Git done (by process-git-requests).
python-flask-cache-0.13.1-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-flask-cache-0.13.1-3.fc21
python-flask-cache-0.13.1-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-flask-cache-0.13.1-3.fc22
python-flask-cache-0.13.1-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-flask-cache-0.13.1-3.el7
python-flask-cache-0.13.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository.
python-flask-cache-0.13.1-3.fc21 has been pushed to the Fedora 21 stable repository.
python-flask-cache-0.13.1-3.fc22 has been pushed to the Fedora 22 stable repository.
python-flask-cache-0.13.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository.