Bug 1240892 - Review Request: golang-github-creack-termios - Golang terminal management
Summary: Review Request: golang-github-creack-termios - Golang terminal management
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW 1234182
TreeView+ depends on / blocked
 
Reported: 2015-07-08 04:56 UTC by jakub.jedelsky
Modified: 2020-08-10 00:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-10 00:51:57 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description jakub.jedelsky 2015-07-08 04:56:08 UTC
Spec URL: http://s.stderr.cz/rpm/golang-github-creack-termios.spec
SRPM URL: http://s.stderr.cz/rpm/golang-github-creack-termios-0-0.1.git.d60649a.fc22.src.rpm
Description: Golang terminal management

This package contains library source intended for building other packages
which use creack/termios

Fedora Account System Username: kubo

Comment 1 jakub.jedelsky 2015-07-08 06:42:51 UTC
rpmlint SPECS/golang-github-creack-termios.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint SRPMS/golang-github-creack-termios-0-0.1.git.d60649a.fc22.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 2 Jan Chaloupka 2015-10-22 09:39:27 UTC
I would recommend to regenerate the spec file with the latest support for secondary architectures. There are other improvements like making devel subpackge noarch and adding arch-specific unit-test-devel subpackage for unit tests.

Comment 3 jakub.jedelsky 2015-10-22 09:44:28 UTC
Thanks for info, I'll take a look at it. This one is quite old :)

Comment 4 Jan Chaloupka 2015-10-22 09:46:12 UTC
https://jchaloup.fedorapeople.org/reviews/golang-github-creack-termios/golang-github-creack-termios.spec

Summary:
- noarch devel subpackage
- devel subpackage contain only source codes (nothing else)
- unit-test-devel subpackage for CI testing
- support for secondary architectures
- license in %license tag

Comment 5 Package Review 2020-07-10 00:51:59 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 6 Package Review 2020-08-10 00:51:57 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.