Description of problem: In fedora-review package, script /usr/bin/licensecheck is used - it's part of devscripts-minimal package. Running licensecheck on binary file (such as tarball, picture, etc.) results in crash with: Unknown encoding 'binary' at /usr/bin/licensecheck line 338. Problem is that licensecheck uses "file -bi" to determine file encoding and uses this value to decode. Running file -bi on image file returns: image/jpeg; charset=binary but Perl function decode() doesn't know "binary" encoding. Version-Release number of selected component (if applicable): 2.15.5-5 Steps to Reproduce: 1. Download any image. 2. Run licensecheck image.jpeg Actual results: It shows: Unknown encoding 'binary' at /usr/bin/licensecheck line 338. Expected results: It should either print "*No copyright* UNKNOWN" or info that this script doesn't work on binary files.
Reported upstream https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=791756. I'm not familiar with perl, if you can provide a patch I can integrate it in the Fedora package.
devscripts-2.15.5-6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/devscripts-2.15.5-6.fc22
devscripts-2.15.5-6.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/devscripts-2.15.5-6.fc21
Package devscripts-2.15.5-6.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing devscripts-2.15.5-6.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-11362/devscripts-2.15.5-6.fc22 then log in and leave karma (feedback).
Tested on F22 and it works now.
devscripts-2.15.5-6.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
devscripts-2.15.5-6.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.