Bug 1240916 - glfs_loc_link: Update loc.inode with the existing inode incase if already exits
Summary: glfs_loc_link: Update loc.inode with the existing inode incase if already exits
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi
Version: mainline
Hardware: x86_64
OS: All
unspecified
urgent
Target Milestone: ---
Assignee: Soumya Koduri
QA Contact: Sudhir D
URL:
Whiteboard:
Depends On:
Blocks: 1235121 1241666
TreeView+ depends on / blocked
 
Reported: 2015-07-08 06:35 UTC by Soumya Koduri
Modified: 2016-06-16 13:21 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of:
: 1241666 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:21:35 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Soumya Koduri 2015-07-08 06:35:44 UTC
Description of problem:
int
glfs_loc_link (loc_t *loc, struct iatt *iatt)
{
        int ret = -1;
        inode_t *linked_inode = NULL;

        if (!loc->inode) {
                errno = EINVAL;
                return -1;
        }

        linked_inode = inode_link (loc->inode, loc->parent, loc->name, iatt);
        if (linked_inode) {
                inode_lookup (linked_inode);
                inode_unref (linked_inode);
                ret = 0;
        } else {
                ret = -1;
                errno = ENOMEM;
        }

        return ret;
}

Here in case if the inode already exits in the cache, inode_link returns the pointer to the exiting one instead of using loc->inode. This results in the loc->inode not being updated which may result in the issues reported in https://bugzilla.redhat.com/show_bug.cgi?id=1235121#c10

Comment 1 Anand Avati 2015-07-08 06:46:58 UTC
REVIEW: http://review.gluster.org/11572 (gfapi: Update loc->inode accordingly in 'glfs_loc_link') posted (#1) for review on master by soumya k (skoduri)

Comment 2 Anand Avati 2015-07-09 18:04:41 UTC
COMMIT: http://review.gluster.org/11572 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit c134bdd83a781452eff8c3e4abce3da4a997daa8
Author: Soumya Koduri <skoduri>
Date:   Wed Jul 8 12:08:25 2015 +0530

    gfapi: Update loc->inode accordingly in 'glfs_loc_link'
    
    In case if the inode already exits in the cache, inode_link
    returns the pointer to the exiting one instead of using loc->inode.
    This will result in issues if that invalid inodei(loc->inode) is referenced
    further. Fixed the same.
    
    Change-Id: I7d4a06043e4e731c8404532c47d482175dc2c277
    BUG: 1240916
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/11572
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Niels de Vos 2016-06-16 13:21:35 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.