Bug 1241293 (php-symfony-psr-http-message-bridge) - Review Request: php-symfony-psr-http-message-bridge - Symfony PSR HTTP message bridge
Summary: Review Request: php-symfony-psr-http-message-bridge - Symfony PSR HTTP messag...
Keywords:
Status: CLOSED ERRATA
Alias: php-symfony-psr-http-message-bridge
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-08 23:08 UTC by Shawn Iwinski
Modified: 2015-08-10 09:54 UTC (History)
2 users (show)

Fixed In Version: php-symfony-psr-http-message-bridge-0.2-2.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-05 01:29:17 UTC
Type: ---
Embargoed:
fedora: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpci.log (8.81 KB, text/plain)
2015-07-21 14:22 UTC, Remi Collet
no flags Details
review.txt (7.08 KB, text/plain)
2015-07-21 14:23 UTC, Remi Collet
no flags Details

Comment 1 Remi Collet 2015-07-15 08:04:27 UTC
I encounter a failure during %check


1) Symfony\Bridge\PsrHttpMessage\Tests\Factory\DiactorosFactoryTest::testCreateRequest
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Content'
+''

Can you please check this ?
(it works in local build, but this test is skipped, it fails when php-zendframework-zend-diactoros is installed)

Comment 2 Shawn Iwinski 2015-07-16 18:46:59 UTC
Nice find!  I couldn't quickly find a fix so I opened a ticket upstream -- https://github.com/symfony/psr-http-message-bridge/issues/8 . The issue is in the SYmfony HttpFoundation component which has recently been merged into symfony master -- https://github.com/symfony/symfony/pull/15249 .  I will need to update the Symfony pkg with that patch for this pkg.

Comment 3 Remi Collet 2015-07-21 14:04:48 UTC
I confirm that local build against php-symfony-2.7.2-3 solves the issue.

Comment 4 Remi Collet 2015-07-21 14:22:25 UTC
Created attachment 1054417 [details]
phpci.log

phpCompatInfo version 4.4.0 DB built Jul 13 2015 09:14:16 CEST static analyze results

Comment 5 Remi Collet 2015-07-21 14:23:09 UTC
Created attachment 1054418 [details]
review.txt

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04

Comment 6 Remi Collet 2015-07-21 14:24:44 UTC
Small issue, trivial to fix

[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/php/Symfony/Bridge
     (php-symfony-common)

php-symfony-common is in the dependencies tree

Comment 7 Remi Collet 2015-07-21 14:26:49 UTC
Perhaps worth to
- add implicit dependency on php-symfony-common for dir ownership
- add BR on php-zendframework-zend-diactoros (later, when patch available in all branches, or in rawhide only) to detect any other bug when this optional dep is installed.

Comment 8 Remi Collet 2015-07-21 14:28:01 UTC
And the usual:
-        require_once 'Symfony/Component/ClassLoader/ClassLoader.php';
+        require_once '%{phpdir}/Symfony/Component/ClassLoader/ClassLoader.php';

Comment 10 Remi Collet 2015-08-03 11:48:23 UTC
[x]: Package does not own files or directories owned by other packages.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10586776


=== APPROVED ===

Comment 11 Shawn Iwinski 2015-08-03 15:20:49 UTC
THANKS for the review!



New Package SCM Request
=======================
Package Name: php-symfony-psr-http-message-bridge
Short Description: Symfony PSR HTTP message bridge
Upstream URL: https://github.com/symfony/psr-http-message-bridge
Owners: siwinski
Branches: f21 f22 f23 el6 epel7
InitialCC:

Comment 12 Gwyn Ciesla 2015-08-04 13:07:38 UTC
Git done (by process-git-requests).

Comment 13 Fedora Update System 2015-08-05 02:34:11 UTC
php-symfony-psr-http-message-bridge-0.2-2.fc23 has been submitted as an update for Fedora 23.
https://admin.fedoraproject.org/updates/php-symfony-psr-http-message-bridge-0.2-2.fc23

Comment 14 Fedora Update System 2015-08-10 09:54:07 UTC
php-symfony-psr-http-message-bridge-0.2-2.fc23 has been pushed to the Fedora 23 stable repository.


Note You need to log in before you can comment on or make changes to this bug.