Spec URL: https://raw.githubusercontent.com/siwinski/rpms/51c511c7485fa302bd05fd60a5e9a5a82fa07a24/php-symfony-psr-http-message-bridge/php-symfony-psr-http-message-bridge.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-symfony-psr-http-message-bridge-0.2-1.fc22.src.rpm Description: Provides integration for PSR7. Fedora Account System Username: siwinski
I encounter a failure during %check 1) Symfony\Bridge\PsrHttpMessage\Tests\Factory\DiactorosFactoryTest::testCreateRequest Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'Content' +'' Can you please check this ? (it works in local build, but this test is skipped, it fails when php-zendframework-zend-diactoros is installed)
Nice find! I couldn't quickly find a fix so I opened a ticket upstream -- https://github.com/symfony/psr-http-message-bridge/issues/8 . The issue is in the SYmfony HttpFoundation component which has recently been merged into symfony master -- https://github.com/symfony/symfony/pull/15249 . I will need to update the Symfony pkg with that patch for this pkg.
I confirm that local build against php-symfony-2.7.2-3 solves the issue.
Created attachment 1054417 [details] phpci.log phpCompatInfo version 4.4.0 DB built Jul 13 2015 09:14:16 CEST static analyze results
Created attachment 1054418 [details] review.txt Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Small issue, trivial to fix [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/Symfony/Bridge (php-symfony-common) php-symfony-common is in the dependencies tree
Perhaps worth to - add implicit dependency on php-symfony-common for dir ownership - add BR on php-zendframework-zend-diactoros (later, when patch available in all branches, or in rawhide only) to detect any other bug when this optional dep is installed.
And the usual: - require_once 'Symfony/Component/ClassLoader/ClassLoader.php'; + require_once '%{phpdir}/Symfony/Component/ClassLoader/ClassLoader.php';
Updated. Changes: https://github.com/siwinski/rpms/commit/efa6867dd9c87ec26ee61f241598d16cc229dbc3 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/efa6867dd9c87ec26ee61f241598d16cc229dbc3/php-symfony-psr-http-message-bridge/php-symfony-psr-http-message-bridge.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-symfony-psr-http-message-bridge-0.2-2.fc22.src.rpm
[x]: Package does not own files or directories owned by other packages. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10586776 === APPROVED ===
THANKS for the review! New Package SCM Request ======================= Package Name: php-symfony-psr-http-message-bridge Short Description: Symfony PSR HTTP message bridge Upstream URL: https://github.com/symfony/psr-http-message-bridge Owners: siwinski Branches: f21 f22 f23 el6 epel7 InitialCC:
Git done (by process-git-requests).
php-symfony-psr-http-message-bridge-0.2-2.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/php-symfony-psr-http-message-bridge-0.2-2.fc23
php-symfony-psr-http-message-bridge-0.2-2.fc23 has been pushed to the Fedora 23 stable repository.