Bug 1242028 - virt-make-fs cannot set g+s bit on vfat
Summary: virt-make-fs cannot set g+s bit on vfat
Keywords:
Status: NEW
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-10 17:50 UTC by Richard W.M. Jones
Modified: 2018-07-18 14:41 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description Richard W.M. Jones 2015-07-10 17:50:41 UTC
Description of problem:

virt-make-fs fails if you are creating a VFAT format
filesystem, and any file has g+s or u+s bits set.

Version-Release number of selected component (if applicable):

libguestfs-1.29.48-1.fc23.x86_64

How reproducible:

100% - see below.

Steps to Reproduce:
1. mkdir /tmp/p
2. touch /tmp/p/foo
3. chmod g+s /tmp/p/foo
4. virt-make-fs --floppy /tmp/p /tmp/floppy.img

Actual results:

libguestfs: error: tar_in: tar subcommand failed on directory: /: tar: ./foo: Cannot change mode to rw-rwSr--: Operation not permitted
tar: Exiting with failure status due to previous errors

Expected results:

It should probably ignore the g+s bit

Additional info:

Also happens with the u+s bit:

$ chmod u+s /tmp/p/bar
$ virt-make-fs --floppy /tmp/p /tmp/floppy.img
libguestfs: error: tar_in: tar subcommand failed on directory: /: tar: ./bar: Cannot change mode to rwSrw-r--: Operation not permitted
tar: Exiting with failure status due to previous errors


Note You need to log in before you can comment on or make changes to this bug.