Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1242421

Summary:	Enable multi-threaded epoll for glusterd process
Product:	[Community] GlusterFS	Reporter:	krishnan parthasarathi <kparthas>
Component:	glusterd	Assignee:	krishnan parthasarathi <kparthas>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs, nsathyan
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1250809 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:22:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1250809

Description krishnan parthasarathi 2015-07-13 10:03:43 UTC

Description of problem:

glusterd uses single epoll worker thread for sending/receiving notifications. gluster commands which communicate with many daemons, e.g snapshot-create could take longer than ping-timeout secs on a volume with large no. of snapshots times out. With introduction of multi-threaded epoll support in glusterd, we could add more epoll workers to (reduce latency and) avoid spurious disconnects due to ping-timeout.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-07-13 10:04:35 UTC

REVIEW: http://review.gluster.org/11630 (glusterd: use 2 epoll worker threads by default) posted (#2) for review on master by Krishnan Parthasarathi (kparthas)

Comment 2 Anand Avati 2015-08-13 12:05:02 UTC

REVIEW: http://review.gluster.org/11911 (event: add dispatched flag to know if event_dispatch was called) posted (#1) for review on master by Krishnan Parthasarathi (kparthas)

Comment 3 Anand Avati 2015-08-14 02:45:56 UTC

REVIEW: http://review.gluster.org/11911 (event: add dispatched flag to know if event_dispatch was called) posted (#2) for review on master by Krishnan Parthasarathi (kparthas)

Comment 4 Anand Avati 2015-08-19 04:11:29 UTC

REVIEW: http://review.gluster.org/11911 (event: add dispatched flag to know if event_dispatch was called) posted (#3) for review on master by Krishnan Parthasarathi (kparthas)

Comment 5 Anand Avati 2015-08-21 06:33:00 UTC

REVIEW: http://review.gluster.org/11911 (event: add dispatched flag to know if event_dispatch was called) posted (#4) for review on master by Krishnan Parthasarathi (kparthas)

Comment 6 Anand Avati 2015-08-21 12:03:09 UTC

COMMIT: http://review.gluster.org/11911 committed in master by Niels de Vos (ndevos) 
------
commit d80537d8e588da57db609332c2d89873e0a368ca
Author: Krishnan Parthasarathi <kparthas>
Date:   Thu Aug 13 14:39:58 2015 +0530

    event: add dispatched flag to know if event_dispatch was called
    
    This is important for glusterfs processes that choose to reconfigure
    no. of event-threads (a.k.a epoll worker-threads) before they call
    event_dispatch on the event_pool. glusterd needs this today.
    
    Change-Id: Ia8df3c958545324472262c555ed84b71797f002e
    BUG: 1242421
    Signed-off-by: Krishnan Parthasarathi <kparthas>
    Reviewed-on: http://review.gluster.org/11911
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 7 Anand Avati 2015-08-24 03:44:24 UTC

REVIEW: http://review.gluster.org/11991 (event: add dispatched flag to know if event_dispatch was called) posted (#1) for review on release-3.7 by Krishnan Parthasarathi (kparthas)

Comment 8 Anand Avati 2015-08-24 11:04:37 UTC

REVIEW: http://review.gluster.org/12004 (glusterd: Don't use event_reconfigure_threads to initialize 'event-threads') posted (#2) for review on master by Krishnan Parthasarathi (kparthas)

Comment 9 Anand Avati 2015-08-26 05:01:36 UTC

REVIEW: http://review.gluster.org/12003 (Revert "event: add dispatched flag to know if event_dispatch was called") posted (#2) for review on master by Krishnan Parthasarathi (kparthas)

Comment 10 Anand Avati 2015-08-26 05:01:59 UTC

REVIEW: http://review.gluster.org/12004 (glusterd: Don't use event_reconfigure_threads to initialize 'event-threads') posted (#3) for review on master by Krishnan Parthasarathi (kparthas)

Comment 11 Anand Avati 2015-08-28 09:00:51 UTC

REVIEW: http://review.gluster.org/12004 (event-epoll: Use pollers[] to check if event_pool_dispatch was called) posted (#4) for review on master by Krishnan Parthasarathi (kparthas)

Comment 12 Anand Avati 2015-08-28 17:14:08 UTC

COMMIT: http://review.gluster.org/12004 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit dedf2bde88020adbabb80204830878f060fa614c
Author: Krishnan Parthasarathi <kparthas>
Date:   Fri Aug 28 14:27:20 2015 +0530

    event-epoll: Use pollers[] to check if event_pool_dispatch was called
    
    BUG: 1242421
    Change-Id: I1a0044653f15d33f89ffe16edc5baba40393dec3
    Signed-off-by: Krishnan Parthasarathi <kparthas>
    Reviewed-on: http://review.gluster.org/12004
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 13 Anand Avati 2015-08-29 13:40:49 UTC

REVIEW: http://review.gluster.org/12044 (event: remove vestigial mutex_unlock from event_dispatch) posted (#1) for review on master by Krishnan Parthasarathi (kparthas)

Comment 14 Anand Avati 2015-08-29 16:56:48 UTC

COMMIT: http://review.gluster.org/12044 committed in master by Atin Mukherjee (amukherj) 
------
commit 5b3d64b734f463da3344218c6a76aadddbf9cde4
Author: Krishnan Parthasarathi <kparthas>
Date:   Sat Aug 29 19:07:55 2015 +0530

    event: remove vestigial mutex_unlock from event_dispatch
    
    This was missed erroneously by self in http://review.gluster.org/12004
    
    BUG: 1242421
    Change-Id: Id6cb156fd584704486e49bc4c4a7bdd44a98679f
    Signed-off-by: Krishnan Parthasarathi <kparthas>
    Reviewed-on: http://review.gluster.org/12044
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Raghavendra Talur <rtalur>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 15 Nagaprasad Sathyanarayana 2015-10-25 14:54:25 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 16 Niels de Vos 2016-06-16 13:22:53 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user