Bug 1242619 - Move documentation into -doc subpackage
Summary: Move documentation into -doc subpackage
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-systemd
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-13 18:45 UTC by Vít Ondruch
Modified: 2023-06-27 13:56 UTC (History)
2 users (show)

Fixed In Version: python-systemd-231-3.fc24
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-14 15:01:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Vít Ondruch 2015-07-13 18:45:09 UTC
Description of problem:
Would you mind to move the documentation into -doc subpackage? It is weird to have installed js-jquery due to some documentation of python-systemd I definitely don't care about (at least ATM).

# dnf update
Last metadata expiration check performed 0:40:09 ago on Mon Jul 13 20:03:45 2015.
Dependencies resolved.
================================================================================
 Package                    Arch        Version              Repository    Size
================================================================================
Installing:
 js-jquery                  noarch      2.1.3-2.fc23         rawhide      164 k
 python-systemd             x86_64      230-1.fc23           rawhide      119 k
     replacing  systemd-python.x86_64 222-1.fc23
 web-assets-filesystem      noarch      5-3.fc23             rawhide      9.0 k

Transaction Summary
================================================================================
Install  3 Packages

Total download size: 293 k
Installed size: 984 k
Is this ok [y/N]:

Comment 1 Zbigniew Jędrzejewski-Szmek 2015-07-13 19:13:44 UTC
Can you describe the motivation a bit better? js-jquery is tiny, it's a package with basically one file. python-systemd is so tiny too that splitting out a separate -doc package just doesn't seem worth the trouble. And I think it would be a lost battle: if https://fedoraproject.org/wiki/Changes/jQuery is implemented, there will be hundreds of packages depending on js-jsquery, so having it installed would be almost unavoidable anyway.

Comment 2 Vít Ondruch 2015-07-14 07:35:46 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Can you describe the motivation a bit better? js-jquery is tiny,

"tiny" is no excuse for me. It is additional package, additional burden. I was happy without that package on my system so far and I'd be happy without that documentation.

> it's a
> package with basically one file. python-systemd is so tiny too that
> splitting out a separate -doc package just doesn't seem worth the trouble.
> And I think it would be a lost battle: if
> https://fedoraproject.org/wiki/Changes/jQuery is implemented, there will be
> hundreds of packages depending on js-jsquery,

It doesn't really matter how many packages depends on it. If there is chance to avoid single unnecessary dependency, we should do it.

> so having it installed would
> be almost unavoidable anyway.

And BTW the "tiny" is relative. python-systemd size is 119k and you don't mind to install another two packages occupying additional 145 % of the disk space?

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-07-14 13:59:07 UTC
(In reply to Vít Ondruch from comment #2)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> > Can you describe the motivation a bit better? js-jquery is tiny,
> 
> "tiny" is no excuse for me. It is additional package, additional burden. I
> was happy without that package on my system so far and I'd be happy without
> that documentation.

Compared to the Python stack, this size is completely irrelevant. I'm pretty sure that if I had not split out the jsquery bundling, you'd have never noticed ;)
The guidelines say to split out documentation of "significant" size, and I agree with the lack of need to do it for every few text files.

> > so having it installed would
> > be almost unavoidable anyway.
> 
> And BTW the "tiny" is relative. python-systemd size is 119k and you don't
> mind to install another two packages occupying additional 145 % of the disk
> space?
If the additional two packages are required by another 1455 packages in the distribution, this dependency is "free".

Comment 4 Vít Ondruch 2015-07-14 14:07:19 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> > And BTW the "tiny" is relative. python-systemd size is 119k and you don't
> > mind to install another two packages occupying additional 145 % of the disk
> > space?
> If the additional two packages are required by another 1455 packages in the
> distribution, this dependency is "free".

This might or might not happen. And there will be other packages where requiring js-jquery makes functional difference, where this is not true for this particular package.

Anyway, I made my point. Feel free to close this issue.

Comment 5 Zbigniew Jędrzejewski-Szmek 2015-07-14 15:01:23 UTC
Yeah, I'll close this. I'll keep it mind though to revisit the issue if the documentation ever grows to a more significant size.

Comment 6 Zbigniew Jędrzejewski-Szmek 2015-11-15 22:25:01 UTC
I made the split now, with the main packages having Recommends:python-systemd-doc.

Comment 7 Jens Petersen 2023-06-27 13:56:42 UTC
I have to agree with Vit here: since python-systemd stills seems to pull in python-systemd-doc via the weak dep
so perhaps nothing changed here?

I am in rawhide container today and try to install dnf-plugins-core and this pulls in jquery...
naively doesn't make so much sense?
Though first time I noticed this (is it somehow related with using dnf5?).

Does python-systemd use python-systemd-doc?

Well I guess a new bug should be opened...


Note You need to log in before you can comment on or make changes to this bug.