Bug 1242724 - Review Request: perl-File-Find-Rule-Age - Rule to match on file age
Summary: Review Request: perl-File-Find-Rule-Age - Rule to match on file age
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2015-07-14 04:04 UTC by Tim Orling
Modified: 2015-08-17 20:20 UTC (History)
2 users (show)

Fixed In Version: perl-File-Find-Rule-Age-0.302-3.fc21 perl-File-Find-Rule-Age-0.302-3.el6 perl-File-Find-Rule-Age-0.302-3.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2015-08-17 20:20:36 UTC
Type: ---
psabata: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Tim Orling 2015-07-14 04:04:09 UTC
Spec URL: https://ttorling.fedorapeople.org/perl-File-Find-Rule-Age/perl-File-Find-Rule-Age.spec
SRPM URL: https://ttorling.fedorapeople.org/perl-File-Find-Rule-Age/perl-File-Find-Rule-Age-0.302-1.fc23.src.rpm
File::Find::Rule::Age makes it easy to search for files based on their age. DateTime and File::stat are used to do the behind the scenes work, with File::Find::Rule doing the Heavy Lifting

Fedora Account System Username:ttorling



THis is the second of four new packages needed to support meta-cpan (https://github.com/rehsack/meta-cpan) and Packager::Utils (https://github.com/rehsack/Packager-Utils) in Fedora

Comment 1 Petr Šabata 2015-07-22 13:19:41 UTC
Nothing really new here so I'll be brief.  I explained all these in the other review :)   I'll assume this one is going into EL6+ as well.

* The BuildRoot tag can be dropped.

* The perl version constraint can be dropped.

* Missing buildtime dependencies: coreutils, findutils, make
  All of these are called in the specfile.

* Missing perl buildtime dependencies:
  - base, lib/File/Find/Rule/Age.pm:8
  - Carp, lib/File/Find/Rule/Age.pm:10
  - File::stat, lib/File/Find/Rule/Age.pm:12
  - FindBin, t/01-legacy.t:6 t/02-accessed.t:6 t/02-created.t:6 t/02-modified.t:6
  - strict, Makefile.PL:1
  - warnings, Makefile.PL:2

 The lib/* and t/* deps are needed because you run the test suite (good!).

* You should filter out the autogenerated unversioned runtime dependencies on DateTime, File::Find::Rule and Params::Util.  For example like so:

%global __requires_exclude ^perl\\(DateTime|File::Find::Rule|Params::Util\\)$

* There's no need to clean the buildroot (line 40), remove the emtpy directories (line 45), for the %clean section (lines 52-53) or for %defattr (line 56).

* You may substitute PERL_INSTALL_ROOT with DESTDIR.

* Don't package upstream distribution metadata, META.json, in %doc.

* Correct the changelog header (missing e-mail address).

Comment 3 Petr Šabata 2015-07-28 14:10:46 UTC
Okay, that's better.
A few more notes, however:

* Sort your dependencies; they will be easier to read and you'll be less likely to miss something or list it twice. (`base' and `Carp', I'm looking at you!)

* You still needlessly remove empty directories in %install, now on line 54.

* You added some trailing whitespace, lines 36 and 69.  That's just bad taste ;)

* It looks like you forgot to bump the release number; now you have two changelog entries for one VR.

Comment 5 Petr Šabata 2015-07-29 13:32:31 UTC
(In reply to Tim Orling from comment #4)
> copr still failing for rawhide ppc:
> https://copr-be.cloud.fedoraproject.org/results/ttorling/perl-meta-cpan-
> support//fedora-rawhide-ppc64le/perl-File-Find-Rule-Age-0.302-3.fc23
> This failure does not appear to be package dependent, but rather build
> system.

I agree.  It doesn't even get to the build phase.

You've adressed everything I've pointed out.  I'm approving this package.

Comment 6 Tim Orling 2015-07-29 14:05:45 UTC
New Package SCM Request
Package Name: perl-File-Find-Rule-Age
Short Description: Rule to match on file age
Upstream URL: http://search.cpan.org/dist/File-Find-Rule-Age/
Owners: ttorling psabata
Branches: f21 f22 f23 el6 epel7
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2015-07-29 16:57:02 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2015-07-30 13:35:28 UTC
perl-File-Find-Rule-Age-0.302-3.el7 has been submitted as an update for Fedora EPEL 7.

Comment 9 Fedora Update System 2015-07-30 13:37:07 UTC
perl-File-Find-Rule-Age-0.302-3.el6 has been submitted as an update for Fedora EPEL 6.

Comment 10 Fedora Update System 2015-07-30 13:38:18 UTC
perl-File-Find-Rule-Age-0.302-3.fc23 has been submitted as an update for Fedora 23.

Comment 11 Fedora Update System 2015-07-30 13:39:43 UTC
perl-File-Find-Rule-Age-0.302-3.fc22 has been submitted as an update for Fedora 22.

Comment 12 Fedora Update System 2015-07-30 13:41:40 UTC
perl-File-Find-Rule-Age-0.302-3.fc21 has been submitted as an update for Fedora 21.

Comment 13 Fedora Update System 2015-08-10 10:02:24 UTC
perl-File-Find-Rule-Age-0.302-3.fc22 has been pushed to the Fedora 22 stable repository.

Comment 14 Fedora Update System 2015-08-10 10:05:04 UTC
perl-File-Find-Rule-Age-0.302-3.fc23 has been pushed to the Fedora 23 stable repository.

Comment 15 Fedora Update System 2015-08-10 10:06:37 UTC
perl-File-Find-Rule-Age-0.302-3.fc21 has been pushed to the Fedora 21 stable repository.

Comment 16 Fedora Update System 2015-08-17 19:07:55 UTC
perl-File-Find-Rule-Age-0.302-3.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 17 Fedora Update System 2015-08-17 19:07:59 UTC
perl-File-Find-Rule-Age-0.302-3.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.