Spec URL: https://ttorling.fedorapeople.org/perl-File-Find-Rule-Age/perl-File-Find-Rule-Age.spec SRPM URL: https://ttorling.fedorapeople.org/perl-File-Find-Rule-Age/perl-File-Find-Rule-Age-0.302-1.fc23.src.rpm Description: File::Find::Rule::Age makes it easy to search for files based on their age. DateTime and File::stat are used to do the behind the scenes work, with File::Find::Rule doing the Heavy Lifting Fedora Account System Username:ttorling koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10337931 copr: https://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/monitor/ THis is the second of four new packages needed to support meta-cpan (https://github.com/rehsack/meta-cpan) and Packager::Utils (https://github.com/rehsack/Packager-Utils) in Fedora
Nothing really new here so I'll be brief. I explained all these in the other review :) I'll assume this one is going into EL6+ as well. * The BuildRoot tag can be dropped. * The perl version constraint can be dropped. * Missing buildtime dependencies: coreutils, findutils, make All of these are called in the specfile. * Missing perl buildtime dependencies: - base, lib/File/Find/Rule/Age.pm:8 - Carp, lib/File/Find/Rule/Age.pm:10 - File::stat, lib/File/Find/Rule/Age.pm:12 - FindBin, t/01-legacy.t:6 t/02-accessed.t:6 t/02-created.t:6 t/02-modified.t:6 - strict, Makefile.PL:1 - warnings, Makefile.PL:2 The lib/* and t/* deps are needed because you run the test suite (good!). * You should filter out the autogenerated unversioned runtime dependencies on DateTime, File::Find::Rule and Params::Util. For example like so: %global __requires_exclude ^perl\\(DateTime|File::Find::Rule|Params::Util\\)$ * There's no need to clean the buildroot (line 40), remove the emtpy directories (line 45), for the %clean section (lines 52-53) or for %defattr (line 56). * You may substitute PERL_INSTALL_ROOT with DESTDIR. * Don't package upstream distribution metadata, META.json, in %doc. * Correct the changelog header (missing e-mail address).
Spec URL: https://ttorling.fedorapeople.org/perl-File-Find-Rule-Age/perl-File-Find-Rule-Age.spec SRPM URL: https://ttorling.fedorapeople.org/perl-File-Find-Rule-Age/perl-File-Find-Rule-Age-0.302-1.fc23.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10494895 This package has also built successfully on epel6 and epel7 on copr. http://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/build/103860/ http://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/build/105870/
Okay, that's better. A few more notes, however: * Sort your dependencies; they will be easier to read and you'll be less likely to miss something or list it twice. (`base' and `Carp', I'm looking at you!) * You still needlessly remove empty directories in %install, now on line 54. * You added some trailing whitespace, lines 36 and 69. That's just bad taste ;) * It looks like you forgot to bump the release number; now you have two changelog entries for one VR.
SPEC URL: https://ttorling.fedorapeople.org/perl-File-Find-Rule-Age/perl-File-Find-Rule-Age.spec SRPM URL: https://ttorling.fedorapeople.org/perl-File-Find-Rule-Age/perl-File-Find-Rule-Age-0.302-3.fc23.src.rpm Git URL: https://fedorapeople.org/cgit/ttorling/public_git/perl-File-Find-Rule-Age.git/ koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10518459 copr: https://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/build/106070/ https://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/build/106071/ copr still failing for rawhide ppc: https://copr-be.cloud.fedoraproject.org/results/ttorling/perl-meta-cpan-support//fedora-rawhide-ppc64le/perl-File-Find-Rule-Age-0.302-3.fc23 This failure does not appear to be package dependent, but rather build system.
(In reply to Tim Orling from comment #4) > copr still failing for rawhide ppc: > https://copr-be.cloud.fedoraproject.org/results/ttorling/perl-meta-cpan- > support//fedora-rawhide-ppc64le/perl-File-Find-Rule-Age-0.302-3.fc23 > > This failure does not appear to be package dependent, but rather build > system. I agree. It doesn't even get to the build phase. You've adressed everything I've pointed out. I'm approving this package.
New Package SCM Request ======================= Package Name: perl-File-Find-Rule-Age Short Description: Rule to match on file age Upstream URL: http://search.cpan.org/dist/File-Find-Rule-Age/ Owners: ttorling psabata Branches: f21 f22 f23 el6 epel7 InitialCC: perl-sig
Git done (by process-git-requests).
perl-File-Find-Rule-Age-0.302-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-File-Find-Rule-Age-0.302-3.el7
perl-File-Find-Rule-Age-0.302-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-File-Find-Rule-Age-0.302-3.el6
perl-File-Find-Rule-Age-0.302-3.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/perl-File-Find-Rule-Age-0.302-3.fc23
perl-File-Find-Rule-Age-0.302-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-File-Find-Rule-Age-0.302-3.fc22
perl-File-Find-Rule-Age-0.302-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-File-Find-Rule-Age-0.302-3.fc21
perl-File-Find-Rule-Age-0.302-3.fc22 has been pushed to the Fedora 22 stable repository.
perl-File-Find-Rule-Age-0.302-3.fc23 has been pushed to the Fedora 23 stable repository.
perl-File-Find-Rule-Age-0.302-3.fc21 has been pushed to the Fedora 21 stable repository.
perl-File-Find-Rule-Age-0.302-3.el7 has been pushed to the Fedora EPEL 7 stable repository.
perl-File-Find-Rule-Age-0.302-3.el6 has been pushed to the Fedora EPEL 6 stable repository.