Spec URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-Pluggable.spec SRPM URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-Pluggable-0.003-1.fc23.src.rpm Description: This module allows a class consuming several roles based on rules passed to Module::Pluggable::Object. Fedora Account System Username: ttorling koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10338401 copr: https://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/monitor/ This is the fourth of four new packages to support meta-cpan (https://github.com/rehsack/meta-cpan) and Packager::Utils (https://github.com/rehsack/Packager-Utils) for Fedora. I am in need of a sponsor.
Based on my feedback from the other two reviews, try to fix this package first. I would just repeat myself and it will be a good exercise for you :)
Spec URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-Pluggable.spec SRPM URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-Pluggable-0.003-2.fc23.src.rpm Git URL: https://fedorapeople.org/cgit/ttorling/public_git/perl-MooX-Roles-Pluggable.git/ koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10613754 copr: https://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/build/107214/ It appears Module::Pluggable, Moo, Moo::Role are not in EPEL6 It appears Moo and Moo::Role are not in EPEL7 Many dependencies for Moo in EPEL7 are not met: http://koji.fedoraproject.org/koji/taskinfo?taskID=10613995
(In reply to Tim Orling from comment #2) > It appears Module::Pluggable, Moo, Moo::Role are not in EPEL6 > It appears Moo and Moo::Role are not in EPEL7 > > Many dependencies for Moo in EPEL7 are not met: > http://koji.fedoraproject.org/koji/taskinfo?taskID=10613995 I'll consider this Fedora only then. * Unless you plan to package Moo for EL7, you may use EU::MM 6.76+ NO_PACKLIST feature, available in all stable Fedoras: BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 If you do this, you won't need to remove .packlist files in %install. This will also allow you to drop the dependencies on coreutils and findutils. * Missing a build deps -- perl(lib), from t/01-basic.t:10 and t/02-fatal.t:10, and perl(Module::Pluggable::Object) from lib/MooX/Roles/Pluggable.pm:7. That seems to be all. Good! :)
Spec URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-Pluggable.spec SRPM URL: https://ttorling.fedorapeople.org/perl-MooX-Roles-Pluggable/perl-MooX-Roles-Pluggable-0.003-3.fc23.src.rpm Git URL: https://fedorapeople.org/cgit/ttorling/public_git/perl-MooX-Roles-Pluggable.git/ koji: rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10680276 f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10680278 f22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10680280 f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10680282 Thank you for reviewing for Fedora only, that was what was intended.
Okay, looks fine now. Approving.
New Package SCM Request ======================= Package Name: perl-MooX-Roles-Pluggable Short Description: Moo eXtension for pluggable roles Upstream URL: http://search.cpan.org/dist/MooX-Roles-Pluggable/ Owners: ttorling psabata Branches: f21 f22 f23 InitialCC: perl-sig
Git done (by process-git-requests).
perl-MooX-Roles-Pluggable-0.003-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-MooX-Roles-Pluggable-0.003-3.fc21
perl-MooX-Roles-Pluggable-0.003-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-MooX-Roles-Pluggable-0.003-3.fc22
perl-MooX-Roles-Pluggable-0.003-3.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/perl-MooX-Roles-Pluggable-0.003-3.fc23
perl-MooX-Roles-Pluggable-0.003-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
perl-MooX-Roles-Pluggable-0.003-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
perl-MooX-Roles-Pluggable-0.003-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.