Spec URL: https://dl.dropboxusercontent.com/u/1730743/RPM/python-ironic-inspector-client.spec SRPM URL: https://dl.dropboxusercontent.com/u/1730743/RPM/python-ironic-inspector-client-1.0.1-1.fc22.src.rpm Description: Python client and CLI tool for Ironic Inspector This package was split away from openstack-ironic-discoverd upstream during its rename to ironic-inspector. Fedora Account System Username: divius Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10351986
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 1 files have unknown license. Detailed output of licensecheck in /tmp/1242896-python-ironic-inspector-client/licensecheck.txt [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [X]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.10 starting (python version = 3.4.2)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata INFO: enabled ccache Mock Version: 1.2.10 INFO: Mock Version: 1.2.10 Finish: chroot init INFO: installing package(s): /tmp/1242896-python-ironic-inspector-client/results/python-ironic-inspector-client-1.0.1-1.fc21.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/yum-deprecated --installroot /var/lib/mock/fedora-21-x86_64/root/ --releasever 21 install /tmp/1242896-python-ironic-inspector-client/results/python-ironic-inspector-client-1.0.1-1.fc21.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: python-ironic-inspector-client-1.0.1-1.fc21.noarch.rpm python-ironic-inspector-client-1.0.1-1.fc21.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python-ironic-inspector-client (rpmlib, GLIBC filtered): python(abi) python-cliff python-openstackclient python-oslo-i18n python-oslo-utils python-requests python-six Provides -------- python-ironic-inspector-client: python-ironic-inspector-client Source checksums ---------------- https://pypi.python.org/packages/source/p/python-ironic-inspector-client/python-ironic-inspector-client-1.0.1.tar.gz : CHECKSUM(SHA256) this package : 6d80745f09726e16307729a003c68a7c04737968ee15607e2099a64a7d832016 CHECKSUM(SHA256) upstream package : 6d80745f09726e16307729a003c68a7c04737968ee15607e2099a64a7d832016 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1242896 Buildroot used: fedora-21-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 - According to the page on pypi, this package support python 3. However, some of its dependencies (like python-openstackclient) only exist for python 2. Do you have any information on that? - Package contains tests. Can you launch them?
Hi, sorry for late reply. - You've tried to install the package on F21. I'm pretty sure it does not have all the dependencies. The following succeeds: sudo mock -r fedora-rawhide-x86_64 -i https://kojipkgs.fedoraproject.org//work/tasks/1987/10351987/python-ironic-inspector-client-1.0.1-1.fc23.noarch.rpm - By python 3 support upstream means unit tests pass on Python 3 mostly. As python-openstackclient is only involved in a shell script, it's not a big deal for tests. But we probably can't declare Python 3 compatibility until it's fixed. - `python -m unittest discover ironic_inspector_client.test` works, though requires python-mock (not sure how to handle it, as it's not a runtime dependency for the project itself). Thanks!
(In reply to Dmitry Tantsur from comment #2) > - You've tried to install the package on F21. I'm pretty sure it does not > have all the dependencies. The following succeeds: > sudo mock -r fedora-rawhide-x86_64 -i > https://kojipkgs.fedoraproject.org//work/tasks/1987/10351987/python-ironic- > inspector-client-1.0.1-1.fc23.noarch.rpm Just tested with: fedora-review -b 1242896 -m fedora-rawhide-x86_64 it works fine. > > - By python 3 support upstream means unit tests pass on Python 3 mostly. As > python-openstackclient is only involved in a shell script, it's not a big > deal for tests. But we probably can't declare Python 3 compatibility until > it's fixed. OK, this was just to know. > > - `python -m unittest discover ironic_inspector_client.test` works, though > requires python-mock (not sure how to handle it, as it's not a runtime > dependency for the project itself). You should add the dependency as BuildRequires. Once this is done, I will approve the package.
Hi! I can add BuildRequires but I can't run tests in %check section, as it requires all the dependencies to be installed. Or did you mean I just add BuildRequires without touching %check?
> I can add BuildRequires but I can't run tests in %check section, as it requires all the dependencies to be installed. You can add these dependencies as BR so tests can execute. Given the number of dependencies, this is not a big deal.
Before I forget, python guidelines changed recently. Python2 packages are row subpackages of the main package (as are python3 packages). They also need a Requires. See: https://fedoraproject.org/wiki/Packaging:Python for the macros that will help you.
Thanks, I've updated package, build http://koji.fedoraproject.org/koji/taskinfo?taskID=10613211 However, seems like %python_provide macro does not exist in rawhide. Should I insert Provides: python-ironic-inspector-client manually?
> However, seems like %python_provide macro does not exist in rawhide. Should I insert Provides: python-ironic-inspector-client manually? It does, your package wouldn't have built on koji otherwise. Are you speaking of f21? Last time I checked they were in testing. But you can use a good old Provides in the mean time. When you created the python2 subpackage, you put Requires and Conflicts after the %description. rpmlint complains about this: Rpmlint ------- Checking: python2-ironic-inspector-client-1.0.1-1.fc24.noarch.rpm python-ironic-inspector-client-1.0.1-1.fc24.src.rpm python2-ironic-inspector-client.noarch: W: spelling-error %description -l en_US oslo -> solo, Oslo python2-ironic-inspector-client.noarch: W: spelling-error %description -l en_US utils -> tills python2-ironic-inspector-client.noarch: W: spelling-error %description -l en_US openstackclient -> happenstance python2-ironic-inspector-client.noarch: W: spelling-error %description -l en_US discoverd -> discovers, discover, discovered python2-ironic-inspector-client.noarch: W: tag-in-description C Requires: python2-ironic-inspector-client.noarch: W: tag-in-description C Requires: python2-ironic-inspector-client.noarch: W: tag-in-description C Requires: python2-ironic-inspector-client.noarch: W: tag-in-description C Requires: python2-ironic-inspector-client.noarch: W: tag-in-description C Requires: python2-ironic-inspector-client.noarch: W: tag-in-description C Requires: python2-ironic-inspector-client.noarch: W: tag-in-description C Conflicts: 2 packages and 0 specfiles checked; 0 errors, 11 warnings. Please fix this by moving Requires and Conflics in %package
Thanks for review, updated. Build http://koji.fedoraproject.org/koji/taskinfo?taskID=10634457
Just spotted: please use %license for LICENSE as described here: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text PS: No need to always as for needinfo, as the reviewer I am in the CC list of this bug.
done, build http://koji.fedoraproject.org/koji/taskinfo?taskID=10658944
Looks good, approved.
New Package SCM Request ======================= Package Name: python-ironic-inspector-client Short Description: Python client and CLI tool for Ironic Inspector Upstream URL: https://launchpad.net/python-ironic-inspector-client Owners: divius Branches: f23 InitialCC:
Git done (by process-git-requests).