Spec URL: https://wfp.fedorapeople.org/perl-Algorithm-LUHN.spec SRPM URL: https://wfp.fedorapeople.org/perl-Algorithm-LUHN-1.01-1.fc22.src.rpm Description: This module calculates the Modulus 10 Double Add Double checksum, also known as the LUHN Formula. This algorithm is used to verify credit card numbers and Standard & Poor's security identifiers such as CUSIP's and CSIN's. Fedora Account System Username: wfp
This is an informal review since, I have no rights of performing official reviews and it is also my first package review attempt, I hope it helps: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/packager/package_reviews/1243507-perl- Algorithm-LUHN/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Algorithm(perl-Algorithm-Diff) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Algorithm-LUHN-1.01-1.fc22.noarch.rpm perl-Algorithm-LUHN-1.01-1.fc22.src.rpm perl-Algorithm-LUHN.noarch: W: spelling-error Summary(en_US) checksum -> check sum, check-sum, checks um perl-Algorithm-LUHN.noarch: W: spelling-error %description -l en_US checksum -> check sum, check-sum, checks um perl-Algorithm-LUHN.src: W: spelling-error Summary(en_US) checksum -> check sum, check-sum, checks um perl-Algorithm-LUHN.src: W: spelling-error %description -l en_US checksum -> check sum, check-sum, checks um 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- perl-Algorithm-LUHN.noarch: W: spelling-error Summary(en_US) checksum -> check sum, check-sum, checks um perl-Algorithm-LUHN.noarch: W: spelling-error %description -l en_US checksum -> check sum, check-sum, checks um perl-Algorithm-LUHN.noarch: W: invalid-url URL: http://search.cpan.org/dist/Algorithm-LUHN/ <urlopen error [Errno -3] Temporary failure in name resolution> 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- perl-Algorithm-LUHN (rpmlib, GLIBC filtered): perl perl(:MODULE_COMPAT_5.20.2) perl(Exporter) perl(strict) perl(warnings) Provides -------- perl-Algorithm-LUHN: perl(Algorithm::LUHN) perl-Algorithm-LUHN Source checksums ---------------- http://www.cpan.org/authors/id/N/NE/NEILB/Algorithm-LUHN-1.01.tar.gz : CHECKSUM(SHA256) this package : 08f2b94a0b5e126d6abba746fd45625db9bcfc948888c395e8f7d1bacd10db69 CHECKSUM(SHA256) upstream package : 08f2b94a0b5e126d6abba746fd45625db9bcfc948888c395e8f7d1bacd10db69 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/bin/fedora-review -b 1243507 Buildroot used: fedora-22-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Looks OK to me
Bill, Athos, there are actually some issues with this package. * The perl version constraint (buildtime dependency) has no practical efect. * The package calls `find', `make', `rm' and `rmdir', yet doesn't depend on packages providing these commands. Note Fedora Packaging Guidelines no longer list any packages guaranteed to be present in every buildroot. Add `coreutils', `findutils' and `make' as build dependencies. * The minimum required version of ExtUtils::MakeMaker is 6.30. (Makefile.PL:8) * Some perl build dependencies are missing: - strict, used in Makefile.PL, tests and the tested code - Test, used in tests - warnings, used in Makefile.PL and the tested code * The Exporter runtime dependency is autodetected and doesn't need to be explicitly Require'd. * Modern EU::MM supports DESTDIR. This can be used in place of PERL_INSTALL_ROOT. * Line 34 is unnecessary. (find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;) * The `dist.ini' file has zero value for the end user and I would advise against packaging it.
Updated to hopefully address these concerns. Spec URL: https://wfp.fedorapeople.org/perl-Algorithm-LUHN.spec SRPM URL: https://wfp.fedorapeople.org/perl-Algorithm-LUHN-1.01-2.fc22.src.rpm
I just realized that I removed perl from the BuildRequires instead of just removing the version requirement. Do I need to add that back or is it ok to assume the other perl BuildRequires will take care of it?
(In reply to Bill Pemberton from comment #4) > I just realized that I removed perl from the BuildRequires instead of just > removing the version requirement. Do I need to add that back or is it ok to > assume the other perl BuildRequires will take care of it? Add it back. Although it's almost certain something will pull perl into the buildroot, you can never know. And since you're using it yourself, you need to buildrequire it. Anyhow, I trust you'll add it before pushing the package. I ack you've fixed everything I've pointed out so I'm going to approve this now :)
New Package SCM Request ======================= Package Name: perl-Algorithm-LUHN Short Description: Calculate the Modulus 10 Double Add Double checksum Upstream URL: http://search.cpan.org/dist/Algorithm-LUHN/ Owners: wfp Branches: f22 f23 el6 epel7 InitialCC: perl-sig
Git done (by process-git-requests).
Package Change Request ====================== Package Name: perl-Algorithm-LUHN New Branches: el6 epel7 Owners: wfp
I didn't see these branches initially, I see them now. I was impatient. Apologizes for the noise.
perl-Algorithm-LUHN-1.01-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Algorithm-LUHN-1.01-3.el6
perl-Algorithm-LUHN-1.01-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Algorithm-LUHN-1.01-3.el7
perl-Algorithm-LUHN-1.01-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-Algorithm-LUHN-1.01-3.fc22
perl-Algorithm-LUHN-1.01-3.el7 has been pushed to the Fedora EPEL 7 stable repository.
perl-Algorithm-LUHN-1.01-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
perl-Algorithm-LUHN-1.01-3.fc22 has been pushed to the Fedora 22 stable repository.