RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1243929 - No way to override CSS styling on nav area text items
Summary: No way to override CSS styling on nav area text items
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: anaconda
Version: 7.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: David Shea
QA Contact: Release Test Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-16 15:33 UTC by Máirín Duffy
Modified: 2016-11-03 23:08 UTC (History)
3 users (show)

Fixed In Version: anaconda-21.48.22.57-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 23:08:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2016:2158 0 normal SHIPPED_LIVE anaconda bug fix and enhancement update 2016-11-03 13:13:55 UTC

Description Máirín Duffy 2015-07-16 15:33:52 UTC
Description of problem:

So there are a few bits of text in the nav area of Anaconda both on the hub, spoke, and standalone windows:

- the name of the screen
- the name of the product
- (optional) the beta/alpha/testing status of the product

This text right now in CSS isn't really style-able in CSS because each individual text item doesn't have an ID you can use to access it, plus some of the properties of the text are hard coded in such a way CSS can't override it:

https://github.com/rhinstaller/anaconda/blob/rhel7-branch/widgets/src/BaseWindow.c#L795

The issue causing us to need to change this text was the theming for the Gluster Storage 3 product that uses RHEL 7.2, which involved the bright red 'testing' text running over a bright orange background color and being pretty mean on the eyes. If I could have toned down the red a bit, it would have helped, but there was no way to do it.

(Here's an example of some of the playing around we had to do to get the text to look better. You can see how eye-cheese-grating the red can be given particular background colors in the theme! http://file.bos.redhat.com/duffy/temp/anaconda-gray.gif )

In experimenting with various potential ways to try to solve the problem in CSS alone given the current constraints, I also thought that adding a (very subtle!) drop shadow to the name of the screen and the name of the product might look nice for future versions of anaconda. Unfortunately, without IDs to address only those bits of text, the drop shadow gets applied to the testing status text line as well, and since that line is bold the dropshadow gets bolded too and looks really bad.

So here's what I would like very much as a future anaconda enhancement to make theming easier for us :)  -

- removing the hard-coded styling in BaseWindow.c and instead implementing those styling decisions in the CSS
- adding IDs to each of those text bits such that individual chunks of text in the nav area can be addressed individually with CSS selectors.
- my suggested ids for the text bits (since they correspond to the GtkWidget variable names in the C I thought these would be most intuitive):
  - name-label (for screen name)
  - distro-label (for product name)
  - beta-label (for testing status)

Comment 2 David Cantrell 2015-07-17 17:59:33 UTC
This sounds reasonable, but I'm moving it to the 7.3 planning list.  For a couple of reasons:

1) We're pretty loaded down with changes for 7.2 and I want to avoid introducing any new RFE stuff now since we're still fighting nightly testing fires with master backports and other patches.

2) I'm not sure what is and is not possible on the CSS front and I want that explored during 7.3 development.

Comment 3 David Shea 2016-02-22 16:35:59 UTC
https://github.com/rhinstaller/anaconda/pull/518

I prefixed things with anaconda- where I could since a lot of the names would end up being pretty generic, and I didn't want to create the potential of interfering with other widgets.

As part of the pull request I added a list of the CSS IDs and classes to the documentation comments. Let me know if you need that information in a different form or if other widgets need to be accessible. I aimed for all of the non-container widgets (labels and button and icons and such) in all of the anaconda types.

Comment 5 Michal Kovarik 2016-08-16 11:35:01 UTC
Hello Máirín,
could you check if changes satisfy your requirements?

Comment 6 Máirín Duffy 2016-08-16 12:39:39 UTC
Hi Michal, looks great - thanks David!

Comment 8 errata-xmlrpc 2016-11-03 23:08:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-2158.html


Note You need to log in before you can comment on or make changes to this bug.