Hide Forgot
Description of problem: The current version in rawhide is 1.0.1-5.fc23 while upstream is now at 1.1.4 Could you see about updating rawhide ? (Note: 1.1.3 was broken, 1.1.4 looks better, it does require setuptools >= 17.1 but rawhide seems to be up to date for this)
Hi, mock 1.3.0 was release on 2015-07-23 (https://pypi.python.org/pypi/mock/1.3.0). Can you please update rawhide?
Hi, I managed to do the update. Can you push it on rawhide? - SPEC: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-mock.spec - SRPMS: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-mock-1.3.0-1.fc24.src.rpm - koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=11491520
I updated spec file and for python3 build it's only passing for rawhide not for f23 branch because of python3-pbr package is not available for f23 branch. f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=11493605 What would be better option, should be update python2 package (python3 flag disabled) and for other branch and rawhide have both packages?
> I updated spec file and for python3 build it's only passing for rawhide not > for f23 branch because of python3-pbr package is not available for f23 > branch. @mrunge I'll update PBR in f23, we were not doing that b/c upsteam OpenStack stable/kilo branch (which f23 corresponds to) has upper cap pbr>=0.6,!=0.7,<1.0 https://github.com/openstack/requirements/blob/stable/kilo/global-requirements.txt#L91 but latest PBR should work, I'll confirm it in -override before pushing the update.
openstack-keystone f23 scratch rebuild with python-pbr-1.8.1-1.fc23 in buildroot worked
Latest version of mock need 'funcsigs'[0] which is not built in fedora and also failing rawhide bits[1] [0] https://github.com/testing-cabal/mock/blob/master/requirements.txt#L1 [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=12021349
To unblock the situation, I submitted a package review for funcsigs. It should be a trivial one.
Anything I can do to help move this along?
As per my understanding mock is now core module for python3, for python2 I will update it to latest version.
Great, thanks for the update.
Any update here?
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase
(In reply to Praveen Kumar from comment #9) > As per my understanding mock is now core module for python3, for python2 I > will update it to latest version. mock is available in py3 in different namespace unittest.mock so having python3-mock is fine and should be kept to not break existing code using it Also, upstream mock says "This package contains a rolling backport of the standard library mock code compatible with Python 2.6 and up, and 3.2 and up." so there is value to provide those updates ahead of python core libs update.
It looks like Haïkel already updated this for rawhide, I guess, this can be closed then?
Can we have this in f24? I just tried to build a package that requires python-mock 1.3.0 with fedpkg mockbuild and I got this error: Error: No Package found for python-mock >= 1.3.0 Error: No Package found for python3-mock >= 1.3.0 I'd like to avoid waiting for f25 before getting this update.
just pushed it to f24 and submitted a build http://koji.fedoraproject.org/koji/taskinfo?taskID=13225011
Can we get a newer python-mock in F23? Version 1.0.1 and above fixes a bug I care about: https://github.com/testing-cabal/mock/issues/190 Also please note that there is now mock 2.0.0 available: https://github.com/testing-cabal/mock/releases But for F23, getting at least 1.1.0 would help.
mock_open() in mock 1.0.1 doesn't mimic builtin open() properly. read() of builtin open() reads a file (or part of it) and keeps pointer into file, and so without seek you cannot read() whole file more than one time. However the read() of mock_open() can be called again and again. Python xml parser reads file in an infinite loop by chunks using read(65536) and breaks the loop when nothing was read. Unfortunately the behaviour of mock 1.0.1 causes infinite loop and breaks the xml parsing. Please, bump the version in F23 to at least 1.1.0
Praveen, is that something you can do?
Apologize for very late response. http://koji.fedoraproject.org/koji/buildinfo?buildID=765092
PyPi mock is now at 2.0 https://pypi.python.org/pypi/mock One of the tests a package I maintain (python-acme) is calling assert_called_once() which was added here: https://github.com/testing-cabal/mock/issues/342 Naturally I can skip the test, but of course I'd rather not skip upstream tests where possible. Can you please issue an update to rawhide/f24/f23 with the new version?
Changing the blocker to point to the funcsigs 1.0+ bug as mock 2.0 needs that and the review was only against the old 0.4 revision so not valid for this bug.
I will update this package tomorrow morning and create update request.
I updated spec and it build fine with rawhide ( http://koji.fedoraproject.org/koji/buildinfo?buildID=772640) but failed in f24 because funcsigs 1.0+ not updated for f24 branch ( http://koji.fedoraproject.org/koji/packageinfo?packageID=21510 ).
python-mock-2.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-439ff07550
python-mock-2.0.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e3a7ea1156
python-mock-2.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e3a7ea1156
python-mock-2.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-439ff07550
python-mock-2.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
python-mock-2.0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.