Bug 1244509 - Review Request: perl-DBIx-Class-Schema-Diff - Identify differences between two DBIx::Class schemas
Summary: Review Request: perl-DBIx-Class-Schema-Diff - Identify differences between tw...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-19 13:45 UTC by Emmanuel Seyman
Modified: 2015-07-22 07:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-07-22 07:58:40 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2015-07-19 13:45:16 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-Schema-Diff/perl-DBIx-Class-Schema-Diff.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-Schema-Diff/perl-DBIx-Class-Schema-Diff-1.03-1.fc22.src.rpm
Description:
General-purpose schema differ for DBIx::Class to identify changes between
two DBIC Schemas. Currently tracks added/deleted/changed events and deep
diffing across 5 named types of source data.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 1 Jitka Plesnikova 2015-07-20 11:12:40 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-DBIx-Class-Schema-Diff-1.03-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Array::Diff)
      1 perl(DBIx::Class::Schema::Diff::Filter)
      1 perl(DBIx::Class::Schema::Diff::InfoPacket)
      1 perl(DBIx::Class::Schema::Diff::Schema)
      1 perl(DBIx::Class::Schema::Diff::SchemaData)
      1 perl(DBIx::Class::Schema::Diff::Source)
      1 perl(Data::Dumper::Concise)
      1 perl(Hash::Layout)
      1 perl(JSON)
      1 perl(List::MoreUtils)
      1 perl(List::Util)
      1 perl(Module::Runtime)
      1 perl(Moo)
      1 perl(Moo::Role)
      1 perl(Path::Class)
      1 perl(Scalar::Util)
      1 perl(Try::Tiny)
      1 perl(Types::Standard)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-DBIx-Class-Schema-Diff-1.03-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(DBIx::Class::Schema::Diff) = 1.03
      1 perl(DBIx::Class::Schema::Diff::Filter)
      1 perl(DBIx::Class::Schema::Diff::InfoPacket)
      1 perl(DBIx::Class::Schema::Diff::Role::Common)
      1 perl(DBIx::Class::Schema::Diff::Schema)
      1 perl(DBIx::Class::Schema::Diff::SchemaData)
      1 perl(DBIx::Class::Schema::Diff::Source)
      1 perl-DBIx-Class-Schema-Diff = 1.03-1.fc24
Binary provides are Ok.

$ rpmlint ./perl-DBIx-Class-Schema-Diff*
perl-DBIx-Class-Schema-Diff.src: W: spelling-error Summary(en_US) schemas -> schema, sachems, schemes
perl-DBIx-Class-Schema-Diff.noarch: W: spelling-error Summary(en_US) schemas -> schema, sachems, schemes
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok


TODO: Please add build-require 'make'

Otherwise package is good.
APPROVED

Comment 2 Emmanuel Seyman 2015-07-20 16:09:15 UTC
(In reply to Jitka Plesnikova from comment #1)
> 
> TODO: Please add build-require 'make'

Done.
Thank you for the review, Jikta. Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-DBIx-Class-Schema-Diff
Short Description: Identify differences between two DBIx::Class schemas
Upstream URL: http://search.cpan.org/dist/DBIx-Class-Schema-Diff/
Owners: eseyman
Branches: f22 f23
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2015-07-20 17:25:07 UTC
Git done (by process-git-requests).

Comment 4 Emmanuel Seyman 2015-07-22 07:58:40 UTC
Released in rawhide.


Note You need to log in before you can comment on or make changes to this bug.