Hi,
on clean new installation I can't reproduce it and everything is ok with big nice characters.

Have you upgraded all packages correctly? Isn't there some old one? Tested on x86_64 architecture. In my point of view that's probably not bug inside git-gui. The most probably is mistake caused due to some mistake during upgrade. Everthing else is OK? Try reinstall git* packages (yes that's desparate experiment). Can you check list of installed packages if there is some package which isn't available in F22 repository?

Note: tested on i686 as well

Hi,

Thanks to test in can reproduce ....

For update, 
Doing it by fedup :
fedup --network 22 and distro-sync after.

# dnf list installed git*
Last metadata expiration check performed 0:13:10 ago on Wed Jul 22 08:32:16 2015.
Paquets installés
Paquets installés
GitPython.noarch    1.0.1-1.fc22    @System
git.i686            2.4.3-4.fc22    @System
git-gui.noarch      2.4.3-4.fc22    @System
gitg.i686           3.16.1-1.fc22   @System
gitg-libs.i686      3.16.1-1.fc22   @System
gitk.noarch         2.4.3-4.fc22    @System

(din't have gitg and gitk before update, instaling to do some git commit :) ).
Reinstall git+git-gui : no change (dnf reinstall git git-gui)
Test with a new user : no change

Surely some issue with a default font somewhere ... but seems to be only in git-gui ? No specific preferences for git-gui ?

I tried upgrade with fedup from F21 to F22, but I can't finish upgrade, so I can't reproduce it in this way.

Maybe it's stupid question, but what is your settings of fonts inside git-gui? If there is set big enough, you should probably check if font really exists and is installed correctly. Or set some else font.

Really not stupid ... but problem is : i don't remind what is the font before update, remind it was set to 12 but ... name. And i can't update config without font ....

For terminable accessible config
$ git config -l --system
fatal: unable to read config file '/etc/gitconfig': Aucun fichier ou dossier de ce type

$ git config -l
core.editor=vim
core.excludesfile=/home/shnoulle/.gitignore
core.autocrlf=input
giggle.main-window-maximized=false
giggle.main-window-geometry=1202x645+1+74
giggle.history-view-vpane-position=329
giggle.file-view-vpane-position=334
giggle.main-window-view=HistoryView
user.name=Denis Chenu
user.email=myemail
gui.recentrepo=/home/shnoulle/Développements/GIT/Shnoulle/test
push.default=simple


Do you have an /etc/gitconfig with a new install ?
Where is the git-gui config ?????

(In reply to Shnoulle from comment #5)
> Do you have an /etc/gitconfig with a new install ?
> Where is the git-gui config ?????

http://repo.or.cz/w/git-gui.git/blob/HEAD:/lib/option.tcl#l32

I can reproduce it on F22, where I never had git-gui installed.
But I get a big font size by default.

It seems that I have a DejaVu Sans/DejaVue Sans Mono, of size 0pt by default (it does it too when I select 9 pt), It does it all the time.

If I select an other font size, it is ok.
If I set the size to 10, and modify my .gitconfig to set 9 manually, it is ok.
If I set the font size to 9 in the gui, the font config goes back to 0 pt if I select 9 for the font size.

Fixed forcing fonts in ~/.gitconfig
[gui]
	fontui = -family \"Liberation Sans\" -size 12 -weight normal -slant roman -underline 0 -overstrike 0
	fontdiff = -family \"Liberation Mono\" -size 10 -weight normal -slant roman -underline 0 -overstrike 0

Then :
- I have a problem with my default font (TkDefault ?)
- I have Courier but ?

I am on x86_64 so it is not specific to i686

Shoulle: your global config should be inside your home directory ~/.gitconfig and it's created by git when you set some global atribut - e.g.: user.name.
File /etc/gitconfig must be created manually I think.

Thanks Heldwin for info. You are right about this behaviour. It's little wierd (and for size 8 it's 8 again).

Courier it's not part of available fonts in my git-gui  - but maybe some fonts are missing in system and could be installed. You can check if you have this font installed on your system. When this can be solved in this way, I propose close this as notabug or wontfix - in case that Courier is available option inside settings.

If you think that it should be fixed and font should be changed automatically in this case, feel free to reopen.

I am not sure how this file is used, but in source code, there is a git-gui.sh file, with this:

## config defaults

set cursor_ptr arrow
font create font_ui
if {[lsearch -exact [font names] TkDefaultFont] != -1} {
        eval [linsert [font actual TkDefaultFont] 0 font configure font_ui]
        eval [linsert [font actual TkFixedFont] 0 font create font_diff]
} else {
        font create font_diff -family Courier -size 10
        catch {
                label .dummy
                eval font configure font_ui [font actual [.dummy cget -font]]
                destroy .dummy
        }
}

If I understand it correctly, it will try to use a Courier 10 by default, sometimes.
(on my system I don't have "Courier", but "Courier 10 Pitch")

You are right. I don't have even any courier font installed by default. May there could be set some another font.

@pstodulk : my workstation start update since 18 or maybe before ....

OK to close it since i'm the only one to have the issue :).

For courier:
- I have courier font
For TkDefaultFont (can be set somewhere ?)
- Deja Vu : installed : dejavu-fonts-common/dejavu-sans-fonts/dejavu-sans-mono-fonts/dejavu-serif-fonts/php-tcpdf-dejavu-sans-fonts
- BUT : have 3 Deja Vu Sans in dropdown ... something here. Seems not directly linked with git-gui.

This bug is still there in Fedora 29.  It may have been there for many releases, but I guess I haven't launched git gui in a while (since I got my 4k monitor).  On HiDPI systems you get tiny fonts for everything except the menu and fixed width content.  I came across this particular bug because I was looking at the gui-gui tcl script and noticed the same block of code as @Arnaud.  I only have "Courier 10 Pitch" as well.  I'm not sure how to set TkDefaultFont but I guess that is my next step.

I believe this is really both a tk and a git-gui bug.  tk is not setting the font size right by default and git-gui is not applying the UI font properly to widgets.

For the tk issue I created the following bug:

https://core.tcl-lang.org/tk/tktview/dccd82bdc70dc25bb6709a6c14880a92104dda43

I provided a workaround on there to set the default ttk font size, and font family as well if desired.

When I modify the "Current Branch:" label and add a "-font font_ui" parameter it looks the same as the menus, which is probably what is expected.  I've never programmed in TCL/TK before so I have no idea how to fix it properly.

Emailed the git-scm mailing list for comments on the git-gui issue regarding not setting the widget font properly.

Thanks for pushing this upstream (both with git and tcl/tk) Eric!  With the workaround you mentioned in the tcl/tk bug report, does git-gui behave reasonably?  If so, should we move this bug to the tcl/tk component?

I don't know that any of the git maintainers in Fedora spend much time using git-gui or gitk (I certainly don't).  Upstream, both projects seem to be barely maintained.

Yes with the "overriding" of the font size it looks normal.  I reduced the fonts to be the same point size as the GNOME shell default font size so it looks more correct.  It might not be a bad idea to have this patched in the tcl/tk package so others with HiDPI screens see it work as expected.  I haven't tried it on a non-hidpi screen since both my desktop and laptop have some font scale factor applied.

Alright, let's reassign this to tk and see if the tk maintainers have some thoughts on how to fix this more generally for tk apps.  (Or if they can tell this is something git-gui is doing incorrectly, of course.)

This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Created attachment 1645988 [details]
screen shot of About Git Gui dialog

I am having trouble with the git-gui fonts in a virtualbox  Fedora-31 guest system / windows host;
see the attachment about_git_gui.png above.

Pictures>uname -a
Linux localhost.localdomain 5.3.7-301.fc31.x86_64 #1 SMP Mon Oct 21 19:18:58 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Pictures>dnf info git-gui | grep '^Source'
Source       : git-2.23.0-1.fc31.src.rpm


Virtual box install program
VirtualBox-6.0.14-133895-Win.exe

I should have mentioned that I have guest additions installed in the virtual box Fedora guest.

I pinged on the previously mentioned tcl/tk bug and someone replied and mentioned that Debian/Ubuntu has already been carry this same change I made locally in their packages.  See https://sources.debian.org/patches/tk8.6/8.6.9-2/font-sizes.diff/.  Any chance we could get this patch applied to the Fedora package?

FYI, I believe git-gui/gitk might have resolved this issue at some point, but looking at the history I'm not exactly sure when or 100% sure it was.  On a fresh Fedora 31 install it looks fine now (using default fonts).  Based on Brad's comment it might have been when git was updated to 2.24.0?  Although for other tk programs this would still be an issue, so it would be good to apply the above patch anyways.

The problem I am having is restricted to my virtual box version of fedora-31.
The fonts work fine on a native version of the system but not in the virtualbox version:

virtualbox version:
>uname -a
Linux localhost.localdomain 5.3.7-301.fc31.x86_64 #1 SMP Mon Oct 21 19:18:58 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

native version:
>uname -a
Linux localhost.localdomain 5.3.7-301.fc31.x86_64 #1 SMP Mon Oct 21 19:18:58 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

The version of git is 2.23.0 on both systems.


Perhaps this means it is a bug in virtualbox and not git gui.

I think the core issue is in tk, but you should update to the current git-gui-2.24.1 to test, as Eric mentioned in comment #27 the issue doesn't seem to appear there.

(In reply to Eric Work from comment #26)
> I pinged on the previously mentioned tcl/tk bug and someone replied and
> mentioned that Debian/Ubuntu has already been carry this same change I made
> locally in their packages.  See
> https://sources.debian.org/patches/tk8.6/8.6.9-2/font-sizes.diff/.  Any
> chance we could get this patch applied to the Fedora package?

Jaroslav, any thoughts on this?

I updated to git 2.24.1 and it did not fix the fonts in the virtualbox version of

(In reply to Todd Zullinger from comment #30)
> (In reply to Eric Work from comment #26)
> > I pinged on the previously mentioned tcl/tk bug and someone replied and
> > mentioned that Debian/Ubuntu has already been carry this same change I made
> > locally in their packages.  See
> > https://sources.debian.org/patches/tk8.6/8.6.9-2/font-sizes.diff/.  Any
> > chance we could get this patch applied to the Fedora package?
> 
> Jaroslav, any thoughts on this?

Thanks, I will add this patch downstream. I didn't notice, because I don't have high DPI display :)

I applied the patch in rawhide. Are you OK with the rawhide fix only?

It would be nice to have the fix in Fedora 31 as well if possible.  I can pull just this package from rawhide if necessary.

(In reply to Eric Work from comment #34)
> It would be nice to have the fix in Fedora 31 as well if possible.  I can
> pull just this package from rawhide if necessary.

NP, I will fix it.

https://bodhi.fedoraproject.org/updates/FEDORA-2020-0437030c32

Created attachment 1652638 [details]
Before tk update

Created attachment 1652639 [details]
After tk update

As you can see from the screenshots I just attached, the font size has increased.  I'm using the default fonts for these screenshots.  You can compare the font size with the title bar to get an idea how large the font should be.  The difference would be more extreme if my font scaling was 2x instead of 1.5x.  I'd consider this fixed.

tk-8.6.8-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0437030c32

I just updated to tk-8.6.8-2.fc31, and it fixed the problem for me. Thanks!

tk-8.6.8-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

(In reply to Brad Bell from comment #24)
> I am having trouble with the git-gui fonts in a virtualbox  Fedora-31 guest
> system / windows host;
> see the attachment about_git_gui.png above.
> 
> Pictures>uname -a
> Linux localhost.localdomain 5.3.7-301.fc31.x86_64 #1 SMP Mon Oct 21 19:18:58
> UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
> 
> Pictures>dnf info git-gui | grep '^Source'
> Source       : git-2.23.0-1.fc31.src.rpm
> 
> 
> Virtual box install program
> VirtualBox-6.0.14-133895-Win.exe

This seems to be a problem with Virtualbox. I was able to fix it be selecting
the proper virtual machine and then
   Settings | Display | Enable 3D Acceleration
in the virtualbox manager program.