Spec URL: https://lupinix.fedorapeople.org/review/ASL.spec SRPM URL: https://lupinix.fedorapeople.org/review/ASL-0.1.4-0.1.fc22.src.rpm Description: Advanced Simulation Library is a free and open source multiphysics simulation software package and a tool for solving Partial Differential Equations. It has significant user base across many areas of engineering and science, from both industrial and academic organizations. ASL utilizes only the methods that allow efficient parallelization: Lattice Boltzmann Methods, Explicit Finite Difference, Matrix Free Finite Elements, etc. and exploits all available hardware resources, such as SIMD, local cache, etc.. Once written, an ASL-based application can be deployed on a variety of architectures, such as CPU, GPU, FPGA, DSP, clusters and supercomputers, sometimes even without recompilation. ASL has an extensive range of features to solve anything from complex fluid flows involving chemical reactions, turbulence and heat transfer, to solid mechanics and elasticity. Fedora Account System Username: lupinix Koji builds: Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10411683 F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10411726 F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10411778 F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10411803 Thanks for review in advance!
Please wait, after running fedora-review, I recognized that a package "ASL" doesn't exist right now, but a package called "asl" => have to check
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.4-0.1.fc22.src.rpm Package will be named libASL to be conform with Naming Guidelines
OK, there are more conflicts to be resolved... I have to contact upstream.
Just a drive-by comment: > %package devel > Requires: cmake Clearly overhead for a -devel package that also provides a pkg-config file. If you only want "cmake" for directory ownership, it is permissible to include also %{_libdir}/cmake in your package: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function > Requires: pkgconfig Nowadays there's an automatic dependency on /usr/bin/pkgconfig and automatic dependencies for .pc file inter-dependencies, too. Even on RHEL6. > %{_libdir}/cmake/%{upstream}/*.cmake Directory %{_libdir}/cmake/%{upstream} is not included in the package. > %exclude %{_pkgdocdir}/html %exclude without a corresponding include of the same path name is dangerous. %exclude hides the file(s) from all %files sections and can lead to missing files in the built packages. Your spec file is not clear with regard to movement/removal of some doc files, such as %{_docdir}/%{upstream}/html, and how %_pkgdocdir/html fits into that.
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.1.fc21.src.rpm I think the package is ready for review now :)
lupinix's scratch build of libASL-0.1.6-0.1.fc22.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11235990
1. %package examples Summary: Examples for %{name} %description examples The %{name}-doc package contains examples for %{name} Copy paste typo. 2. Missing include of %{_libdir}/cmake/%{upstream}/ 3. Requires: boost-devel Requires: matio-devel Requires: netcdf-cxx-devel Requires: ocl-icd-devel Requires: opencl-headers Requires: vtk-devel No, %{?_isa} is still needed. Like boost-devel%{?_isa}
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.2.fc21.src.rpm Koji Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11237273 Thank you very much for your comments Christopher! Should be fixed now.
lupinix's scratch build of libASL-0.1.6-0.2.fc21.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11237273
lupinix's scratch build of libASL-0.1.6-0.2.fc21.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11237671
I don't understand the failure, package building fine
lupinix's scratch build of libASL-0.1.6-0.3.fc21.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11238219
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.3.fc21.src.rpm noarch for -doc supbackage was the reason, builds fine now :) Koji builds: Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=11238219 F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=11238239 F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=11238232 F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=11238228
A quick look into your spec file shows some hints and advices. Later, I could do the official review run. Currently, I do not find any blockers, so I hope the review can pass quickly. . (SHOULD/<rant>) Please use %{upstream} consistently or not at all. Well, it seems to me somehow to be ridiculous to use a macro with a longer name than the shorter text by itself, therefore you maybe want to replace it in %description as well? - Name: libASL + Name: lib%{upstream} . (SHOULD) Again, please use consistently the macros. Either decide to use "mkdir -p", %{__mkdir_p}, or "%{__mkdir} -p". I guess you want to keep with %{__mkdir_p} as you do in %install. %prep %setup -q -n %{upstream}-%{version} - %{__mkdir} -p %{_cmake_build_subdir} + %{__mkdir_p} %{_cmake_build_subdir} . (SHOULD) examples could be merged into doc subpackage to avoid just another subpackage without any additional benefit but that's somehow related to any personal preference. . (SHOULD) pushd/popd is not needed in %install - pushd %{_cmake_build_subdir} - %make_install - popd + %make_install -C %{_cmake_build_subdir} . (SHOULD) You could use delete parameter of find command, this makes it easier to read and execution may be faster. - find %{buildroot} -name '*.la' -exec rm -f {} ';' + find %{buildroot} -name '*.la' -delete . (SHOULD) Please consider to use %check for execution of some files from the tests folder. You mentioned somehow OpenCL as a possible fail reason, can you disable individually those dedicated tests to have at least a basic QA inside the build?
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.4.fc23.src.rpm
Thank you for your remarks Raphael! I fixed the spec file, except: * I'll stick with examples package (it's arched, -doc will be noarch again hopefully in next releases) * checks do not work on Koji due to heavy OpenCL usage by ASL. Maybe I find a way using POCL later, but there are upstream bugs avoiding it right now.
lupinix's scratch build of libASL-0.1.6-0.4.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11751101
Also builds fine for F22 and F23 F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=11751151 F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=11751147
fedora-review gives me FTBFS in mock -r rawhide, while running it on a F23 system. We guess it's a bug/problem with dnf. Maybe f-r could be reconfigured to run the failing part with yum.
Yes, running mock with yum instead of dnf solves the FTBS. Other possibilty would be teh usage of provided koji builds.
Following line should do it: mock --clean --init --yum -r fedora-rawhide-x86_64 && fedora-review -v -m fedora-rawhide-x86_64 -o "--yum " -b 1244797
Issues: - License: AGPLv3 and BSD and MIT - Please validate source files without proper license header. - Include license text(s) into every subpackage. - Use Require: libASL where appropriate for subpackages. - Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (3 clause)", "AGPL (v3)", "Unknown or generated". 38 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/1244797-libASL/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 28 files. => False positive IMHO, maybe f-r thinks doc or examples is main package. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libASL- bin , libASL-doc , libASL-examples , libASL-debuginfo [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 78438400 bytes in /usr/share libASL-doc-0.1.6-0.4.fc24.x86_64.rpm:78202880 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libASL-0.1.6-0.4.fc24.x86_64.rpm libASL-bin-0.1.6-0.4.fc24.x86_64.rpm libASL-devel-0.1.6-0.4.fc24.x86_64.rpm libASL-doc-0.1.6-0.4.fc24.x86_64.rpm libASL-examples-0.1.6-0.4.fc24.x86_64.rpm libASL-debuginfo-0.1.6-0.4.fc24.x86_64.rpm libASL-0.1.6-0.4.fc24.src.rpm libASL.x86_64: W: spelling-error %description -l en_US multiphysics -> multiplicity libASL.x86_64: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization libASL.x86_64: W: shared-lib-calls-exit /usr/lib64/libasl.so.0.1.6 exit.5 libASL-bin.x86_64: W: no-documentation libASL-bin.x86_64: W: no-manual-page-for-binary asl-hardware libASL-devel.x86_64: W: only-non-binary-in-usr-lib libASL-devel.x86_64: W: no-documentation libASL-examples.x86_64: W: no-manual-page-for-binary asl-bus_wind libASL-examples.x86_64: W: no-manual-page-for-binary asl-multicomponent_flow libASL-examples.x86_64: W: no-manual-page-for-binary asl-cubeGravity libASL-examples.x86_64: W: no-manual-page-for-binary asl-flowRotatingCylinders libASL-examples.x86_64: W: no-manual-page-for-binary asl-levelSetBasic libASL-examples.x86_64: W: no-manual-page-for-binary asl-testSMPhi libASL-examples.x86_64: W: no-manual-page-for-binary asl-surfaceFlux libASL-examples.x86_64: W: no-manual-page-for-binary asl-testSMDiff3C libASL-examples.x86_64: W: no-manual-page-for-binary asl-poroelastic libASL-examples.x86_64: W: no-manual-page-for-binary asl-flow libASL-examples.x86_64: W: no-manual-page-for-binary asl-multiphase_flow libASL-examples.x86_64: W: no-manual-page-for-binary asl-testSMDiff libASL-examples.x86_64: W: no-manual-page-for-binary asl-flow3 libASL-examples.x86_64: W: no-manual-page-for-binary asl-cubePoroelasticGravity libASL-examples.x86_64: W: no-manual-page-for-binary asl-pitot_tube_ice libASL-examples.x86_64: W: no-manual-page-for-binary asl-locomotive_stability libASL-examples.x86_64: W: no-manual-page-for-binary asl-locomotive_laminar libASL-examples.x86_64: W: no-manual-page-for-binary asl-compressor libASL-examples.x86_64: W: no-manual-page-for-binary asl-acousticWaves libASL-examples.x86_64: W: no-manual-page-for-binary asl-cubeIncompressibleGravity libASL-examples.x86_64: W: no-manual-page-for-binary asl-flowKDPGrowth libASL-examples.x86_64: W: no-manual-page-for-binary asl-jumpingBox libASL-examples.x86_64: W: no-manual-page-for-binary asl-locomotive libASL-examples.x86_64: W: no-manual-page-for-binary asl-levelSetNormalGrowth libASL-examples.x86_64: W: no-manual-page-for-binary asl-flow2 libASL-examples.x86_64: W: no-manual-page-for-binary asl-levelSetFacetedGrowth libASL-examples.x86_64: W: no-manual-page-for-binary asl-testSMPhiBV libASL.src: W: spelling-error %description -l en_US multiphysics -> multiplicity libASL.src: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization libASL.src:85: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 85) 7 packages and 0 specfiles checked; 0 errors, 37 warnings. Rpmlint (debuginfo) ------------------- Checking: libASL-debuginfo-0.1.6-0.4.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- libASL.x86_64: W: shared-lib-calls-exit /usr/lib64/libasl.so.0.1.6 exit.5 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libz.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkIOXMLParser.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libexpat.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libjpeg.so.62 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libpng16.so.16 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libtiff.so.5 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libnetcdf_c++.so.4 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libnetcdf.so.7 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libhdf5.so.10 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libhdf5_hl.so.10 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libdl.so.2 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkViewsCore.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkInteractionWidgets.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkFiltersModeling.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkImagingGeneral.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkImagingHybrid.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkRenderingAnnotation.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkImagingColor.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libfreetype.so.6 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkftgl.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkRenderingVolume.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkImagingSources.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkIOCore.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkDICOMParser.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkmetaio.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libGL.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkRenderingCore.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkCommonColor.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkFiltersExtraction.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkFiltersStatistics.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkImagingFourier.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkalglib.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkFiltersGeometry.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkFiltersSources.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkFiltersGeneral.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkFiltersCore.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkCommonComputationalGeometry.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkImagingCore.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkCommonMisc.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkCommonSystem.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtksys.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkCommonTransforms.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /usr/lib64/vtk/libvtkCommonMath.so.1 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslvtk.so.0.1.6 /lib64/libm.so.6 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslnumext.so.0.1.6 /lib64/libm.so.6 libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_SCHAR_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_ULONG_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_HSIZE_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_STD_REF_OBJ_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_DOUBLE_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_ULLONG_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_INT_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5P_CLS_DATASET_CREATE_ID_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_UINT_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_SHORT_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_USHORT_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_LONG_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_UCHAR_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_NATIVE_FLOAT_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5P_CLS_FILE_CREATE_ID_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5T_C_S1_g libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Sselect_elements libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Tget_class libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Eprint1 libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Tcopy libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Fopen libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Awrite libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Pset_deflate libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Dread libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Gget_objname_by_idx libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Iinc_ref libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5check_version libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Dopen2 libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Dget_type libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Aclose libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Sselect_hyperslab libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Eset_auto2 libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Gopen2 libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Aopen_name libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Dvlen_reclaim libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Screate libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Dclose libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Dwrite libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Tcreate libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Gget_num_objs libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Tset_size libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Aget_space libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Acreate2 libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Iget_type libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Sget_simple_extent_dims libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Pset_userblock libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Iget_name libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Aread libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Fclose libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Tget_size libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Eget_auto2 libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Tvlen_create libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Dget_space libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Sclose libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Sget_simple_extent_ndims libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Dcreate2 libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Rdereference libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Gclose libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Gcreate2 libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Pclose libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Aget_type libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Pcreate libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Fcreate libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Tclose libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Gget_objtype_by_idx libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Screate_simple libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Tinsert libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Rcreate libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5open libASL.x86_64: W: undefined-non-weak-symbol /usr/lib64/libaslmatio.so.0.1.6 H5Pset_chunk libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslmatio.so.0.1.6 /lib64/libm.so.6 libASL.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libaslcommon.so.0.1.6 /lib64/libm.so.6 libASL-bin.x86_64: W: no-documentation libASL-bin.x86_64: W: no-manual-page-for-binary asl-hardware libASL-examples.x86_64: W: no-manual-page-for-binary asl-cubeGravity libASL-examples.x86_64: W: no-manual-page-for-binary asl-levelSetFacetedGrowth libASL-examples.x86_64: W: no-manual-page-for-binary asl-flowKDPGrowth libASL-examples.x86_64: W: no-manual-page-for-binary asl-testSMDiff3C libASL-examples.x86_64: W: no-manual-page-for-binary asl-locomotive_laminar libASL-examples.x86_64: W: no-manual-page-for-binary asl-flowRotatingCylinders libASL-examples.x86_64: W: no-manual-page-for-binary asl-bus_wind libASL-examples.x86_64: W: no-manual-page-for-binary asl-flow libASL-examples.x86_64: W: no-manual-page-for-binary asl-locomotive libASL-examples.x86_64: W: no-manual-page-for-binary asl-acousticWaves libASL-examples.x86_64: W: no-manual-page-for-binary asl-jumpingBox libASL-examples.x86_64: W: no-manual-page-for-binary asl-multicomponent_flow libASL-examples.x86_64: W: no-manual-page-for-binary asl-cubeIncompressibleGravity libASL-examples.x86_64: W: no-manual-page-for-binary asl-flow3 libASL-examples.x86_64: W: no-manual-page-for-binary asl-levelSetBasic libASL-examples.x86_64: W: no-manual-page-for-binary asl-surfaceFlux libASL-examples.x86_64: W: no-manual-page-for-binary asl-compressor libASL-examples.x86_64: W: no-manual-page-for-binary asl-testSMDiff libASL-examples.x86_64: W: no-manual-page-for-binary asl-testSMPhi libASL-examples.x86_64: W: no-manual-page-for-binary asl-poroelastic libASL-examples.x86_64: W: no-manual-page-for-binary asl-testSMPhiBV libASL-examples.x86_64: W: no-manual-page-for-binary asl-flow2 libASL-examples.x86_64: W: no-manual-page-for-binary asl-pitot_tube_ice libASL-examples.x86_64: W: no-manual-page-for-binary asl-levelSetNormalGrowth libASL-examples.x86_64: W: no-manual-page-for-binary asl-cubePoroelasticGravity libASL-examples.x86_64: W: no-manual-page-for-binary asl-locomotive_stability libASL-examples.x86_64: W: no-manual-page-for-binary asl-multiphase_flow libASL-devel.x86_64: W: only-non-binary-in-usr-lib libASL-devel.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 149 warnings. Requires -------- libASL (rpmlib, GLIBC filtered): /sbin/ldconfig libGL.so.1()(64bit) libOpenCL.so.1()(64bit) libOpenCL.so.1(OPENCL_1.0)(64bit) libOpenCL.so.1(OPENCL_1.1)(64bit) libOpenCL.so.1(OPENCL_1.2)(64bit) libasl.so.0()(64bit) libaslacl.so.0()(64bit) libaslcommon.so.0()(64bit) libaslnum.so.0()(64bit) libboost_filesystem.so.1.59.0()(64bit) libboost_program_options.so.1.59.0()(64bit) libboost_system.so.1.59.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libhdf5.so.10()(64bit) libhdf5_hl.so.10()(64bit) libjpeg.so.62()(64bit) libm.so.6()(64bit) libmatio.so.2()(64bit) libnetcdf.so.7()(64bit) libnetcdf_c++.so.4()(64bit) libpng16.so.16()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtiff.so.5()(64bit) libvtkCommonColor.so.1()(64bit) libvtkCommonComputationalGeometry.so.1()(64bit) libvtkCommonCore.so.1()(64bit) libvtkCommonDataModel.so.1()(64bit) libvtkCommonExecutionModel.so.1()(64bit) libvtkCommonMath.so.1()(64bit) libvtkCommonMisc.so.1()(64bit) libvtkCommonSystem.so.1()(64bit) libvtkCommonTransforms.so.1()(64bit) libvtkDICOMParser.so.1()(64bit) libvtkFiltersCore.so.1()(64bit) libvtkFiltersExtraction.so.1()(64bit) libvtkFiltersGeneral.so.1()(64bit) libvtkFiltersGeometry.so.1()(64bit) libvtkFiltersHybrid.so.1()(64bit) libvtkFiltersModeling.so.1()(64bit) libvtkFiltersSources.so.1()(64bit) libvtkFiltersStatistics.so.1()(64bit) libvtkIOCore.so.1()(64bit) libvtkIOGeometry.so.1()(64bit) libvtkIOImage.so.1()(64bit) libvtkIOLegacy.so.1()(64bit) libvtkIOMINC.so.1()(64bit) libvtkIOXML.so.1()(64bit) libvtkIOXMLParser.so.1()(64bit) libvtkImagingColor.so.1()(64bit) libvtkImagingCore.so.1()(64bit) libvtkImagingFourier.so.1()(64bit) libvtkImagingGeneral.so.1()(64bit) libvtkImagingHybrid.so.1()(64bit) libvtkImagingSources.so.1()(64bit) libvtkInteractionStyle.so.1()(64bit) libvtkInteractionWidgets.so.1()(64bit) libvtkRenderingAnnotation.so.1()(64bit) libvtkRenderingCore.so.1()(64bit) libvtkRenderingFreeType.so.1()(64bit) libvtkRenderingVolume.so.1()(64bit) libvtkViewsCore.so.1()(64bit) libvtkalglib.so.1()(64bit) libvtkftgl.so.1()(64bit) libvtkmetaio.so.1()(64bit) libvtksys.so.1()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) libASL-bin (rpmlib, GLIBC filtered): libOpenCL.so.1()(64bit) libOpenCL.so.1(OPENCL_1.0)(64bit) libOpenCL.so.1(OPENCL_1.2)(64bit) libaslacl.so.0()(64bit) libaslcommon.so.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) libASL-doc (rpmlib, GLIBC filtered): libASL-debuginfo (rpmlib, GLIBC filtered): libASL-examples (rpmlib, GLIBC filtered): libOpenCL.so.1()(64bit) libOpenCL.so.1(OPENCL_1.0)(64bit) libasl.so.0()(64bit) libaslacl.so.0()(64bit) libaslcommon.so.0()(64bit) libaslnum.so.0()(64bit) libaslvtk.so.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) libASL-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config boost-devel(x86-64) libASL(x86-64) libasl.so.0()(64bit) libaslacl.so.0()(64bit) libaslcommon.so.0()(64bit) libaslmatio.so.0()(64bit) libaslnum.so.0()(64bit) libaslnumext.so.0()(64bit) libaslvtk.so.0()(64bit) matio-devel(x86-64) netcdf-cxx-devel(x86-64) ocl-icd-devel(x86-64) opencl-headers vtk-devel(x86-64) Provides -------- libASL: libASL libASL(x86-64) libasl.so.0()(64bit) libaslacl.so.0()(64bit) libaslcommon.so.0()(64bit) libaslmatio.so.0()(64bit) libaslnum.so.0()(64bit) libaslnumext.so.0()(64bit) libaslvtk.so.0()(64bit) libASL-bin: libASL-bin libASL-bin(x86-64) libASL-doc: libASL-doc libASL-doc(x86-64) libASL-debuginfo: libASL-debuginfo libASL-debuginfo(x86-64) libASL-examples: libASL-examples libASL-examples(x86-64) libASL-devel: cmake(ASL) libASL-devel libASL-devel(x86-64) pkgconfig(ASL) Source checksums ---------------- https://github.com/AvtechScientific/ASL/archive/v0.1.6.tar.gz : CHECKSUM(SHA256) this package : b35510c2a82f96237d5cc54d727922db00b71c7d6439591ff50882d08f8314d6 CHECKSUM(SHA256) upstream package : b35510c2a82f96237d5cc54d727922db00b71c7d6439591ff50882d08f8314d6 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -v -mfedora-rawhide-x86_64 -o --yum -b 1244797 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Created attachment 1091874 [details] licensecheck.txt
Thank you very much for your review :) About the issues: Issues: - License: AGPLv3 and BSD and MIT ==> Will fix it - Please validate source files without proper license header. ==> These files (mostly pics in doc) are AGPL too - Include license text(s) into every subpackage. ==> Well, license is installed in every case because of dependency to libASL, but I can add them there too. - Use Require: libASL where appropriate for subpackages. ==> dep will be recognized automatically, but as there won't be a negative effect by adding them I'll do it.
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.5.fc22.src.rpm Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11758115
lupinix's scratch build of libASL-0.1.6-0.5.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11758115
Fine now. (SHOULD) Notice that an user of the examples may want to install the devel subpackage instead of just the main package only. Maybe you want to modify that Require there again? You could also additionally add Suggests: libASL-examples to both doc and devel subpackages, but that's up to you and only a personal preference.
Thank you again :) Well this depends on use case, maybe a user just wants to run the provides examples as binaries.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/libASL
libASL-0.1.6-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-d8e74569ad
libASL-0.1.6-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-eb911d4af4
libASL-0.1.6-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update libASL' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-eb911d4af4
libASL-0.1.6-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update libASL' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-d8e74569ad
libASL-0.1.6-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
libASL-0.1.6-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.